linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: xiechao.mail@gmail.com (Chao Xie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 11/29] usb: ehci: ehci-mv: use PHY driver for ehci
Date: Wed, 21 Nov 2012 21:04:52 -0500	[thread overview]
Message-ID: <1353549910-988-11-git-send-email-xiechao.mail@gmail.com> (raw)
In-Reply-To: <1353549910-988-1-git-send-email-xiechao.mail@gmail.com>

From: Chao Xie <chao.xie@marvell.com>

Signed-off-by: Chao Xie <xiechao.mail@gmail.com>
---
 drivers/usb/host/ehci-mv.c |   37 +++++++++++++------------------------
 1 files changed, 13 insertions(+), 24 deletions(-)

diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c
index 3065809..be504fd 100644
--- a/drivers/usb/host/ehci-mv.c
+++ b/drivers/usb/host/ehci-mv.c
@@ -15,17 +15,18 @@
 #include <linux/clk.h>
 #include <linux/err.h>
 #include <linux/usb/otg.h>
+#include <linux/usb/mv_usb2.h>
 #include <linux/platform_data/mv_usb.h>
 
 #define CAPLENGTH_MASK         (0xff)
 
 struct ehci_hcd_mv {
 	struct usb_hcd *hcd;
+	struct mv_usb2_phy *mvphy;
 
 	/* Which mode does this ehci running OTG/Host ? */
 	int mode;
 
-	void __iomem *phy_regs;
 	void __iomem *cap_regs;
 	void __iomem *op_regs;
 
@@ -59,8 +60,8 @@ static int mv_ehci_enable(struct ehci_hcd_mv *ehci_mv)
 	int retval;
 
 	ehci_clock_enable(ehci_mv);
-	if (ehci_mv->pdata->phy_init) {
-		retval = ehci_mv->pdata->phy_init(ehci_mv->phy_regs);
+	if (ehci_mv->mvphy->init) {
+		retval = ehci_mv->mvphy->init(ehci_mv->mvphy);
 		if (retval)
 			return retval;
 	}
@@ -70,8 +71,8 @@ static int mv_ehci_enable(struct ehci_hcd_mv *ehci_mv)
 
 static void mv_ehci_disable(struct ehci_hcd_mv *ehci_mv)
 {
-	if (ehci_mv->pdata->phy_deinit)
-		ehci_mv->pdata->phy_deinit(ehci_mv->phy_regs);
+	if (ehci_mv->mvphy->shutdown)
+		ehci_mv->mvphy->shutdown(ehci_mv->mvphy);
 	ehci_clock_disable(ehci_mv);
 }
 
@@ -184,22 +185,7 @@ static int mv_ehci_probe(struct platform_device *pdev)
 		}
 	}
 
-	r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "phyregs");
-	if (r == NULL) {
-		dev_err(&pdev->dev, "no phy I/O memory resource defined\n");
-		retval = -ENODEV;
-		goto err_clear_drvdata;
-	}
-
-	ehci_mv->phy_regs = devm_ioremap(&pdev->dev, r->start,
-					 resource_size(r));
-	if (ehci_mv->phy_regs == 0) {
-		dev_err(&pdev->dev, "failed to map phy I/O memory\n");
-		retval = -EFAULT;
-		goto err_clear_drvdata;
-	}
-
-	r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "capregs");
+	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	if (!r) {
 		dev_err(&pdev->dev, "no I/O memory resource defined\n");
 		retval = -ENODEV;
@@ -214,6 +200,12 @@ static int mv_ehci_probe(struct platform_device *pdev)
 		goto err_clear_drvdata;
 	}
 
+	ehci_mv->mvphy = mv_usb2_get_phy();
+	if (ehci_mv->mvphy == NULL) {
+		retval = -ENODEV;
+		goto err_clear_drvdata;
+	}
+
 	retval = mv_ehci_enable(ehci_mv);
 	if (retval) {
 		dev_err(&pdev->dev, "init phy error %d\n", retval);
@@ -275,9 +267,6 @@ static int mv_ehci_probe(struct platform_device *pdev)
 		}
 	}
 
-	if (pdata->private_init)
-		pdata->private_init(ehci_mv->op_regs, ehci_mv->phy_regs);
-
 	dev_info(&pdev->dev,
 		 "successful find EHCI device with regs 0x%p irq %d"
 		 " working in %s mode\n", hcd->regs, hcd->irq,
-- 
1.7.4.1

  parent reply	other threads:[~2012-11-22  2:04 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-22  2:04 [PATCH 01/29] usb: gadget: mv_udc: use udc_start and udc_stop functions Chao Xie
2012-11-22  2:04 ` [PATCH 02/29] usb: gadget: mv_udc: use devm_xxx for probe Chao Xie
2012-11-22  2:04 ` [PATCH 03/29] usb: gadget: mv_udc: fix the clk APIs Chao Xie
2012-11-22  2:04 ` [PATCH 04/29] usb: otg: mv_otg: use devm_xxx for probe Chao Xie
2012-11-22  2:04 ` [PATCH 05/29] usb: otg: mv_otg: fix the clk APIs Chao Xie
2012-11-22  2:04 ` [PATCH 06/29] usb: host: ehci-mv: fix " Chao Xie
2012-11-23 16:06   ` Alan Stern
2012-11-22  2:04 ` [PATCH 07/29] usb: host: ehci-mv: remove unused variable Chao Xie
2012-11-22  2:04 ` [PATCH 08/29] usb: gadget: mv_udc: fix the value of tranceiver Chao Xie
2012-11-22  2:04 ` [PATCH 09/29] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller Chao Xie
2012-11-22  2:04 ` [PATCH 10/29] usb: gadget: mv_udc: use PHY driver for udc Chao Xie
2012-11-22  2:04 ` Chao Xie [this message]
2012-11-22  2:04 ` [PATCH 12/29] usb: otg: mv_otg: use PHY driver for otg Chao Xie
2012-11-22  2:04 ` [PATCH 13/29] arm: mmp2: change the defintion of usb devices Chao Xie
2012-11-22  2:04 ` [PATCH 14/29] arm: pxa910: " Chao Xie
2012-11-22  2:04 ` [PATCH 15/29] arm: brownstone: add usb support for the board Chao Xie
2012-11-22  2:04 ` [PATCH 16/29] arm: ttc_dkb: add usb support Chao Xie
2012-11-22  2:04 ` [PATCH 17/29] arm: mmp: remove the usb phy setting Chao Xie
2012-11-22  2:04 ` [PATCH 18/29] arm: mmp: remove usb devices from pxa168 Chao Xie
2012-11-22  2:05 ` [PATCH 19/29] usb: phy: mv_usb2_phy: add externel chip support Chao Xie
2012-11-22  2:05 ` [PATCH 20/29] usb: gadget: mv_udc: add extern " Chao Xie
2012-11-22  2:05 ` [PATCH 21/29] usb: ehci: ehci-mv: " Chao Xie
2012-11-22  2:05 ` [PATCH 22/29] usb: otg: mv_otg: " Chao Xie
2012-11-22  2:05 ` [PATCH 23/29] arm: mmp: add extern chip support for brownstone Chao Xie
2012-11-22  2:05 ` [PATCH 24/29] arm: mmp: add extern chip support for ttc_dkb Chao Xie
2012-11-22  2:05 ` [PATCH 25/29] usb: gadget: mv_udc: add device tree support Chao Xie
2012-11-22  2:05 ` [PATCH 26/29] usb: otg: mv_otg: " Chao Xie
2012-11-22  2:05 ` [PATCH 27/29] usb: ehci: ehci-mv: " Chao Xie
2012-11-22  2:05 ` [PATCH 28/29] arm: mmp: devicetree: add usb support for mmp2 Chao Xie
2012-11-22  2:05 ` [PATCH 29/29] arm: mmp: devicetree: add usb support for pxa910_dkb Chao Xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353549910-988-11-git-send-email-xiechao.mail@gmail.com \
    --to=xiechao.mail@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).