From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] mfd: Simplify IRQ domain registration code in STMPE
Date: Fri, 23 Nov 2012 15:19:29 +0000 [thread overview]
Message-ID: <1353683969-9332-1-git-send-email-lee.jones@linaro.org> (raw)
Historically, a driver would have to decide whether it required
a Linear or Legacy IRQ domain when registering one. This can end
up as quite a lot of code. A new Simple call now exists which
simplifies this process. Let's make use of it here.
Cc: Samuel Ortiz <sameo@linux.intel.com>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/mfd/stmpe.c | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
index b03cc64..0e6d8b8 100644
--- a/drivers/mfd/stmpe.c
+++ b/drivers/mfd/stmpe.c
@@ -889,18 +889,14 @@ static struct irq_domain_ops stmpe_irq_ops = {
static int __devinit stmpe_irq_init(struct stmpe *stmpe,
struct device_node *np)
{
- int base = stmpe->irq_base;
+ int base = 0;
int num_irqs = stmpe->variant->num_irqs;
- if (base) {
- stmpe->domain = irq_domain_add_legacy(
- np, num_irqs, base, 0, &stmpe_irq_ops, stmpe);
- }
- else {
- stmpe->domain = irq_domain_add_linear(
- np, num_irqs, &stmpe_irq_ops, stmpe);
- }
+ if (!np)
+ base = stmpe->irq_base;
+ stmpe->domain = irq_domain_add_simple(np, num_irqs, base,
+ &stmpe_irq_ops, stmpe);
if (!stmpe->domain) {
dev_err(stmpe->dev, "Failed to create irqdomain\n");
return -ENOSYS;
--
1.7.9.5
next reply other threads:[~2012-11-23 15:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 15:19 Lee Jones [this message]
2012-11-30 14:01 ` [PATCH 1/1] mfd: Simplify IRQ domain registration code in STMPE Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2012-11-23 12:56 Lee Jones
2012-11-23 12:59 ` Viresh Kumar
2012-12-01 15:56 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353683969-9332-1-git-send-email-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).