From: xiechao.mail@gmail.com (Chao Xie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/27] usb: gadget: mv_udc: use PHY driver for udc
Date: Sun, 25 Nov 2012 23:43:23 -0500 [thread overview]
Message-ID: <1353905020-29372-11-git-send-email-xiechao.mail@gmail.com> (raw)
In-Reply-To: <1353905020-29372-1-git-send-email-xiechao.mail@gmail.com>
From: Chao Xie <chao.xie@marvell.com>
Originaly, udc driver will call the callbacks in platform data
for PHY initialization and shut down.
With PHY driver, it will call the APIs provided by PHY driver
for PHY initialization and shut down. It removes the callbacks
in platform data, and at same time it removes one block in the
way of enabling device tree for udc driver.
Signed-off-by: Chao Xie <xiechao.mail@gmail.com>
---
drivers/usb/gadget/mv_udc.h | 2 +-
drivers/usb/gadget/mv_udc_core.c | 23 ++++++++---------------
2 files changed, 9 insertions(+), 16 deletions(-)
diff --git a/drivers/usb/gadget/mv_udc.h b/drivers/usb/gadget/mv_udc.h
index 9073436..4851b2b 100644
--- a/drivers/usb/gadget/mv_udc.h
+++ b/drivers/usb/gadget/mv_udc.h
@@ -180,7 +180,6 @@ struct mv_udc {
struct mv_cap_regs __iomem *cap_regs;
struct mv_op_regs __iomem *op_regs;
- void __iomem *phy_regs;
unsigned int max_eps;
struct mv_dqh *ep_dqh;
size_t ep_dqh_size;
@@ -217,6 +216,7 @@ struct mv_udc {
struct work_struct vbus_work;
struct workqueue_struct *qwork;
+ struct mv_usb2_phy *phy;
struct usb_phy *transceiver;
struct mv_usb_platform_data *pdata;
diff --git a/drivers/usb/gadget/mv_udc_core.c b/drivers/usb/gadget/mv_udc_core.c
index c4adfeb..6f01d5e 100644
--- a/drivers/usb/gadget/mv_udc_core.c
+++ b/drivers/usb/gadget/mv_udc_core.c
@@ -35,6 +35,7 @@
#include <linux/platform_device.h>
#include <linux/clk.h>
#include <linux/platform_data/mv_usb.h>
+#include <linux/usb/mv_usb2.h>
#include <asm/unaligned.h>
#include "mv_udc.h"
@@ -1121,8 +1122,8 @@ static int mv_udc_enable_internal(struct mv_udc *udc)
dev_dbg(&udc->dev->dev, "enable udc\n");
udc_clock_enable(udc);
- if (udc->pdata->phy_init) {
- retval = udc->pdata->phy_init(udc->phy_regs);
+ if (udc->phy->init) {
+ retval = udc->phy->init(udc->phy);
if (retval) {
dev_err(&udc->dev->dev,
"init phy error %d\n", retval);
@@ -1147,8 +1148,8 @@ static void mv_udc_disable_internal(struct mv_udc *udc)
{
if (udc->active) {
dev_dbg(&udc->dev->dev, "disable udc\n");
- if (udc->pdata->phy_deinit)
- udc->pdata->phy_deinit(udc->phy_regs);
+ if (udc->phy->shutdown)
+ udc->phy->shutdown(udc->phy);
udc_clock_disable(udc);
udc->active = 0;
}
@@ -2194,7 +2195,7 @@ static int __devinit mv_udc_probe(struct platform_device *pdev)
}
}
- r = platform_get_resource_byname(udc->dev, IORESOURCE_MEM, "capregs");
+ r = platform_get_resource(udc->dev, IORESOURCE_MEM, 0);
if (r == NULL) {
dev_err(&pdev->dev, "no I/O memory resource defined\n");
return -ENODEV;
@@ -2207,17 +2208,9 @@ static int __devinit mv_udc_probe(struct platform_device *pdev)
return -EBUSY;
}
- r = platform_get_resource_byname(udc->dev, IORESOURCE_MEM, "phyregs");
- if (r == NULL) {
- dev_err(&pdev->dev, "no phy I/O memory resource defined\n");
+ udc->phy = mv_usb2_get_phy();
+ if (udc->phy == NULL)
return -ENODEV;
- }
-
- udc->phy_regs = ioremap(r->start, resource_size(r));
- if (udc->phy_regs == NULL) {
- dev_err(&pdev->dev, "failed to map phy I/O memory\n");
- return -EBUSY;
- }
/* we will acces controller register, so enable the clk */
retval = mv_udc_enable_internal(udc);
--
1.7.4.1
next prev parent reply other threads:[~2012-11-26 4:43 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 4:43 [PATCH 00/27] mv-usb fix and enhancement patches Chao Xie
2012-11-26 4:43 ` [PATCH 01/27] usb: gadget: mv_udc: use udc_start and udc_stop functions Chao Xie
2012-11-26 14:39 ` Greg KH
2012-11-26 14:34 ` Felipe Balbi
2012-11-26 18:42 ` Greg KH
2012-11-26 20:06 ` Felipe Balbi
2012-11-27 1:56 ` Chao Xie
2012-11-26 4:43 ` [PATCH 02/27] usb: gadget: mv_udc: use devm_xxx for probe Chao Xie
2012-11-26 4:43 ` [PATCH 03/27] usb: gadget: mv_udc: fix the clk APIs Chao Xie
2012-11-26 4:43 ` [PATCH 04/27] usb: otg: mv_otg: use devm_xxx for probe Chao Xie
2012-11-26 4:43 ` [PATCH 05/27] usb: otg: mv_otg: fix the clk APIs Chao Xie
2012-11-26 4:43 ` [PATCH 06/27] usb: host: ehci-mv: fix " Chao Xie
2012-11-26 18:47 ` Alan Stern
2012-11-26 4:43 ` [PATCH 07/27] usb: host: ehci-mv: remove unused variable Chao Xie
2012-11-26 4:43 ` [PATCH 08/27] usb: gadget: mv_udc: fix the value of tranceiver Chao Xie
2012-11-26 4:43 ` [PATCH 09/27] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller Chao Xie
2012-11-26 4:43 ` Chao Xie [this message]
2012-11-26 4:43 ` [PATCH 11/27] usb: ehci: ehci-mv: use PHY driver for ehci Chao Xie
2012-11-26 4:43 ` [PATCH 12/27] usb: otg: mv_otg: use PHY driver for otg Chao Xie
2012-11-26 4:43 ` [PATCH 13/27] arm: mmp2: change the defintion of usb devices Chao Xie
2012-11-26 4:43 ` [PATCH 14/27] arm: pxa910: " Chao Xie
2012-11-26 4:43 ` [PATCH 15/27] arm: brownstone: add usb support for the board Chao Xie
2012-11-26 4:43 ` [PATCH 16/27] arm: ttc_dkb: add usb support Chao Xie
2012-11-26 4:43 ` [PATCH 17/27] arm: mmp: remove the usb phy setting Chao Xie
2012-11-26 4:43 ` [PATCH 18/27] arm: mmp: remove usb devices from pxa168 Chao Xie
2012-11-26 4:43 ` [PATCH 19/27] usb: phy: mv_usb2_phy: add externel chip support Chao Xie
2012-11-26 4:43 ` [PATCH 20/27] usb: gadget: mv_udc: add extern " Chao Xie
2012-11-26 4:43 ` [PATCH 21/27] usb: ehci: ehci-mv: " Chao Xie
2012-11-26 4:43 ` [PATCH 22/27] usb: otg: mv_otg: " Chao Xie
2012-11-26 4:43 ` [PATCH 23/27] arm: mmp: add extern chip support for brownstone Chao Xie
2012-11-26 4:43 ` [PATCH 24/27] arm: mmp: add extern chip support for ttc_dkb Chao Xie
2012-11-26 4:43 ` [PATCH 25/27] usb: gadget: mv_udc: add device tree support Chao Xie
2012-11-26 4:43 ` [PATCH 26/27] usb: otg: mv_otg: " Chao Xie
2012-11-26 4:43 ` [PATCH 27/27] usb: ehci: ehci-mv: " Chao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353905020-29372-11-git-send-email-xiechao.mail@gmail.com \
--to=xiechao.mail@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).