From: xiechao.mail@gmail.com (Chao Xie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/27] usb: gadget: mv_udc: fix the value of tranceiver
Date: Sun, 25 Nov 2012 23:43:21 -0500 [thread overview]
Message-ID: <1353905020-29372-9-git-send-email-xiechao.mail@gmail.com> (raw)
In-Reply-To: <1353905020-29372-1-git-send-email-xiechao.mail@gmail.com>
From: Chao Xie <chao.xie@marvell.com>
usally we will use udc->tranceiver == NULL or
udc->tranceiver != NULL.
So when failed to get the udc->tranceiver by usb_get_phy(), we
directly set udc->tranceiver to be NULL.
Then the source code will not need macro IS_ERR_OR_NULL() for
udc->tranceiver judgement. It can reduce the line size and make
the judgement simple.
Signed-off-by: Chao Xie <xiechao.mail@gmail.com>
---
drivers/usb/gadget/mv_udc_core.c | 15 ++++++++++-----
1 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/gadget/mv_udc_core.c b/drivers/usb/gadget/mv_udc_core.c
index c78d52f..c4adfeb 100644
--- a/drivers/usb/gadget/mv_udc_core.c
+++ b/drivers/usb/gadget/mv_udc_core.c
@@ -1394,7 +1394,7 @@ static int mv_udc_start(struct usb_gadget *gadget,
spin_unlock_irqrestore(&udc->lock, flags);
- if (!IS_ERR_OR_NULL(udc->transceiver)) {
+ if (udc->transceiver) {
retval = otg_set_peripheral(udc->transceiver->otg,
&udc->gadget);
if (retval) {
@@ -2174,9 +2174,14 @@ static int __devinit mv_udc_probe(struct platform_device *pdev)
udc->dev = pdev;
#ifdef CONFIG_USB_OTG_UTILS
- if (pdata->mode == MV_USB_MODE_OTG)
+ if (pdata->mode == MV_USB_MODE_OTG) {
udc->transceiver = devm_usb_get_phy(&pdev->dev,
USB_PHY_TYPE_USB2);
+ if (IS_ERR_OR_NULL(udc->transceiver)) {
+ udc->transceiver = NULL;
+ return -ENODEV;
+ }
+ }
#endif
udc->clknum = pdata->clknum;
@@ -2319,7 +2324,7 @@ static int __devinit mv_udc_probe(struct platform_device *pdev)
eps_init(udc);
/* VBUS detect: we can disable/enable clock on demand.*/
- if (!IS_ERR_OR_NULL(udc->transceiver))
+ if (udc->transceiver)
udc->clock_gating = 1;
else if (pdata->vbus) {
udc->clock_gating = 1;
@@ -2386,7 +2391,7 @@ static int mv_udc_suspend(struct device *dev)
udc = dev_get_drvdata(dev);
/* if OTG is enabled, the following will be done in OTG driver*/
- if (!IS_ERR_OR_NULL(udc->transceiver))
+ if (udc->transceiver)
return 0;
if (udc->pdata->vbus && udc->pdata->vbus->poll)
@@ -2421,7 +2426,7 @@ static int mv_udc_resume(struct device *dev)
udc = dev_get_drvdata(dev);
/* if OTG is enabled, the following will be done in OTG driver*/
- if (!IS_ERR_OR_NULL(udc->transceiver))
+ if (udc->transceiver)
return 0;
if (!udc->clock_gating) {
--
1.7.4.1
next prev parent reply other threads:[~2012-11-26 4:43 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 4:43 [PATCH 00/27] mv-usb fix and enhancement patches Chao Xie
2012-11-26 4:43 ` [PATCH 01/27] usb: gadget: mv_udc: use udc_start and udc_stop functions Chao Xie
2012-11-26 14:39 ` Greg KH
2012-11-26 14:34 ` Felipe Balbi
2012-11-26 18:42 ` Greg KH
2012-11-26 20:06 ` Felipe Balbi
2012-11-27 1:56 ` Chao Xie
2012-11-26 4:43 ` [PATCH 02/27] usb: gadget: mv_udc: use devm_xxx for probe Chao Xie
2012-11-26 4:43 ` [PATCH 03/27] usb: gadget: mv_udc: fix the clk APIs Chao Xie
2012-11-26 4:43 ` [PATCH 04/27] usb: otg: mv_otg: use devm_xxx for probe Chao Xie
2012-11-26 4:43 ` [PATCH 05/27] usb: otg: mv_otg: fix the clk APIs Chao Xie
2012-11-26 4:43 ` [PATCH 06/27] usb: host: ehci-mv: fix " Chao Xie
2012-11-26 18:47 ` Alan Stern
2012-11-26 4:43 ` [PATCH 07/27] usb: host: ehci-mv: remove unused variable Chao Xie
2012-11-26 4:43 ` Chao Xie [this message]
2012-11-26 4:43 ` [PATCH 09/27] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller Chao Xie
2012-11-26 4:43 ` [PATCH 10/27] usb: gadget: mv_udc: use PHY driver for udc Chao Xie
2012-11-26 4:43 ` [PATCH 11/27] usb: ehci: ehci-mv: use PHY driver for ehci Chao Xie
2012-11-26 4:43 ` [PATCH 12/27] usb: otg: mv_otg: use PHY driver for otg Chao Xie
2012-11-26 4:43 ` [PATCH 13/27] arm: mmp2: change the defintion of usb devices Chao Xie
2012-11-26 4:43 ` [PATCH 14/27] arm: pxa910: " Chao Xie
2012-11-26 4:43 ` [PATCH 15/27] arm: brownstone: add usb support for the board Chao Xie
2012-11-26 4:43 ` [PATCH 16/27] arm: ttc_dkb: add usb support Chao Xie
2012-11-26 4:43 ` [PATCH 17/27] arm: mmp: remove the usb phy setting Chao Xie
2012-11-26 4:43 ` [PATCH 18/27] arm: mmp: remove usb devices from pxa168 Chao Xie
2012-11-26 4:43 ` [PATCH 19/27] usb: phy: mv_usb2_phy: add externel chip support Chao Xie
2012-11-26 4:43 ` [PATCH 20/27] usb: gadget: mv_udc: add extern " Chao Xie
2012-11-26 4:43 ` [PATCH 21/27] usb: ehci: ehci-mv: " Chao Xie
2012-11-26 4:43 ` [PATCH 22/27] usb: otg: mv_otg: " Chao Xie
2012-11-26 4:43 ` [PATCH 23/27] arm: mmp: add extern chip support for brownstone Chao Xie
2012-11-26 4:43 ` [PATCH 24/27] arm: mmp: add extern chip support for ttc_dkb Chao Xie
2012-11-26 4:43 ` [PATCH 25/27] usb: gadget: mv_udc: add device tree support Chao Xie
2012-11-26 4:43 ` [PATCH 26/27] usb: otg: mv_otg: " Chao Xie
2012-11-26 4:43 ` [PATCH 27/27] usb: ehci: ehci-mv: " Chao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353905020-29372-9-git-send-email-xiechao.mail@gmail.com \
--to=xiechao.mail@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).