From: shc_work@mail.ru (Alexander Shiyan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Do not use definition "machine_arch_type" outside mach-types.h
Date: Sat, 8 Dec 2012 16:02:05 +0400 [thread overview]
Message-ID: <1354968125-664-1-git-send-email-shc_work@mail.ru> (raw)
In-Reply-To: <20121208112353.GD14363@n2100.arm.linux.org.uk>
This patch removes the use of the definition "machine_arch_type"
outside mach-types.h file. Using variable "__machine_arch_type"
that passed from the bootloader.
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/kernel/machine_kexec.c | 2 +-
arch/arm/kernel/setup.c | 2 +-
arch/arm/mach-pxa/em-x270.c | 2 +-
arch/arm/tools/gen-mach-types | 3 ---
4 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/arch/arm/kernel/machine_kexec.c b/arch/arm/kernel/machine_kexec.c
index 8ef8c93..f154d6b 100644
--- a/arch/arm/kernel/machine_kexec.c
+++ b/arch/arm/kernel/machine_kexec.c
@@ -145,7 +145,7 @@ void machine_kexec(struct kimage *image)
/* Prepare parameters for reboot_code_buffer*/
kexec_start_address = image->start;
kexec_indirection_page = page_list;
- kexec_mach_type = machine_arch_type;
+ kexec_mach_type = __machine_arch_type;
if (!kexec_boot_atags)
kexec_boot_atags = image->start - KEXEC_ARM_ZIMAGE_OFFSET + KEXEC_ARM_ATAGS_OFFSET;
diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
index 86d1429..95fcaa0 100644
--- a/arch/arm/kernel/setup.c
+++ b/arch/arm/kernel/setup.c
@@ -744,7 +744,7 @@ void __init setup_arch(char **cmdline_p)
setup_processor();
mdesc = setup_machine_fdt(__atags_pointer);
if (!mdesc)
- mdesc = setup_machine_tags(__atags_pointer, machine_arch_type);
+ mdesc = setup_machine_tags(__atags_pointer, __machine_arch_type);
machine_desc = mdesc;
machine_name = mdesc->name;
diff --git a/arch/arm/mach-pxa/em-x270.c b/arch/arm/mach-pxa/em-x270.c
index 1b64114..601ffc21 100644
--- a/arch/arm/mach-pxa/em-x270.c
+++ b/arch/arm/mach-pxa/em-x270.c
@@ -1273,7 +1273,7 @@ static void __init em_x270_init(void)
else if (machine_is_exeda())
em_x270_exeda_init();
else
- panic("Unsupported machine: %d\n", machine_arch_type);
+ panic("Unsupported machine: %d\n", __machine_arch_type);
em_x270_init_da9030();
em_x270_init_dm9000();
diff --git a/arch/arm/tools/gen-mach-types b/arch/arm/tools/gen-mach-types
index 04fef71..4a85086 100644
--- a/arch/arm/tools/gen-mach-types
+++ b/arch/arm/tools/gen-mach-types
@@ -65,8 +65,5 @@ END {
printf("#define %s()\t(0)\n", machine_is[i]);
}
- printf("\n#ifndef machine_arch_type\n");
- printf("#define machine_arch_type\t__machine_arch_type\n");
- printf("#endif\n\n");
printf("#endif\n");
}
--
1.7.8.6
next prev parent reply other threads:[~2012-12-08 12:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 15:31 Question: Multiple board support is broken Alexander Shiyan
2012-12-07 16:17 ` Russell King - ARM Linux
2012-12-08 8:28 ` Alexander Shiyan
2012-12-08 9:26 ` Russell King - ARM Linux
2012-12-08 9:58 ` Alexander Shiyan
2012-12-08 10:38 ` Russell King - ARM Linux
2012-12-08 11:18 ` Alexander Shiyan
2012-12-08 11:23 ` Russell King - ARM Linux
2012-12-08 11:59 ` Alexander Shiyan
2012-12-08 12:02 ` Alexander Shiyan [this message]
2012-12-08 12:14 ` [PATCH] ARM: Do not use definition "machine_arch_type" outside mach-types.h Russell King - ARM Linux
2012-12-09 5:21 ` [PATCH] ARM: Pass real "__machine_arch_type" variable to setup_machine_tags() procedure Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354968125-664-1-git-send-email-shc_work@mail.ru \
--to=shc_work@mail.ru \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).