From: linux@prisktech.co.nz (Tony Prisk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND 1/6] clk: omap: Fix incorrect usage of IS_ERR_OR_NULL
Date: Wed, 19 Dec 2012 06:34:03 +1300 [thread overview]
Message-ID: <1355852048-23188-2-git-send-email-linux@prisktech.co.nz> (raw)
In-Reply-To: <1355852048-23188-1-git-send-email-linux@prisktech.co.nz>
Resend to include mailing lists.
Replace IS_ERR_OR_NULL with IS_ERR on clk_get results.
Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
Acked-by: Tony Lindgren <tony@atomide.com>
---
arch/arm/plat-omap/dmtimer.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap/dmtimer.c
index 938b50a..e5e150d 100644
--- a/arch/arm/plat-omap/dmtimer.c
+++ b/arch/arm/plat-omap/dmtimer.c
@@ -143,7 +143,7 @@ int omap_dm_timer_prepare(struct omap_dm_timer *timer)
*/
if (!(timer->capability & OMAP_TIMER_NEEDS_RESET)) {
timer->fclk = clk_get(&timer->pdev->dev, "fck");
- if (WARN_ON_ONCE(IS_ERR_OR_NULL(timer->fclk))) {
+ if (WARN_ON_ONCE(IS_ERR(timer->fclk))) {
timer->fclk = NULL;
dev_err(&timer->pdev->dev, ": No fclk handle.\n");
return -EINVAL;
@@ -418,7 +418,7 @@ int omap_dm_timer_set_source(struct omap_dm_timer *timer, int source)
return pdata->set_timer_src(timer->pdev, source);
fclk = clk_get(&timer->pdev->dev, "fck");
- if (IS_ERR_OR_NULL(fclk)) {
+ if (IS_ERR(fclk)) {
pr_err("%s: fck not found\n", __func__);
return -EINVAL;
}
@@ -438,7 +438,7 @@ int omap_dm_timer_set_source(struct omap_dm_timer *timer, int source)
}
parent = clk_get(&timer->pdev->dev, parent_name);
- if (IS_ERR_OR_NULL(parent)) {
+ if (IS_ERR(parent)) {
pr_err("%s: %s not found\n", __func__, parent_name);
ret = -EINVAL;
goto out;
--
1.7.9.5
next prev parent reply other threads:[~2012-12-18 17:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 17:34 [PATCH RESEND 0/6] Remove incorrect usage of IS_ERR_OR_NULL on clk_get Tony Prisk
2012-12-18 17:34 ` Tony Prisk [this message]
2012-12-18 17:34 ` [PATCH RESEND 2/6] clk: exynos: Fix incorrect usage of IS_ERR_OR_NULL Tony Prisk
2012-12-18 18:48 ` Dan Carpenter
2012-12-18 17:34 ` [PATCH RESEND 3/6] " Tony Prisk
2012-12-18 18:39 ` Dan Carpenter
2012-12-18 18:52 ` Tony Prisk
2012-12-18 19:03 ` Dan Carpenter
2012-12-18 19:11 ` Tony Prisk
2012-12-18 19:39 ` Tony Prisk
2012-12-18 17:34 ` [PATCH RESEND 4/6] clk: s5p-tv: " Tony Prisk
2013-01-01 19:41 ` Sylwester Nawrocki
2012-12-18 17:34 ` [PATCH RESEND 5/6] clk: s5p-fimc: " Tony Prisk
2012-12-18 17:34 ` [PATCH RESEND 6/6] clk: s5p-g2d: " Tony Prisk
2012-12-22 21:53 ` Sergei Shtylyov
2013-01-01 18:33 ` Sylwester Nawrocki
2013-01-02 5:10 ` Dan Carpenter
2013-01-02 5:31 ` Tony Prisk
2013-01-02 7:29 ` Julia Lawall
2013-01-02 9:28 ` Russell King - ARM Linux
2013-01-03 9:05 ` Dan Carpenter
2013-01-03 9:14 ` Julia Lawall
2013-01-03 10:00 ` Russell King - ARM Linux
2013-01-03 10:00 ` Russell King - ARM Linux
2013-01-03 11:10 ` Dan Carpenter
2013-01-03 11:21 ` Russell King - ARM Linux
2013-01-03 13:45 ` Dan Carpenter
2013-01-03 13:52 ` Russell King - ARM Linux
2013-01-02 9:26 ` Russell King - ARM Linux
2013-01-02 9:44 ` Julia Lawall
2013-01-02 10:15 ` Russell King - ARM Linux
2013-01-02 23:14 ` Sylwester Nawrocki
2012-12-18 18:42 ` [PATCH RESEND 0/6] Remove incorrect usage of IS_ERR_OR_NULL on clk_get Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355852048-23188-2-git-send-email-linux@prisktech.co.nz \
--to=linux@prisktech.co.nz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).