From: josh.wu@atmel.com (Josh Wu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] MTD: at91: atmel_nand: for PMECC, add code to choose the ecc bits and sector size according to the ONFI parameter ECC requirement.
Date: Wed, 19 Dec 2012 18:27:18 +0800 [thread overview]
Message-ID: <1355912840-29501-2-git-send-email-josh.wu@atmel.com> (raw)
In-Reply-To: <1355912840-29501-1-git-send-email-josh.wu@atmel.com>
This patch will check NAND flash's ecc minimum requirement in ONFI parameter. If it is equal or smaller than pmecc-cap in dtsi, then use ecc_bits in ONFI. otherwise, return an error since pmecc-cap in dtsi don't meet the ecc minimum reqirement.
This patch also check sector size (codeword) requirement in ONFI. If it is equal or bigger than sector_size in dtsi, then use the one of ONFI. otherwise return error.
Currently we don't support to read the ECC parameter in ONFI extended parameter page. So in that case we just use the value specified in dts.
For non-ONFI nand flash, we assume the minimum ecc requirement is 2bits in 512 bytes.
Signed-off-by: Josh Wu <josh.wu@atmel.com>
---
drivers/mtd/nand/atmel_nand.c | 89 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 89 insertions(+)
diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index 9144557..7855ccd 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -901,6 +901,84 @@ static void atmel_pmecc_core_init(struct mtd_info *mtd)
pmecc_writel(host->ecc, CTRL, PMECC_CTRL_ENABLE);
}
+/*
+ * Get ECC requirement in ONFI parameters, returns -1 if ONFI
+ * parameters is not supported.
+ * return 0 if success to get the ECC requirement.
+ */
+static int get_onfi_ecc_param(struct nand_chip *chip,
+ int *ecc_bits, int *sector_size)
+{
+ *ecc_bits = *sector_size = 0;
+
+ if (chip->onfi_params.ecc_bits == 0xff)
+ /* TODO: the sector_size and ecc_bits need to be find in
+ * extended ecc parameter, currently we don't support it.
+ */
+ return -1;
+
+ *ecc_bits = chip->onfi_params.ecc_bits;
+
+ /* The default sector size (ecc codeword size) is 512 */
+ *sector_size = 512;
+
+ return 0;
+}
+
+/*
+ * Choose ecc cap and sector size in atmel_nand_host according to ONFI
+ * parameters ecc requirement.
+ * return 0 if success. otherwise return error code.
+ */
+static int pmecc_choose_ecc_bits(struct atmel_nand_host *host,
+ struct nand_chip *chip)
+{
+ int ecc_bits, sector_size;
+
+ if (!get_onfi_ecc_param(chip, &ecc_bits, §or_size)) {
+ dev_info(host->dev, "ONFI params, minimum required ECC: %dbits in %d bytes\n",
+ ecc_bits, sector_size);
+
+ if (ecc_bits > host->pmecc_corr_cap) {
+ dev_err(host->dev, "Error: Need to set a bigger pmecc-cap in dts. Current is: %d\n",
+ host->pmecc_corr_cap);
+ return -EINVAL;
+ }
+ if (sector_size < host->pmecc_sector_size) {
+ dev_err(host->dev, "Error: Need to set a smaller pmecc-sector-size in dts. Current is: %d\n",
+ host->pmecc_sector_size);
+ return -EINVAL;
+ }
+
+ /* use the most fitable ecc bits (the near bigger one ) */
+ if (ecc_bits <= 2)
+ host->pmecc_corr_cap = 2;
+ else if (ecc_bits <= 4)
+ host->pmecc_corr_cap = 4;
+ else if (ecc_bits < 8)
+ host->pmecc_corr_cap = 8;
+ else if (ecc_bits < 12)
+ host->pmecc_corr_cap = 12;
+ else if (ecc_bits < 24)
+ host->pmecc_corr_cap = 24;
+ else
+ return -EINVAL;
+
+ /* use the most fitable sector size (the near smaller one ) */
+ if (sector_size >= 1024)
+ host->pmecc_sector_size = 1024;
+ else if (sector_size >= 512)
+ host->pmecc_sector_size = 512;
+ else
+ return -EINVAL;
+ } else {
+ dev_info(host->dev,
+ "NAND chip ECC reqirement is in Extended ONFI parameter, we don't support yet. So use default setting in dts\n");
+ }
+
+ return 0;
+}
+
static int __init atmel_pmecc_nand_init_params(struct platform_device *pdev,
struct atmel_nand_host *host)
{
@@ -909,8 +987,19 @@ static int __init atmel_pmecc_nand_init_params(struct platform_device *pdev,
struct resource *regs, *regs_pmerr, *regs_rom;
int cap, sector_size, err_no;
+ if (nand_chip->onfi_version) {
+ /* Choose ecc cap and sector size base on ONFI parameters */
+ err_no = pmecc_choose_ecc_bits(host, nand_chip);
+ if (err_no)
+ return err_no;
+ } else {
+ dev_info(host->dev, "NAND chip is not ONFI compliant, assume ecc_bits is 2");
+ host->pmecc_corr_cap = 2;
+ }
+
cap = host->pmecc_corr_cap;
sector_size = host->pmecc_sector_size;
+
dev_info(host->dev, "Initialize PMECC params, cap: %d, sector: %d\n",
cap, sector_size);
--
1.7.9.5
next prev parent reply other threads:[~2012-12-19 10:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 10:27 [PATCH 0/3] at91: PMECC: enable PMECC in dt for at91sam9x5ek, at91sam9n12ek Josh Wu
2012-12-19 10:27 ` Josh Wu [this message]
2013-01-15 12:26 ` [PATCH 1/3] MTD: at91: atmel_nand: for PMECC, add code to choose the ecc bits and sector size according to the ONFI parameter ECC requirement Artem Bityutskiy
2013-01-16 1:50 ` Bo Shen
2013-01-16 8:28 ` Josh Wu
2013-01-17 11:54 ` Artem Bityutskiy
2012-12-19 10:27 ` [PATCH 2/3] at91: 9x5: add DT parameters to enable PMECC Josh Wu
2012-12-19 10:27 ` [PATCH 3/3] at91: at91sam9n12: " Josh Wu
2013-01-14 9:01 ` [PATCH 0/3] at91: PMECC: enable PMECC in dt for at91sam9x5ek, at91sam9n12ek Josh Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355912840-29501-2-git-send-email-josh.wu@atmel.com \
--to=josh.wu@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).