From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 08/11] arm: arch_timer: add arch_counter_set_user_access
Date: Wed, 19 Dec 2012 15:11:07 +0000 [thread overview]
Message-ID: <1355929870-30252-9-git-send-email-mark.rutland@arm.com> (raw)
In-Reply-To: <1355929870-30252-1-git-send-email-mark.rutland@arm.com>
Several bits in CNTKCTL reset to 0, including PL0VTEN. For platforms
using the generic timer which wish to have a fast gettimeofday vDSO
implementation, these bits must be set to 1 by the kernel. On other
platforms, the bootloader might enable userspace access when we don't
want it.
This patch adds arch_counter_set_user_access, which sets the PL0 access
permissions to that required by the platform. For arm, this currently
means disabling all userspace access.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
---
arch/arm/include/asm/arch_timer.h | 11 +++++++++++
arch/arm/kernel/arch_timer.c | 2 ++
2 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/arch/arm/include/asm/arch_timer.h b/arch/arm/include/asm/arch_timer.h
index 701f2b7..05e3593 100644
--- a/arch/arm/include/asm/arch_timer.h
+++ b/arch/arm/include/asm/arch_timer.h
@@ -108,6 +108,17 @@ static inline u64 arch_counter_get_cntvct(void)
return cval;
}
+static inline void __cpuinit arch_counter_set_user_access(void)
+{
+ u32 cntkctl;
+
+ asm volatile("mrc p15, 0, %0, c14, c1, 0" : "=r" (cntkctl));
+
+ /* disable user access to everything */
+ cntkctl &= ~((3 << 8) | (7 << 0));
+
+ asm volatile("mcr p15, 0, %0, c14, c1, 0" : : "r" (cntkctl));
+}
#else
static inline int arch_timer_of_register(void)
diff --git a/arch/arm/kernel/arch_timer.c b/arch/arm/kernel/arch_timer.c
index 834d347..4f39e68 100644
--- a/arch/arm/kernel/arch_timer.c
+++ b/arch/arm/kernel/arch_timer.c
@@ -155,6 +155,8 @@ static int __cpuinit arch_timer_setup(struct clock_event_device *clk)
enable_percpu_irq(arch_timer_ppi[PHYS_NONSECURE_PPI], 0);
}
+ arch_counter_set_user_access();
+
return 0;
}
--
1.7.0.4
next prev parent reply other threads:[~2012-12-19 15:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 15:10 [PATCHv2 00/11] Unify arm_generic and arch_timer drivers Mark Rutland
2012-12-19 15:11 ` [PATCHv2 01/11] arm: arch_timer: balance device_node refcounting Mark Rutland
2012-12-19 15:11 ` [PATCHv2 02/11] arm: arch_timer: remove redundant available check Mark Rutland
2012-12-19 15:11 ` [PATCHv2 03/11] arm: arch_timer: use u64/u32 for register data Mark Rutland
2012-12-19 15:11 ` [PATCHv2 04/11] arm: arch_timer: standardise counter reading Mark Rutland
2012-12-19 15:11 ` [PATCHv2 05/11] arm: arch_timer: split cntfrq accessor Mark Rutland
2012-12-19 15:11 ` [PATCHv2 06/11] arm: arch_timer: factor out register accessors Mark Rutland
2012-12-19 15:11 ` [PATCHv2 07/11] arm: arch_timer: divorce from local_timer api Mark Rutland
2012-12-19 15:11 ` Mark Rutland [this message]
2012-12-19 15:11 ` [PATCHv2 09/11] arm: arch_timer: move core to drivers/clocksource Mark Rutland
2012-12-19 15:11 ` [PATCHv2 10/11] arm64: move from arm_generic to arm_arch_timer Mark Rutland
2012-12-19 15:11 ` [PATCHv2 11/11] Documentation: Add ARMv8 to arch_timer devicetree Mark Rutland
-- strict thread matches above, loose matches on Subject: below --
2013-01-09 16:07 [PATCHv3 00/11] Unify arm_generic and arch_timer drivers Mark Rutland
2013-01-09 16:07 ` [PATCHv2 08/11] arm: arch_timer: add arch_counter_set_user_access Mark Rutland
2013-01-11 13:40 ` Santosh Shilimkar
2013-01-11 14:54 ` Mark Rutland
2013-01-11 15:07 ` Will Deacon
2013-01-11 17:00 ` Santosh Shilimkar
2013-01-11 16:50 ` Catalin Marinas
2013-01-11 16:57 ` Santosh Shilimkar
2013-01-11 17:54 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355929870-30252-9-git-send-email-mark.rutland@arm.com \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).