Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: mbizon@freebox.fr (Maxime Bizon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dma: mv_xor: remove minimal offload length threshold
Date: Thu, 27 Dec 2012 21:15:58 +0100	[thread overview]
Message-ID: <1356639358.28655.7.camel@sakura.staff.proxad.net> (raw)
In-Reply-To: <1356636037-22948-1-git-send-email-lkundrak@v3.sk>

On Thu, 2012-12-27 at 20:20 +0100, Lubomir Rintel wrote:
> 
> of memory condition and retries indefinitelly, causing a soft lockup.
> The threshold does not seem to be enforced by hardware (couldn't find
> anything like that in a datasheet)

page 212

Table 63: Descriptor Byte Count Word

3:0 ByteCount

XOR mode: Size of source and destination blocks in bytes.
CRC mode: Size of source block part represented by the descriptor.
DMA mode: Size of source and destination block in bytes.
Minimum blocks' size: 16B.
Maximum blocks' size: 16MB-1

> and things seems to work fine without it. If there's a 

my guess is that it transfers 16B so it seems to work but actually
corrupts data.

maybe we should teach net_dma_find_channel() about that limitation 

-- 
Maxime

  parent reply	other threads:[~2012-12-27 20:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-27 19:20 [PATCH] dma: mv_xor: remove minimal offload length threshold Lubomir Rintel
2012-12-27 19:56 ` Lubomir Rintel
2012-12-27 20:15 ` Maxime Bizon [this message]
2013-01-26 17:30   ` Mario Schuknecht
2012-12-27 21:24 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1356639358.28655.7.camel@sakura.staff.proxad.net \
    --to=mbizon@freebox.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox