linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ahemaily@gmail.com (ahemaily at gmail.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] arm :omap :DMA: fix a bug on reserving the omap SDMA channels
Date: Sat, 29 Dec 2012 22:43:20 +0200	[thread overview]
Message-ID: <1356813800-4705-1-git-send-email-ahemaily@gmail.com> (raw)

From: ahemaily <ahemaily@gmail.com>

The variable  dma_lch_count  used for comparison  (omap_dma_reserve_channels <= dma_lch_count)
before it initialized to the value from omap_dma_dev_attr : d->lch_count.

I change the place of dma_lch_count initialization to be before the comparison.

Signed-off-by: Abdelrahman Hemaily <ahemaily@gmail.com>
---
 arch/arm/plat-omap/dma.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
index c76ed8b..cb3e321 100644
--- a/arch/arm/plat-omap/dma.c
+++ b/arch/arm/plat-omap/dma.c
@@ -2014,12 +2014,12 @@ static int __devinit omap_system_dma_probe(struct platform_device *pdev)
 
 	d			= p->dma_attr;
 	errata			= p->errata;
-
+	dma_lch_count           = d->lch_count;
+
 	if ((d->dev_caps & RESERVE_CHANNEL) && omap_dma_reserve_channels
 			&& (omap_dma_reserve_channels <= dma_lch_count))
 		d->lch_count	= omap_dma_reserve_channels;
 
-	dma_lch_count		= d->lch_count;
 	dma_chan_count		= dma_lch_count;
 	dma_chan		= d->chan;
 	enable_1510_mode	= d->dev_caps & ENABLE_1510_MODE;
-- 
1.7.9.5

             reply	other threads:[~2012-12-29 20:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-29 20:43 ahemaily at gmail.com [this message]
2012-12-30  6:24 ` [PATCH 1/1] arm :omap :DMA: fix a bug on reserving the omap SDMA channels Santosh Shilimkar
2012-12-30 13:09   ` Abdulrahman Hemaily
2013-01-03  7:28 ` R Sricharan
2013-01-03  8:38   ` Santosh Shilimkar
2013-01-03  9:10     ` Igor Grinberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1356813800-4705-1-git-send-email-ahemaily@gmail.com \
    --to=ahemaily@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).