From: kpark3469@gmail.com (kpark3469 at gmail.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm: fix returning wrong CALLER_ADDRx
Date: Thu, 3 Jan 2013 19:12:28 +0900 [thread overview]
Message-ID: <1357207949-3349-1-git-send-email-kpark3469@gmail.com> (raw)
From: sahara <keun-o.park@windriver.com>
This makes return_address return correct value for ftrace feature.
unwind_frame does not update frame->lr but frame->pc for backtrace.
And, the initialization for data.addr was missing so that wrong value
returned when unwind_frame failed.
Signed-off-by: sahara <keun-o.park@windriver.com>
---
arch/arm/kernel/return_address.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm/kernel/return_address.c b/arch/arm/kernel/return_address.c
index 8085417..fafedd8 100644
--- a/arch/arm/kernel/return_address.c
+++ b/arch/arm/kernel/return_address.c
@@ -26,7 +26,7 @@ static int save_return_addr(struct stackframe *frame, void *d)
struct return_address_data *data = d;
if (!data->level) {
- data->addr = (void *)frame->lr;
+ data->addr = (void *)frame->pc;
return 1;
} else {
@@ -41,7 +41,8 @@ void *return_address(unsigned int level)
struct stackframe frame;
register unsigned long current_sp asm ("sp");
- data.level = level + 1;
+ data.level = level + 2;
+ data.addr = NULL;
frame.fp = (unsigned long)__builtin_frame_address(0);
frame.sp = current_sp;
--
1.7.1
next reply other threads:[~2013-01-03 10:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-03 10:12 kpark3469 at gmail.com [this message]
2013-01-03 10:12 ` [PATCH 2/2] arm: make return_address available for ARM_UNWIND kpark3469 at gmail.com
2013-01-03 10:38 ` Russell King - ARM Linux
2013-01-03 11:36 ` Keun-O Park
2013-01-03 13:36 ` Steven Rostedt
2013-01-03 14:13 ` Russell King - ARM Linux
2013-01-03 16:03 ` Steven Rostedt
2013-01-03 16:23 ` Russell King - ARM Linux
2013-01-03 16:58 ` Steven Rostedt
2013-01-04 8:45 ` Keun-O Park
2013-01-07 13:41 ` Steven Rostedt
2013-01-11 8:53 ` Keun-O Park
2013-01-11 22:04 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357207949-3349-1-git-send-email-kpark3469@gmail.com \
--to=kpark3469@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).