From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [v3 PATCH 05/12] spi/atmel_spi: update the dt support
Date: Sun, 06 Jan 2013 18:06:02 -0800 [thread overview]
Message-ID: <1357524362.4940.16.camel@joe-AO722> (raw)
In-Reply-To: <1357523413-27209-6-git-send-email-wenyou.yang@atmel.com>
On Mon, 2013-01-07 at 09:50 +0800, Wenyou Yang wrote:
> To meet the different spi IP version of atmel SoC,
> add more compatible "atmel,at91rm9200-spi", "atmel,at91sam9260-spi"
> "atmel,at91sam9g45-spi", "atmel,at91sam9x5-spi" with different
> config and devtype.
trivial comment:
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
[]
> @@ -230,11 +302,15 @@ struct atmel_spi_device {
> * register, but I haven't checked that it exists on all chips, and
> * this is cheaper anyway.
> */
> -static bool atmel_spi_is_v2(void)
> +static bool atmel_spi_is_v2(struct atmel_spi *as)
There's a comment that needs updating above this now
> {
> - return !cpu_is_at91rm9200();
> + if (as->pdata->version == 2)
> + return true;
> + else
> + return false;
return as->pdata->version == 2;
is rather more readable to me
next prev parent reply other threads:[~2013-01-07 2:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 1:50 [v3 PATCH 00/12] atmel spi controller with dmaengine and device tree support Wenyou Yang
2013-01-07 1:50 ` [v3 PATCH 01/12] spi/atmel_spi: add physical base address Wenyou Yang
2013-01-07 1:50 ` [v3 PATCH 02/12] spi/atmel_spi: call unmapping on transfers buffers Wenyou Yang
2013-01-07 1:50 ` [v3 PATCH 03/12] spi/atmel_spi: status information passed through controller data Wenyou Yang
2013-01-07 1:50 ` [v3 PATCH 04/12] spi/atmel_spi: add flag to controller data for lock operations Wenyou Yang
2013-01-07 1:50 ` [v3 PATCH 05/12] spi/atmel_spi: update the dt support Wenyou Yang
2013-01-07 2:06 ` Joe Perches [this message]
2013-01-08 1:02 ` Yang, Wenyou
2013-01-07 1:50 ` [v3 PATCH 06/12] spi/atmel_spi: add dmaengine support Wenyou Yang
2013-01-07 2:10 ` Joe Perches
2013-01-08 1:02 ` Yang, Wenyou
2013-01-07 1:50 ` [v3 PATCH 07/12] spi/atmel_spi: fix spi-atmel driver to adapt to slave_config changes Wenyou Yang
2013-01-07 1:50 ` [v3 PATCH 08/12] spi/atmel_spi: correct 16 bits transfers using PIO Wenyou Yang
2013-01-07 1:50 ` [v3 PATCH 09/12] spi/atmel_spi: correct 16 bits transfer with DMA Wenyou Yang
2013-01-07 1:50 ` [v3 PATCH 10/12] ARM: at91: add clocks for spi dt entries Wenyou Yang
2013-01-07 1:50 ` [v3 PATCH 11/12] ARM: dts: add spi nodes for atmel SoC Wenyou Yang
2013-01-07 1:50 ` [PATCH 12/12] ARM: dts: add spi nodes for the atmel boards Wenyou Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357524362.4940.16.camel@joe-AO722 \
--to=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).