linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@prisktech.co.nz (Tony Prisk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] serial: vt8500: ioremap'd resource is never freed
Date: Mon, 14 Jan 2013 15:04:17 +1300	[thread overview]
Message-ID: <1358129060-9399-3-git-send-email-linux@prisktech.co.nz> (raw)
In-Reply-To: <1358129060-9399-1-git-send-email-linux@prisktech.co.nz>

Memory mapped via ioremap call is never released. Rather than add an
iounmap call, change allocation function to devm_request_and_ioremap.

Also, change the error on failure for this call to -EBUSY rather than
-ENOMEM.

Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
---
 drivers/tty/serial/vt8500_serial.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/vt8500_serial.c b/drivers/tty/serial/vt8500_serial.c
index 4c4a58d..8865afd 100644
--- a/drivers/tty/serial/vt8500_serial.c
+++ b/drivers/tty/serial/vt8500_serial.c
@@ -615,9 +615,9 @@ static int vt8500_serial_probe(struct platform_device *pdev)
 	snprintf(vt8500_port->name, sizeof(vt8500_port->name),
 		 "VT8500 UART%d", pdev->id);
 
-	vt8500_port->uart.membase = ioremap(mmres->start, resource_size(mmres));
+	vt8500_port->uart.membase = devm_request_and_ioremap(&pdev->dev, mmres);
 	if (!vt8500_port->uart.membase) {
-		ret = -ENOMEM;
+		ret = -EBUSY;
 		goto err;
 	}
 
-- 
1.7.9.5

  parent reply	other threads:[~2013-01-14  2:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-14  2:04 [GIT PULL] Fixes/cleanup for vt8500 serial driver Tony Prisk
2013-01-14  2:04 ` [PATCH 1/4] serial: vt8500: Fix range-checking on vt8500_uart_ports Tony Prisk
2013-01-14  2:04 ` Tony Prisk [this message]
2013-01-14 13:37   ` [PATCH 2/4] serial: vt8500: ioremap'd resource is never freed Sergei Shtylyov
2013-01-14  2:04 ` [PATCH 3/4] serial: vt8500: UART uses gated clock rather than 24Mhz reference Tony Prisk
2013-01-14  9:20   ` Russell King - ARM Linux
2013-01-14  2:04 ` [PATCH 4/4] serial: tty: Cleanup code using devm_ function Tony Prisk
  -- strict thread matches above, loose matches on Subject: below --
2013-01-15  4:58 [GIT PULL v2] Fixes/cleanup for vt8500 serial driver Tony Prisk
2013-01-15  4:58 ` [PATCH 2/4] serial: vt8500: ioremap'd resource is never freed Tony Prisk
2013-01-15  5:05   ` Tony Prisk
2013-01-16 13:29   ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358129060-9399-3-git-send-email-linux@prisktech.co.nz \
    --to=linux@prisktech.co.nz \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).