From: chao.xie@marvell.com (Chao Xie)
To: linux-arm-kernel@lists.infradead.org
Subject: [V3 PATCH 10/25] usb: otg: mv_otg: use PHY driver for otg
Date: Tue, 15 Jan 2013 01:19:03 -0500 [thread overview]
Message-ID: <1358230758-10176-11-git-send-email-chao.xie@marvell.com> (raw)
In-Reply-To: <1358230758-10176-1-git-send-email-chao.xie@marvell.com>
Originaly, otg driver will call the callbacks in platform data
for PHY initialization and shut down.
With PHY driver, it will call the APIs provided by PHY driver
for PHY initialization and shut down. It removes the callbacks
in platform data, and at same time it removes one block in the
way of enabling device tree for otg driver.
Signed-off-by: Chao Xie <chao.xie@marvell.com>
---
drivers/usb/otg/mv_otg.c | 33 ++++++++++++---------------------
drivers/usb/otg/mv_otg.h | 2 +-
2 files changed, 13 insertions(+), 22 deletions(-)
diff --git a/drivers/usb/otg/mv_otg.c b/drivers/usb/otg/mv_otg.c
index da2d60c..cc45ef2 100644
--- a/drivers/usb/otg/mv_otg.c
+++ b/drivers/usb/otg/mv_otg.c
@@ -25,6 +25,7 @@
#include <linux/usb/otg.h>
#include <linux/usb/gadget.h>
#include <linux/usb/hcd.h>
+#include <linux/usb/mv_usb2.h>
#include <linux/platform_data/mv_usb.h>
#include "mv_otg.h"
@@ -261,8 +262,8 @@ static int mv_otg_enable_internal(struct mv_otg *mvotg)
dev_dbg(&mvotg->pdev->dev, "otg enabled\n");
otg_clock_enable(mvotg);
- if (mvotg->pdata->phy_init) {
- retval = mvotg->pdata->phy_init(mvotg->phy_regs);
+ if (mvotg->mvphy->init) {
+ retval = mvotg->mvphy->init(mvotg->mvphy);
if (retval) {
dev_err(&mvotg->pdev->dev,
"init phy error %d\n", retval);
@@ -288,8 +289,8 @@ static void mv_otg_disable_internal(struct mv_otg *mvotg)
{
if (mvotg->active) {
dev_dbg(&mvotg->pdev->dev, "otg disabled\n");
- if (mvotg->pdata->phy_deinit)
- mvotg->pdata->phy_deinit(mvotg->phy_regs);
+ if (mvotg->mvphy->shutdown)
+ mvotg->mvphy->shutdown(mvotg->mvphy);
otg_clock_disable(mvotg);
mvotg->active = 0;
}
@@ -741,23 +742,8 @@ static int mv_otg_probe(struct platform_device *pdev)
for (i = 0; i < OTG_TIMER_NUM; i++)
init_timer(&mvotg->otg_ctrl.timer[i]);
- r = platform_get_resource_byname(mvotg->pdev,
- IORESOURCE_MEM, "phyregs");
- if (r == NULL) {
- dev_err(&pdev->dev, "no phy I/O memory resource defined\n");
- retval = -ENODEV;
- goto err_destroy_workqueue;
- }
-
- mvotg->phy_regs = devm_ioremap(&pdev->dev, r->start, resource_size(r));
- if (mvotg->phy_regs == NULL) {
- dev_err(&pdev->dev, "failed to map phy I/O memory\n");
- retval = -EFAULT;
- goto err_destroy_workqueue;
- }
-
- r = platform_get_resource_byname(mvotg->pdev,
- IORESOURCE_MEM, "capregs");
+ r = platform_get_resource(mvotg->pdev,
+ IORESOURCE_MEM, 0);
if (r == NULL) {
dev_err(&pdev->dev, "no I/O memory resource defined\n");
retval = -ENODEV;
@@ -770,6 +756,11 @@ static int mv_otg_probe(struct platform_device *pdev)
retval = -EFAULT;
goto err_destroy_workqueue;
}
+ mvotg->mvphy = mv_usb2_get_phy();
+ if (mvotg->mvphy == NULL) {
+ retval = -ENODEV;
+ goto err_destroy_workqueue;
+ }
/* we will acces controller register, so enable the udc controller */
retval = mv_otg_enable_internal(mvotg);
diff --git a/drivers/usb/otg/mv_otg.h b/drivers/usb/otg/mv_otg.h
index 8a9e351..7b9629a 100644
--- a/drivers/usb/otg/mv_otg.h
+++ b/drivers/usb/otg/mv_otg.h
@@ -137,10 +137,10 @@ struct mv_otg_regs {
struct mv_otg {
struct usb_phy phy;
+ struct mv_usb2_phy *mvphy;
struct mv_otg_ctrl otg_ctrl;
/* base address */
- void __iomem *phy_regs;
void __iomem *cap_regs;
struct mv_otg_regs __iomem *op_regs;
--
1.7.4.1
next prev parent reply other threads:[~2013-01-15 6:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 6:18 [V3 PATCH 00/25] mv-usb fix and enhancement patches Chao Xie
2013-01-15 6:18 ` [V3 PATCH 01/25] usb: gadget: mv_udc: use udc_start and udc_stop functions Chao Xie
2013-01-15 6:18 ` [V3 PATCH 02/25] usb: gadget: mv_udc: use devm_xxx for probe Chao Xie
2013-01-15 6:18 ` [V3 PATCH 03/25] usb: gadget: mv_udc: fix the warning of mv_udc_remove Chao Xie
2013-01-15 6:18 ` [V3 PATCH 04/25] usb: otg: mv_otg: use devm_xxx for probe Chao Xie
2013-01-15 6:18 ` [V3 PATCH 05/25] usb: host: ehci-mv: remove unused variable Chao Xie
2013-01-15 6:18 ` [V3 PATCH 06/25] usb: gadget: mv_udc: fix the value of tranceiver Chao Xie
2013-01-15 6:19 ` [V3 PATCH 07/25] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller Chao Xie
2013-01-15 6:19 ` [V3 PATCH 08/25] usb: gadget: mv_udc: use PHY driver for udc Chao Xie
2013-01-15 6:19 ` [V3 PATCH 09/25] usb: ehci: ehci-mv: use PHY driver for ehci Chao Xie
2013-01-15 6:19 ` Chao Xie [this message]
2013-01-15 6:19 ` [V3 PATCH 11/25] arm: mmp2: change the defintion of usb devices Chao Xie
2013-01-17 9:12 ` Felipe Balbi
2013-01-17 9:59 ` Haojian Zhuang
2013-01-17 11:00 ` Felipe Balbi
2013-01-15 6:19 ` [V3 PATCH 12/25] arm: pxa910: " Chao Xie
2013-01-15 6:19 ` [V3 PATCH 13/25] arm: brownstone: add usb support for the board Chao Xie
2013-01-15 6:19 ` [V3 PATCH 14/25] arm: ttc_dkb: add usb support Chao Xie
2013-01-15 6:19 ` [V3 PATCH 15/25] arm: mmp: remove the usb phy setting Chao Xie
2013-01-15 6:19 ` [V3 PATCH 16/25] arm: mmp: remove usb devices from pxa168 Chao Xie
2013-01-15 6:19 ` [V3 PATCH 17/25] usb: phy: mv_usb2_phy: add externel chip support Chao Xie
2013-01-15 6:19 ` [V3 PATCH 18/25] usb: gadget: mv_udc: add extern " Chao Xie
2013-01-15 6:19 ` [V3 PATCH 19/25] usb: ehci: ehci-mv: " Chao Xie
2013-01-15 6:19 ` [V3 PATCH 20/25] usb: otg: mv_otg: " Chao Xie
2013-01-15 6:19 ` [V3 PATCH 21/25] arm: mmp: add extern chip support for brownstone Chao Xie
2013-01-15 6:19 ` [V3 PATCH 22/25] arm: mmp: add extern chip support for ttc_dkb Chao Xie
2013-01-15 6:19 ` [V3 PATCH 23/25] usb: gadget: mv_udc: add device tree support Chao Xie
2013-01-15 6:19 ` [V3 PATCH 24/25] usb: otg: mv_otg: " Chao Xie
2013-01-15 6:19 ` [V3 PATCH 25/25] usb: ehci: ehci-mv: " Chao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358230758-10176-11-git-send-email-chao.xie@marvell.com \
--to=chao.xie@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).