From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] clk-divider: fix is_power_of_two()
Date: Tue, 15 Jan 2013 10:31:05 -0800 [thread overview]
Message-ID: <1358274665.2597.11.camel@joe-AO722> (raw)
In-Reply-To: <1358245685-4392-1-git-send-email-james.hogan@imgtec.com>
On Tue, 2013-01-15 at 10:28 +0000, James Hogan wrote:
> The macro is_power_of_two() in clk-divider.c was defined as !(i & ~i)
> which is always true. Correct it to !(i & (i - 1)).
[]
> diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c
[]
> @@ -29,8 +29,8 @@
[]
> -#define div_mask(d) ((1 << (d->width)) - 1)
> -#define is_power_of_two(i) !(i & ~i)
> +#define div_mask(d) ((1 << ((d)->width)) - 1)
> +#define is_power_of_two(i) (!((i) & ((i) - 1)))
Use is_power_of_2 in log2.h instead?
next prev parent reply other threads:[~2013-01-15 18:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 10:28 [PATCH 1/1] clk-divider: fix is_power_of_two() James Hogan
2013-01-15 18:31 ` Joe Perches [this message]
2013-01-16 0:56 ` Mike Turquette
2013-01-16 9:27 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358274665.2597.11.camel@joe-AO722 \
--to=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox