* [PATCH] ARM: omap4: clock data: Add missing clkdm association for dpll_usb
@ 2013-01-25 6:36 Rajendra Nayak
2013-01-25 8:10 ` Paul Walmsley
0 siblings, 1 reply; 4+ messages in thread
From: Rajendra Nayak @ 2013-01-25 6:36 UTC (permalink / raw)
To: linux-arm-kernel
dpll_usb needs the clkdm association so the clkdm can be
turned on before a relock. All other dplls for omap4 belong
to the ALWON (always on) domain.
The association was present as part of the older data file
(clock44xx_data.c) but looks like was accidently dropped with
the common clk convertion.
More details of the patch which fixed this up in the older
data file can be dound here..
http://www.spinics.net/lists/linux-omap/msg63076.html
Signed-off-by: Rajendra Nayak <rnayak@ti.com>
---
arch/arm/mach-omap2/cclock44xx_data.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-omap2/cclock44xx_data.c b/arch/arm/mach-omap2/cclock44xx_data.c
index 5789a5e..fdea8da 100644
--- a/arch/arm/mach-omap2/cclock44xx_data.c
+++ b/arch/arm/mach-omap2/cclock44xx_data.c
@@ -601,6 +601,7 @@ static struct clk_hw_omap dpll_usb_ck_hw = {
},
.dpll_data = &dpll_usb_dd,
.ops = &clkhwops_omap3_dpll,
+ .clkdm_name = "l3_init_clkdm",
};
DEFINE_STRUCT_CLK(dpll_usb_ck, dpll_usb_ck_parents, dpll_ck_ops);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: omap4: clock data: Add missing clkdm association for dpll_usb
2013-01-25 6:36 [PATCH] ARM: omap4: clock data: Add missing clkdm association for dpll_usb Rajendra Nayak
@ 2013-01-25 8:10 ` Paul Walmsley
2013-01-31 11:44 ` Rajendra Nayak
0 siblings, 1 reply; 4+ messages in thread
From: Paul Walmsley @ 2013-01-25 8:10 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, 25 Jan 2013, Rajendra Nayak wrote:
> dpll_usb needs the clkdm association so the clkdm can be
> turned on before a relock. All other dplls for omap4 belong
> to the ALWON (always on) domain.
>
> The association was present as part of the older data file
> (clock44xx_data.c) but looks like was accidently dropped with
> the common clk convertion.
Thanks, queued for v3.8-rc fixes.
- Paul
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: omap4: clock data: Add missing clkdm association for dpll_usb
2013-01-25 8:10 ` Paul Walmsley
@ 2013-01-31 11:44 ` Rajendra Nayak
2013-01-31 16:19 ` Paul Walmsley
0 siblings, 1 reply; 4+ messages in thread
From: Rajendra Nayak @ 2013-01-31 11:44 UTC (permalink / raw)
To: linux-arm-kernel
Hi Paul,
>> dpll_usb needs the clkdm association so the clkdm can be
>> turned on before a relock. All other dplls for omap4 belong
>> to the ALWON (always on) domain.
>>
>> The association was present as part of the older data file
>> (clock44xx_data.c) but looks like was accidently dropped with
>> the common clk convertion.
>
> Thanks, queued for v3.8-rc fixes.
I just realized that apart from adding the missing .clkdm_name, I
also need to populate a .init as part of clk_ops for dpll_usb
so the clockdomain lookup can then happen based on the .clkdm_name.
I have updated the $Subject patch and posted a v2 (http://marc.info
/?l=linux-omap&m=135963212530790&w=2). Would it be possible for you to
pick the v2 instead and drop this one from your fixes branch.
regards,
Rajendra
>
> - Paul
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: omap4: clock data: Add missing clkdm association for dpll_usb
2013-01-31 11:44 ` Rajendra Nayak
@ 2013-01-31 16:19 ` Paul Walmsley
0 siblings, 0 replies; 4+ messages in thread
From: Paul Walmsley @ 2013-01-31 16:19 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 31 Jan 2013, Rajendra Nayak wrote:
> Hi Paul,
>
> > > dpll_usb needs the clkdm association so the clkdm can be
> > > turned on before a relock. All other dplls for omap4 belong
> > > to the ALWON (always on) domain.
> > >
> > > The association was present as part of the older data file
> > > (clock44xx_data.c) but looks like was accidently dropped with
> > > the common clk convertion.
> >
> > Thanks, queued for v3.8-rc fixes.
>
> I just realized that apart from adding the missing .clkdm_name, I
> also need to populate a .init as part of clk_ops for dpll_usb
> so the clockdomain lookup can then happen based on the .clkdm_name.
>
> I have updated the $Subject patch and posted a v2 (http://marc.info
> /?l=linux-omap&m=135963212530790&w=2). Would it be possible for you to
> pick the v2 instead and drop this one from your fixes branch.
No problem.
- Paul
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-31 16:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-25 6:36 [PATCH] ARM: omap4: clock data: Add missing clkdm association for dpll_usb Rajendra Nayak
2013-01-25 8:10 ` Paul Walmsley
2013-01-31 11:44 ` Rajendra Nayak
2013-01-31 16:19 ` Paul Walmsley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).