From: dinguyen@altera.com (Dinh Nguyen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv1 for soc 4/5] arm: Add v7_invalidate_l1 to cache-v7.S
Date: Mon, 28 Jan 2013 11:35:12 -0600 [thread overview]
Message-ID: <1359394512.17735.43.camel@linux-builds1> (raw)
In-Reply-To: <5106B4FD.4030108@wwwdotorg.org>
Hi Stephen,
On Mon, 2013-01-28 at 10:27 -0700, Stephen Warren wrote:
> On 01/28/2013 03:45 AM, Pavel Machek wrote:
> > On Thu 2013-01-24 20:42:08, Stephen Warren wrote:
> >> On 01/24/2013 05:00 PM, dinguyen at altera.com wrote:
> >>> From: Dinh Nguyen <dinguyen@altera.com>
> >>>
> >>> mach-socfpga is another platform that needs to use
> >>> v7_invalidate_l1 to bringup additional cores. There was a comment that
> >>> the ideal place for v7_invalidate_l1 should be in arm/mm/cache-v7.S
> >>
> >>> diff --git a/arch/arm/mach-tegra/headsmp.S b/arch/arm/mach-tegra/headsmp.S
> >>
> >>> -ENTRY(v7_invalidate_l1)
> >>> - mov r0, #0
> >>
> >> Unfortunately, there's a patch in the Tegra tree for 3.9 that moves that
> >> function from headsmp.S to reset-handler.S, so this patch will conflict.
> >> How do you want to handle that?
> >
> > Drop the patch from Tegra tree and merge this one there? Having three
> > copies of code is not nice to start with, no matter where it is...
>
> Well, I guess for other reasons rebasing the Tegra tree is useful for a
> few dependencies, so I'll drop that part of the patch which moves
> v7_invalidate_l1() from one file to another, so there shouldn't be any
> conflicts, and you can feel free to take this series through whatever
> tree you want.
>
> I haven't tested this patch yet though, to see whether the slight
> differences in the code in your patch mentioned in the other sub-thread
> affect Tegra at all. Hopefully I can test this later today.
Shawn Guo mentioned that the instruction to invalidate I-Cache is
unnecessary becauce of this commit: 612539e (ARM: 7296/1: proc-v7.S:
remove HARVARD_CACHE preprocessor guards)
So I'll send v2 without the extra instruction.
Thanks,
Dinh
>
next prev parent reply other threads:[~2013-01-28 17:35 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 1:00 [PATCHv1 for soc 0/5] Enabling socfpga on hardware dinguyen at altera.com
2013-01-25 1:00 ` [PATCHv1 for soc 1/5] arm: socfpga: Add new device tree source for actual socfpga HW dinguyen at altera.com
2013-01-25 14:22 ` Pavel Machek
2013-01-25 16:18 ` Dinh Nguyen
2013-01-28 7:12 ` Olof Johansson
2013-01-25 1:00 ` [PATCHv1 for soc 2/5] arm: socfpga: Add clock entries to socfpga.dtsi dinguyen at altera.com
2013-01-28 7:13 ` Olof Johansson
2013-01-28 11:19 ` Pavel Machek
2013-01-25 1:00 ` [PATCHv1 for soc 3/5] arm: socfpga: Add entries to enable make dtbs socfpga dinguyen at altera.com
2013-01-25 15:13 ` Pavel Machek
2013-01-25 16:21 ` Dinh Nguyen
2013-01-25 1:00 ` [PATCHv1 for soc 4/5] arm: Add v7_invalidate_l1 to cache-v7.S dinguyen at altera.com
2013-01-25 4:15 ` Simon Horman
2013-01-25 4:35 ` Simon Horman
2013-01-25 16:18 ` Dinh Nguyen
2013-01-25 4:42 ` Stephen Warren
2013-01-28 10:45 ` Pavel Machek
2013-01-28 17:27 ` Stephen Warren
2013-01-28 17:35 ` Dinh Nguyen [this message]
2013-01-25 8:13 ` Santosh Shilimkar
2013-01-25 16:20 ` Dinh Nguyen
2013-01-25 17:47 ` Santosh Shilimkar
2013-01-25 15:49 ` Pavel Machek
2013-01-25 16:24 ` Dinh Nguyen
2013-01-25 18:05 ` Pavel Machek
2013-01-28 13:13 ` Shawn Guo
2013-01-25 1:00 ` [PATCHv1 for soc 5/5] arm: socfpga: Add SMP support for actual socfpga harware dinguyen at altera.com
2013-01-25 17:55 ` Pavel Machek
2013-01-25 21:02 ` Dinh Nguyen
2013-01-26 20:59 ` Pavel Machek
2013-01-28 19:31 ` Pavel Machek
2013-01-28 19:36 ` [RFC] socfpga: make function static Pavel Machek
2013-01-29 18:43 ` [PATCHv1 for soc 5/5] arm: socfpga: Add SMP support for actual socfpga harware Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359394512.17735.43.camel@linux-builds1 \
--to=dinguyen@altera.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).