linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv5 05/16] arm: arch_timer: split cntfrq accessor
Date: Thu, 31 Jan 2013 12:15:28 +0000	[thread overview]
Message-ID: <1359634539-9580-6-git-send-email-mark.rutland@arm.com> (raw)
In-Reply-To: <1359634539-9580-1-git-send-email-mark.rutland@arm.com>

The CNTFRQ register is not duplicated for physical and virtual timers,
and accessing it as if it were is confusing.

Instead, use a separate accessor which doesn't take the access type
as a parameter.

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
---
 arch/arm/kernel/arch_timer.c | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/arch/arm/kernel/arch_timer.c b/arch/arm/kernel/arch_timer.c
index eb78f43..f31c9ee 100644
--- a/arch/arm/kernel/arch_timer.c
+++ b/arch/arm/kernel/arch_timer.c
@@ -51,8 +51,7 @@ static bool arch_timer_use_virtual = true;
 #define ARCH_TIMER_CTRL_IT_STAT		(1 << 2)
 
 #define ARCH_TIMER_REG_CTRL		0
-#define ARCH_TIMER_REG_FREQ		1
-#define ARCH_TIMER_REG_TVAL		2
+#define ARCH_TIMER_REG_TVAL		1
 
 #define ARCH_TIMER_PHYS_ACCESS		0
 #define ARCH_TIMER_VIRT_ACCESS		1
@@ -101,9 +100,6 @@ static inline u32 arch_timer_reg_read(const int access, const int reg)
 		case ARCH_TIMER_REG_TVAL:
 			asm volatile("mrc p15, 0, %0, c14, c2, 0" : "=r" (val));
 			break;
-		case ARCH_TIMER_REG_FREQ:
-			asm volatile("mrc p15, 0, %0, c14, c0, 0" : "=r" (val));
-			break;
 		}
 	}
 
@@ -121,6 +117,13 @@ static inline u32 arch_timer_reg_read(const int access, const int reg)
 	return val;
 }
 
+static inline u32 arch_timer_get_cntfrq(void)
+{
+	u32 val;
+	asm volatile("mrc p15, 0, %0, c14, c0, 0" : "=r" (val));
+	return val;
+}
+
 static inline u64 arch_counter_get_cntpct(void)
 {
 	u64 cval;
@@ -253,8 +256,7 @@ static int arch_timer_available(void)
 	u32 freq;
 
 	if (arch_timer_rate == 0) {
-		freq = arch_timer_reg_read(ARCH_TIMER_PHYS_ACCESS,
-					   ARCH_TIMER_REG_FREQ);
+		freq = arch_timer_get_cntfrq();
 
 		/* Check the timer frequency. */
 		if (freq == 0) {
-- 
1.8.1.1

  parent reply	other threads:[~2013-01-31 12:15 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-31 12:15 [PATCHv5 00/16] Unify arm_generic and arch_timer drivers Mark Rutland
2013-01-31 12:15 ` [PATCHv5 01/16] arm: arch_timer: balance device_node refcounting Mark Rutland
2013-01-31 15:33   ` Catalin Marinas
2013-01-31 12:15 ` [PATCHv5 02/16] arm: arch_timer: remove redundant available check Mark Rutland
2013-01-31 12:15 ` [PATCHv5 03/16] arm: arch_timer: use u64/u32 for register data Mark Rutland
2013-01-31 12:15 ` [PATCHv5 04/16] arm: arch_timer: standardise counter reading Mark Rutland
2013-01-31 15:34   ` Catalin Marinas
2013-01-31 12:15 ` Mark Rutland [this message]
2013-01-31 12:15 ` [PATCHv5 06/16] arm: arch_timer: factor out register accessors Mark Rutland
2013-01-31 12:15 ` [PATCHv5 07/16] arm: arch_timer: add isbs to " Mark Rutland
2013-01-31 15:35   ` Catalin Marinas
2013-01-31 12:15 ` [PATCHv5 08/16] arm: arch_timer: divorce from local_timer api Mark Rutland
2013-01-31 12:15 ` [PATCHv5 09/16] arm: arch_timer: add arch_counter_set_user_access Mark Rutland
2013-01-31 15:36   ` Catalin Marinas
2013-01-31 12:15 ` [PATCHv5 10/16] arm: arch_timer: move core to drivers/clocksource Mark Rutland
2013-01-31 12:15 ` [PATCHv5 11/16] arm64: arm_generic: prevent reading stale time Mark Rutland
2013-01-31 15:36   ` Catalin Marinas
2013-01-31 12:15 ` [PATCHv5 12/16] arm64: move from arm_generic to arm_arch_timer Mark Rutland
2013-01-31 12:15 ` [PATCHv5 13/16] Documentation: Add ARMv8 to arch_timer devicetree Mark Rutland
2013-01-31 12:15 ` [PATCHv5 14/16] ARM: arch_timers: switch to physical timers if HYP mode is available Mark Rutland
2013-01-31 15:37   ` Catalin Marinas
2013-01-31 12:15 ` [PATCHv5 15/16] ARM: hyp: initialize CNTVOFF to zero Mark Rutland
2013-02-01 11:13   ` Dave Martin
2013-02-01 11:43     ` Marc Zyngier
2013-02-01 11:46     ` Mark Rutland
2013-02-01 18:07       ` Dave Martin
2013-02-04  9:29         ` Mark Rutland
2013-01-31 12:15 ` [PATCHv5 16/16] clocksource: arch_timer: use virtual counters Mark Rutland
2013-01-31 15:38   ` Catalin Marinas
2013-01-31 17:39 ` [PATCHv5 00/16] Unify arm_generic and arch_timer drivers Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1359634539-9580-6-git-send-email-mark.rutland@arm.com \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).