From: dinguyen@altera.com (Dinh Nguyen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 for soc 1/4] arm: socfpga: Add new device tree source for actual socfpga HW
Date: Fri, 1 Feb 2013 09:23:15 -0600 [thread overview]
Message-ID: <1359732195.8113.0.camel@linux-builds1> (raw)
In-Reply-To: <20130201034642.GC4838@quad.lixom.net>
Hi Olof,
On Thu, 2013-01-31 at 19:46 -0800, Olof Johansson wrote:
> On Thu, Jan 31, 2013 at 11:05:40AM -0600, dinguyen at altera.com wrote:
> > From: Dinh Nguyen <dinguyen@altera.com>
> >
> > Up to this point, support for socfpga has only been on a virtual
> > platform. Now that actual hardware is available, we add the appropriate
> > device tree source files.
> >
> > Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> > Tested-by: Pavel Machek <pavel@denx.de>
> > Reviewed-by: Pavel Machek <pavel@denx.de>
> > Cc: Russell King <linux@arm.linux.org.uk>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Olof Johansson <olof@lixom.net>
>
> Are you planning on sending us a merge request, or do you want us to apply this
> to a branch in arm-soc for you?
If you can apply to arm-soc, that would great. Thanks! Let me address
your comment in a v3.
Dinh
>
> (Note comment below though)
>
> > diff --git a/arch/arm/boot/dts/socfpga_cyclone5.dts b/arch/arm/boot/dts/socfpga_cyclone5.dts
> > index ab7e4a9..7ad3cc6 100644
> > --- a/arch/arm/boot/dts/socfpga_cyclone5.dts
> > +++ b/arch/arm/boot/dts/socfpga_cyclone5.dts
> > @@ -20,7 +20,7 @@
> >
> > / {
> > model = "Altera SOCFPGA Cyclone V";
> > - compatible = "altr,socfpga-cyclone5";
> > + compatible = "altr,socfpga-cyclone5", "altr,socfpga";
> >
> > chosen {
> > bootargs = "console=ttyS0,57600";
>
> [...]
>
> > diff --git a/arch/arm/boot/dts/socfpga_vt.dts b/arch/arm/boot/dts/socfpga_vt.dts
> > new file mode 100644
> > index 0000000..a0c6c65
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/socfpga_vt.dts
> [...]
> > +
> > +/ {
> > + model = "Altera SOCFPGA VT";
> > + compatible = "altr,socfpga-vt", "altr,socfpga";
> > +
> > + chosen {
> > + bootargs = "console=ttyS0,57600";
> > + };
> > +
> [...]
> > diff --git a/arch/arm/mach-socfpga/socfpga.c b/arch/arm/mach-socfpga/socfpga.c
> > index 6732924..198f491 100644
> > --- a/arch/arm/mach-socfpga/socfpga.c
> > +++ b/arch/arm/mach-socfpga/socfpga.c
> > @@ -99,6 +99,7 @@ static void __init socfpga_cyclone5_init(void)
> > static const char *altera_dt_match[] = {
> > "altr,socfpga",
> > "altr,socfpga-cyclone5",
> > + "altr,socfpga-vt",
> > NULL
> > };
>
> Since you have altr,socfpga in the compatible for the new board, you don't need
> to add an explicit check for the more specific one here. Same for cyclone5, you
> should even be able to remove that.
>
>
> -Olof
>
next prev parent reply other threads:[~2013-02-01 15:23 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 17:05 [PATCHv2 for soc 0/4] Enabling socfpga on hardware dinguyen at altera.com
2013-01-31 17:05 ` [PATCHv2 for soc 1/4] arm: socfpga: Add new device tree source for actual socfpga HW dinguyen at altera.com
2013-02-01 3:46 ` Olof Johansson
2013-02-01 15:23 ` Dinh Nguyen [this message]
2013-01-31 17:05 ` [PATCHv2 for soc 2/4] arm: socfpga: Add entries to enable make dtbs socfpga dinguyen at altera.com
2013-01-31 17:05 ` [PATCHv2 for soc 3/4] arm: Add v7_invalidate_l1 to cache-v7.S dinguyen at altera.com
2013-01-31 18:11 ` Stephen Warren
2013-02-01 3:47 ` Olof Johansson
2013-02-01 11:29 ` Santosh Shilimkar
2013-02-01 11:32 ` Russell King - ARM Linux
2013-02-01 11:44 ` Santosh Shilimkar
2013-02-01 12:48 ` Russell King - ARM Linux
2013-02-01 13:04 ` Santosh Shilimkar
2013-02-01 13:20 ` Russell King - ARM Linux
2013-02-01 14:09 ` Santosh Shilimkar
2013-02-01 12:11 ` Lorenzo Pieralisi
2013-02-01 12:24 ` Santosh Shilimkar
2013-02-01 12:54 ` Russell King - ARM Linux
2013-02-01 14:10 ` Lorenzo Pieralisi
2013-02-01 14:19 ` Russell King - ARM Linux
2013-02-01 14:31 ` Russell King - ARM Linux
2013-02-01 14:43 ` Santosh Shilimkar
2013-02-01 14:49 ` Russell King - ARM Linux
2013-02-01 14:53 ` Santosh Shilimkar
2013-02-01 14:34 ` Lorenzo Pieralisi
2013-01-31 17:05 ` [PATCHv2 for soc 4/4] arm: socfpga: Add SMP support for actual socfpga harware dinguyen at altera.com
2013-02-01 3:50 ` Olof Johansson
2013-02-01 10:46 ` Pavel Machek
2013-02-01 15:27 ` Dinh Nguyen
2013-02-01 15:31 ` Russell King - ARM Linux
2013-02-01 16:39 ` Dinh Nguyen
2013-02-02 19:24 ` Pavel Machek
2013-02-02 21:37 ` Dinh Nguyen
2013-02-03 18:36 ` Pavel Machek
2013-02-04 16:12 ` Dinh Nguyen
2013-02-01 10:50 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359732195.8113.0.camel@linux-builds1 \
--to=dinguyen@altera.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).