From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 1/2] get_maintainer: allow keywords to match filenames
Date: Mon, 11 Feb 2013 16:00:26 -0800 [thread overview]
Message-ID: <1360627226.4707.6.camel@joe-AO722> (raw)
In-Reply-To: <1360626016-23332-1-git-send-email-swarren@wwwdotorg.org>
On Mon, 2013-02-11 at 16:40 -0700, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Allow K: entries in MAINTAINERS to match directly against filenames;
> either those extracted from patch +++ or --- lines, or those specified
> on the command-line using the -f option.
[]
> I don't think setting exact_pattern_match_hash would be appropriate here;
> at least for intended Tegra use case, this feature is to ensure that all
> Tegra-related driver changes get Cc'd to the Tegra mailing list. Setting
> exact_pattern_match_hash would prevent git history parsing for e.g. S-o-b
> tags, which still seems like it would be useful. Hence, this flag isn't
> set.
And I don't think that's necessary because for filenames,
you could add the appropriate control to the MAINTAINERS
"K: ^pattern$"
> The value in $hash{$tvi} doesn't seem relevant, so I just assign 0.
0 is good.
It would be relevant if --pattern-depth was set.
> Joe, I'm not sure if you care where this gets merged; could it go through
> arm-soc together with patch 2/2? A quick look at git history of the
> script in linux-next indicates there won't be conflicts doing that.
I don't care how it gets merged.
Andrew Morton typically picks these up but
if you want to get it merged separately,
I don't see a problem.
trivial comment below:
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
[]
> @@ -611,6 +611,10 @@ sub get_maintainers {
> $hash{$tvi} = $value_pd;
> }
> }
> + } elsif ($type eq "K") {
This should probably be 'K' to match the other
'F' use above it.
next prev parent reply other threads:[~2013-02-12 0:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 23:40 [PATCH V3 1/2] get_maintainer: allow keywords to match filenames Stephen Warren
2013-02-11 23:40 ` [PATCH V3 2/2] MAINTAINERS: update Tegra section to capture all Tegra files Stephen Warren
2013-02-12 0:02 ` Joe Perches
2013-02-12 0:00 ` Joe Perches [this message]
2013-02-12 0:08 ` [PATCH V3 1/2] get_maintainer: allow keywords to match filenames Stephen Warren
2013-02-12 0:16 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360627226.4707.6.camel@joe-AO722 \
--to=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).