From: peter.chen@freescale.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 8/9] usb: chipidea: tell platform layer the ci core probe's result
Date: Sun, 17 Feb 2013 17:24:42 +0800 [thread overview]
Message-ID: <1361093083-22940-9-git-send-email-peter.chen@freescale.com> (raw)
In-Reply-To: <1361093083-22940-1-git-send-email-peter.chen@freescale.com>
If the probe fails, the ci13xxx_add_device will not return error,
(bus_probe_device doesn't has return value)
therefore, the platform layer can't know whether core's probe
is successful or not, if platform layer goes on using core's struct
which is initialized at core's probe, the error will occur.
This error is showed when I only compile gadget, the host-only
controller reports "no supported roles", and fails probe, but imx
platform code doesn't know it, and goes on using core's private data.
Signed-off-by: Peter Chen <peter.chen@freescale.com>
---
drivers/usb/chipidea/core.c | 2 ++
include/linux/usb/chipidea.h | 1 +
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index 6cc6069..45fa227 100644
--- a/drivers/usb/chipidea/core.c
+++ b/drivers/usb/chipidea/core.c
@@ -689,6 +689,7 @@ static int ci_hdrc_probe(struct platform_device *pdev)
/* Defer some operations */
queue_delayed_work(ci->wq, &ci->dwork, msecs_to_jiffies(200));
+ ci->platdata->probe_retval = ret;
return ret;
free_irq:
@@ -704,6 +705,7 @@ rm_wq:
flush_workqueue(ci->wq);
destroy_workqueue(ci->wq);
+ ci->platdata->probe_retval = ret;
return ret;
}
diff --git a/include/linux/usb/chipidea.h b/include/linux/usb/chipidea.h
index d543e4a..8f61e97 100644
--- a/include/linux/usb/chipidea.h
+++ b/include/linux/usb/chipidea.h
@@ -23,6 +23,7 @@ struct ci13xxx_platform_data {
#define CI13XXX_CONTROLLER_RESET_EVENT 0
#define CI13XXX_CONTROLLER_STOPPED_EVENT 1
void (*notify_event) (struct ci13xxx *ci, unsigned event);
+ int probe_retval; /* tell platform layer ci core probe's result */
};
/* Default offset of capability registers */
--
1.7.0.4
next prev parent reply other threads:[~2013-02-17 9:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-17 9:24 [PATCH v9 0/9] Add tested id switch and vbus connect detect support for Chipidea Peter Chen
2013-02-17 9:24 ` [PATCH v9 1/9] Revert "USB: chipidea: add vbus detect for udc" Peter Chen
2013-02-17 9:24 ` [PATCH v9 2/9] usb: chipidea: add otg file Peter Chen
2013-02-17 9:24 ` [PATCH v9 3/9] usb: chipidea: add otg id switch and vbus connect/disconnect detect Peter Chen
2013-02-17 9:24 ` [PATCH v9 4/9] usb: chipidea: udc: add pullup/pulldown dp at hw_device_state Peter Chen
2013-02-17 9:24 ` [PATCH v9 5/9] usb: chipidea: udc: retire the flag CI13_PULLUP_ON_VBUS Peter Chen
2013-02-17 9:24 ` [PATCH v9 6/9] usb: chipidea: imx: add internal vbus regulator control Peter Chen
2013-02-17 9:24 ` [PATCH v9 7/9] usb: chipidea: udc: fix the oops when plugs in usb cable after rmmod gadget Peter Chen
2013-02-17 9:24 ` Peter Chen [this message]
2013-02-26 9:42 ` [PATCH v9 8/9] usb: chipidea: tell platform layer the ci core probe's result Felipe Balbi
2013-02-27 2:22 ` Peter Chen
2013-02-27 12:12 ` Felipe Balbi
2013-02-28 3:11 ` Peter Chen
2013-02-28 7:26 ` Felipe Balbi
2013-02-28 8:31 ` Peter Chen
2013-02-28 8:49 ` Felipe Balbi
2013-02-28 9:32 ` Alexander Shishkin
2013-02-28 10:06 ` Peter Chen
2013-02-28 10:45 ` Felipe Balbi
2013-03-01 1:45 ` Peter Chen
2013-03-01 6:29 ` Felipe Balbi
2013-02-28 10:42 ` Felipe Balbi
2013-02-28 11:55 ` Alexander Shishkin
2013-03-01 6:36 ` Felipe Balbi
2013-02-17 9:24 ` [PATCH v9 9/9] usb: chipidea: imx: fix the error that using uninitialized pointer Peter Chen
2013-02-26 9:36 ` [PATCH v9 0/9] Add tested id switch and vbus connect detect support for Chipidea Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361093083-22940-9-git-send-email-peter.chen@freescale.com \
--to=peter.chen@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).