From: khilman@linaro.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] cpustat: use atomic operations to read/update stats
Date: Thu, 21 Feb 2013 21:56:42 -0800 [thread overview]
Message-ID: <1361512604-2720-1-git-send-email-khilman@linaro.org> (raw)
On 64-bit platforms, reads/writes of the various cpustat fields are
atomic due to native 64-bit loads/stores. However, on non 64-bit
platforms, reads/writes of the cpustat fields are not atomic and could
lead to inconsistent statistics.
This problem was originally reported by Frederic Weisbecker as a
64-bit limitation with the nsec granularity cputime accounting for
full dynticks, but then we realized that it's a problem that's been
around for awhile and not specific to the new cputime accounting.
This series fixes this by first converting all access to the cputime
fields to use accessor functions, and then converting the accessor
functions to use the atomic64 functions.
Implemented based on idea proposed by Frederic Weisbecker.
Kevin Hilman (2):
cpustat: use accessor functions for get/set/add
cpustat: convert to atomic operations
arch/s390/appldata/appldata_os.c | 16 +++++++--------
drivers/cpufreq/cpufreq_governor.c | 18 ++++++++---------
drivers/cpufreq/cpufreq_ondemand.c | 2 +-
drivers/macintosh/rack-meter.c | 6 +++---
fs/proc/stat.c | 40 +++++++++++++++++++-------------------
fs/proc/uptime.c | 2 +-
include/linux/kernel_stat.h | 11 ++++++++++-
kernel/sched/core.c | 12 +++++-------
kernel/sched/cputime.c | 29 +++++++++++++--------------
9 files changed, 70 insertions(+), 66 deletions(-)
--
1.8.1.2
next reply other threads:[~2013-02-22 5:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 5:56 Kevin Hilman [this message]
2013-02-22 5:56 ` [PATCH 1/2] cpustat: use accessor functions for get/set/add Kevin Hilman
2013-02-22 6:21 ` Viresh Kumar
2013-02-22 7:17 ` Amit Kucheria
2013-02-22 7:50 ` Viresh Kumar
2013-02-22 12:34 ` Frederic Weisbecker
2013-02-22 15:14 ` Kevin Hilman
2013-02-22 13:38 ` Frederic Weisbecker
2013-02-22 13:58 ` Peter Zijlstra
2013-02-22 14:03 ` Frederic Weisbecker
2013-02-22 5:56 ` [PATCH 2/2] cpustat: convert to atomic operations Kevin Hilman
2013-02-22 8:46 ` [PATCH 0/2] cpustat: use atomic operations to read/update stats Peter Zijlstra
2013-02-22 12:50 ` Frederic Weisbecker
2013-02-22 13:48 ` Peter Zijlstra
2013-02-22 13:54 ` Ingo Molnar
2013-02-22 14:04 ` Peter Zijlstra
2013-02-22 14:16 ` Ingo Molnar
2013-02-22 14:25 ` Peter Zijlstra
2013-02-22 14:05 ` Peter Zijlstra
2013-02-22 14:15 ` Frederic Weisbecker
2013-02-22 14:09 ` Peter Zijlstra
2013-02-22 14:18 ` Ingo Molnar
2013-02-22 14:21 ` Eric Dumazet
2013-02-22 14:23 ` Frederic Weisbecker
2013-02-22 19:01 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361512604-2720-1-git-send-email-khilman@linaro.org \
--to=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).