From: josephl@nvidia.com (Joseph Lo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: tegra: pmc: convert PMC driver to support DT only
Date: Fri, 22 Feb 2013 14:44:48 +0800 [thread overview]
Message-ID: <1361515491-16199-2-git-send-email-josephl@nvidia.com> (raw)
In-Reply-To: <1361515491-16199-1-git-send-email-josephl@nvidia.com>
The Tegra kernel only support boot from DT now. Clean up the PMC driver
to support DT only, that includes:
* remove the ifdef of CONFIG_OF
* replace the static mapping of PMC addr to map from DT
Signed-off-by: Joseph Lo <josephl@nvidia.com>
---
arch/arm/mach-tegra/pmc.c | 56 +++++++++++++++++++++++------------------------
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/arch/arm/mach-tegra/pmc.c b/arch/arm/mach-tegra/pmc.c
index d4fdb5f..2315e25 100644
--- a/arch/arm/mach-tegra/pmc.c
+++ b/arch/arm/mach-tegra/pmc.c
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2012 NVIDIA CORPORATION. All rights reserved.
+ * Copyright (C) 2012,2013 NVIDIA CORPORATION. All rights reserved.
*
* This program is free software; you can redistribute it and/or modify it
* under the terms and conditions of the GNU General Public License,
@@ -16,59 +16,59 @@
*/
#include <linux/kernel.h>
+#include <linux/err.h>
#include <linux/io.h>
#include <linux/of.h>
-
-#include "iomap.h"
+#include <linux/of_address.h>
#define PMC_CTRL 0x0
#define PMC_CTRL_INTR_LOW (1 << 17)
+static void __iomem *tegra_pmc_base;
+static bool tegra_pmc_invert_interrupt;
+
static inline u32 tegra_pmc_readl(u32 reg)
{
- return readl(IO_ADDRESS(TEGRA_PMC_BASE + reg));
+ return readl_relaxed(tegra_pmc_base + reg);
}
static inline void tegra_pmc_writel(u32 val, u32 reg)
{
- writel(val, IO_ADDRESS(TEGRA_PMC_BASE + reg));
+ writel_relaxed(val, (tegra_pmc_base + reg));
}
-#ifdef CONFIG_OF
static const struct of_device_id matches[] __initconst = {
{ .compatible = "nvidia,tegra20-pmc" },
{ }
};
-#endif
+
+static void tegra_pmc_parse_dt(void)
+{
+ struct device_node *np;
+
+ np = of_find_matching_node(NULL, matches);
+ if (np) {
+ tegra_pmc_base = of_iomap(np, 0);
+
+ tegra_pmc_invert_interrupt = of_property_read_bool(np,
+ "nvidia,invert-interrupt");
+ } else {
+ /* Should not be here, the PMC DT node should always exist. */
+ BUG();
+ }
+}
void __init tegra_pmc_init(void)
{
- /*
- * For now, Harmony is the only board that uses the PMC, and it wants
- * the signal inverted. Seaboard would too if it used the PMC.
- * Hopefully by the time other boards want to use the PMC, everything
- * will be device-tree, or they also want it inverted.
- */
- bool invert_interrupt = true;
u32 val;
-#ifdef CONFIG_OF
- if (of_have_populated_dt()) {
- struct device_node *np;
+ if (!of_have_populated_dt())
+ return;
- invert_interrupt = false;
-
- np = of_find_matching_node(NULL, matches);
- if (np) {
- if (of_find_property(np, "nvidia,invert-interrupt",
- NULL))
- invert_interrupt = true;
- }
- }
-#endif
+ tegra_pmc_parse_dt();
val = tegra_pmc_readl(PMC_CTRL);
- if (invert_interrupt)
+ if (tegra_pmc_invert_interrupt)
val |= PMC_CTRL_INTR_LOW;
else
val &= ~PMC_CTRL_INTR_LOW;
--
1.8.1.1
next prev parent reply other threads:[~2013-02-22 6:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 6:44 [PATCH 0/4] ARM: tegra114: bring up secondary CPU for SMP Joseph Lo
2013-02-22 6:44 ` Joseph Lo [this message]
2013-02-22 13:05 ` [PATCH 1/4] ARM: tegra: pmc: convert PMC driver to support DT only Peter De Schrijver
2013-02-23 2:03 ` Joseph Lo
2013-02-23 4:31 ` Stephen Warren
2013-02-25 14:28 ` Peter De Schrijver
2013-02-25 15:43 ` Stephen Warren
2013-02-26 2:27 ` Joseph Lo
2013-02-22 18:32 ` Stephen Warren
2013-02-22 6:44 ` [PATCH 2/4] ARM: tegra: pmc: add power on function for secondary CPUs Joseph Lo
2013-02-22 13:00 ` Peter De Schrijver
2013-02-23 2:38 ` Joseph Lo
2013-02-23 4:32 ` Stephen Warren
2013-02-23 4:59 ` Joseph Lo
2013-02-23 15:38 ` Peter De Schrijver
2013-02-22 18:37 ` Stephen Warren
2013-02-23 7:28 ` Joseph Lo
2013-02-23 9:39 ` Russell King - ARM Linux
2013-02-23 23:59 ` Stephen Warren
2013-02-25 8:39 ` Peter De Schrijver
2013-02-22 6:44 ` [PATCH 3/4] ARM: tegra30: platsmp: replace the CPU power on function in PMC driver Joseph Lo
2013-02-22 6:44 ` [PATCH 4/4] ARM: tegra114: bring up secondary CPU for SMP Joseph Lo
2013-02-22 12:43 ` [PATCH 0/4] " Peter De Schrijver
2013-02-23 1:57 ` Joseph Lo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361515491-16199-2-git-send-email-josephl@nvidia.com \
--to=josephl@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).