linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: josephl@nvidia.com (Joseph Lo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: tegra: pmc: convert PMC driver to support DT only
Date: Sat, 23 Feb 2013 10:03:42 +0800	[thread overview]
Message-ID: <1361585022.1804.11.camel@jlo-ubuntu-64.nvidia.com> (raw)
In-Reply-To: <20130222130516.GW23234@tbergstrom-lnx.Nvidia.com>

On Fri, 2013-02-22 at 21:05 +0800, Peter De Schrijver wrote:
> On Fri, Feb 22, 2013 at 07:44:48AM +0100, Joseph Lo wrote:
> > The Tegra kernel only support boot from DT now. Clean up the PMC driver
> > to support DT only, that includes:
> > 
> > * remove the ifdef of CONFIG_OF
> > * replace the static mapping of PMC addr to map from DT
> > 
> > -#ifdef CONFIG_OF
> >  static const struct of_device_id matches[] __initconst = {
> >  	{ .compatible = "nvidia,tegra20-pmc" },
> >  	{ }
> 
> At least an extra entry for tegra114-pmc is necessary here. tegra114.dtsi only
> has:
> 
> pmc {
> 	compatible = "nvidia,tegra114-pmc", "nvidia,tegra30-pmc";
> 	reg = <0x7000e400 0x400>;
> };
> 
I think it should be something like below, isn't it?

compatible = "nvidia,tegra114-pmc", "nvidia,tegra30-pmc",
		"nvidia,tegra20-pmc";

or should we add tegra114 and tegra30 in the DT match table?

Thanks,
Joseph

  reply	other threads:[~2013-02-23  2:03 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-22  6:44 [PATCH 0/4] ARM: tegra114: bring up secondary CPU for SMP Joseph Lo
2013-02-22  6:44 ` [PATCH 1/4] ARM: tegra: pmc: convert PMC driver to support DT only Joseph Lo
2013-02-22 13:05   ` Peter De Schrijver
2013-02-23  2:03     ` Joseph Lo [this message]
2013-02-23  4:31       ` Stephen Warren
2013-02-25 14:28         ` Peter De Schrijver
2013-02-25 15:43           ` Stephen Warren
2013-02-26  2:27             ` Joseph Lo
2013-02-22 18:32   ` Stephen Warren
2013-02-22  6:44 ` [PATCH 2/4] ARM: tegra: pmc: add power on function for secondary CPUs Joseph Lo
2013-02-22 13:00   ` Peter De Schrijver
2013-02-23  2:38     ` Joseph Lo
2013-02-23  4:32       ` Stephen Warren
2013-02-23  4:59         ` Joseph Lo
2013-02-23 15:38           ` Peter De Schrijver
2013-02-22 18:37   ` Stephen Warren
2013-02-23  7:28     ` Joseph Lo
2013-02-23  9:39       ` Russell King - ARM Linux
2013-02-23 23:59       ` Stephen Warren
2013-02-25  8:39     ` Peter De Schrijver
2013-02-22  6:44 ` [PATCH 3/4] ARM: tegra30: platsmp: replace the CPU power on function in PMC driver Joseph Lo
2013-02-22  6:44 ` [PATCH 4/4] ARM: tegra114: bring up secondary CPU for SMP Joseph Lo
2013-02-22 12:43 ` [PATCH 0/4] " Peter De Schrijver
2013-02-23  1:57   ` Joseph Lo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1361585022.1804.11.camel@jlo-ubuntu-64.nvidia.com \
    --to=josephl@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).