From: josephl@nvidia.com (Joseph Lo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] ARM: tegra: pmc: add power on function for secondary CPUs
Date: Sat, 23 Feb 2013 10:38:55 +0800 [thread overview]
Message-ID: <1361587135.1804.16.camel@jlo-ubuntu-64.nvidia.com> (raw)
In-Reply-To: <20130222130051.GV23234@tbergstrom-lnx.Nvidia.com>
On Fri, 2013-02-22 at 21:00 +0800, Peter De Schrijver wrote:
> On Fri, Feb 22, 2013 at 07:44:49AM +0100, Joseph Lo wrote:
> > Adding the power on function for secondary CPUs in PMC driver, this can
> > help us to remove legacy powergate driver and add generic power domain
> > support later.
> >
> > Signed-off-by: Joseph Lo <josephl@nvidia.com>
> > ---
> > arch/arm/mach-tegra/pmc.c | 105 +++++++++++++++++++++++++++++++++++++++++++++-
> > arch/arm/mach-tegra/pmc.h | 4 ++
> > 2 files changed, 107 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/mach-tegra/pmc.c b/arch/arm/mach-tegra/pmc.c
> > index 2315e25..a2446c2 100644
> > --- a/arch/arm/mach-tegra/pmc.c
> > +++ b/arch/arm/mach-tegra/pmc.c
> > @@ -21,8 +21,26 @@
> > #include <linux/of.h>
> > #include <linux/of_address.h>
> >
> > -#define PMC_CTRL 0x0
> > -#define PMC_CTRL_INTR_LOW (1 << 17)
> > +#define PMC_CTRL 0x0
> > +#define PMC_CTRL_INTR_LOW (1 << 17)
> > +#define PMC_PWRGATE_TOGGLE 0x30
> > +#define PMC_PWRGATE_TOGGLE_START (1 << 8)
> > +#define PMC_REMOVE_CLAMPING 0x34
> > +#define PMC_PWRGATE_STATUS 0x38
> > +
> > +#define TEGRA_POWERGATE_PCIE 3
> > +#define TEGRA_POWERGATE_VDEC 4
> > +#define TEGRA_POWERGATE_CPU1 9
> > +#define TEGRA_POWERGATE_CPU2 10
> > +#define TEGRA_POWERGATE_CPU3 11
> > +
> > +static u8 tegra_cpu_domains[] = {
> > + 0xFF, /* not available for CPU0 */
>
> On Tegra114 we can also powergate CPU0, so this needs to be defined then.
>
No, DON'T DO THAT!!
We don't allow any code to power gate CPU0 manually here or elsewhere.
The function here only for SMP and hotplug bring up for secondary CPU.
Thanks,
Joseph
next prev parent reply other threads:[~2013-02-23 2:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 6:44 [PATCH 0/4] ARM: tegra114: bring up secondary CPU for SMP Joseph Lo
2013-02-22 6:44 ` [PATCH 1/4] ARM: tegra: pmc: convert PMC driver to support DT only Joseph Lo
2013-02-22 13:05 ` Peter De Schrijver
2013-02-23 2:03 ` Joseph Lo
2013-02-23 4:31 ` Stephen Warren
2013-02-25 14:28 ` Peter De Schrijver
2013-02-25 15:43 ` Stephen Warren
2013-02-26 2:27 ` Joseph Lo
2013-02-22 18:32 ` Stephen Warren
2013-02-22 6:44 ` [PATCH 2/4] ARM: tegra: pmc: add power on function for secondary CPUs Joseph Lo
2013-02-22 13:00 ` Peter De Schrijver
2013-02-23 2:38 ` Joseph Lo [this message]
2013-02-23 4:32 ` Stephen Warren
2013-02-23 4:59 ` Joseph Lo
2013-02-23 15:38 ` Peter De Schrijver
2013-02-22 18:37 ` Stephen Warren
2013-02-23 7:28 ` Joseph Lo
2013-02-23 9:39 ` Russell King - ARM Linux
2013-02-23 23:59 ` Stephen Warren
2013-02-25 8:39 ` Peter De Schrijver
2013-02-22 6:44 ` [PATCH 3/4] ARM: tegra30: platsmp: replace the CPU power on function in PMC driver Joseph Lo
2013-02-22 6:44 ` [PATCH 4/4] ARM: tegra114: bring up secondary CPU for SMP Joseph Lo
2013-02-22 12:43 ` [PATCH 0/4] " Peter De Schrijver
2013-02-23 1:57 ` Joseph Lo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361587135.1804.16.camel@jlo-ubuntu-64.nvidia.com \
--to=josephl@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).