* [PATCH 1/2] Drivers: w1: mxc_w1, Add support for DT
@ 2013-02-23 17:35 Markus Pargmann
2013-02-23 17:35 ` [PATCH 2/2] Drivers: w1: mxc_w1, Add driver owner Markus Pargmann
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Markus Pargmann @ 2013-02-23 17:35 UTC (permalink / raw)
To: linux-arm-kernel
Add devicetree support for mxc_w1 driver.
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
Documentation/devicetree/bindings/w1/fsl,mxc-w1.txt | 13 +++++++++++++
drivers/w1/masters/mxc_w1.c | 7 +++++++
2 files changed, 20 insertions(+)
create mode 100644 Documentation/devicetree/bindings/w1/fsl,mxc-w1.txt
diff --git a/Documentation/devicetree/bindings/w1/fsl,mxc-w1.txt b/Documentation/devicetree/bindings/w1/fsl,mxc-w1.txt
new file mode 100644
index 0000000..686ced4
--- /dev/null
+++ b/Documentation/devicetree/bindings/w1/fsl,mxc-w1.txt
@@ -0,0 +1,13 @@
+Freescale driver for Dalla's 1-wire bus master on imx chips
+
+This driver supports imx21,27,31,35.
+
+Required properties:
+- compatible : "fsl,<chip>-w1"
+- reg : Should be the memory range.
+
+Example:
+ w1: w1 at 10009000 {
+ compatible = "fsl,imx27-w1";
+ reg = <0x10009000 0x1000>;
+ };
diff --git a/drivers/w1/masters/mxc_w1.c b/drivers/w1/masters/mxc_w1.c
index 708a25f..827ff7f 100644
--- a/drivers/w1/masters/mxc_w1.c
+++ b/drivers/w1/masters/mxc_w1.c
@@ -186,9 +186,16 @@ static int mxc_w1_remove(struct platform_device *pdev)
return 0;
}
+struct of_device_id mxc_w1_of_ids[] = {
+ { .compatible = "fsl,imx21-w1", },
+ { /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, mxc_w1_of_ids);
+
static struct platform_driver mxc_w1_driver = {
.driver = {
.name = "mxc_w1",
+ .of_match_table = mxc_w1_of_ids,
},
.probe = mxc_w1_probe,
.remove = mxc_w1_remove,
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] Drivers: w1: mxc_w1, Add driver owner 2013-02-23 17:35 [PATCH 1/2] Drivers: w1: mxc_w1, Add support for DT Markus Pargmann @ 2013-02-23 17:35 ` Markus Pargmann 2013-02-23 21:18 ` [PATCH 1/2] Drivers: w1: mxc_w1, Add support for DT Sergei Shtylyov [not found] ` <CALBypN4+ioS=YDrw7YnvtS1AeS+UH=FidYd2zG1_NsBWDh9bgQ@mail.gmail.com> 2 siblings, 0 replies; 4+ messages in thread From: Markus Pargmann @ 2013-02-23 17:35 UTC (permalink / raw) To: linux-arm-kernel Driver owner was missing. Signed-off-by: Markus Pargmann <mpa@pengutronix.de> --- drivers/w1/masters/mxc_w1.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/w1/masters/mxc_w1.c b/drivers/w1/masters/mxc_w1.c index 827ff7f..7589970 100644 --- a/drivers/w1/masters/mxc_w1.c +++ b/drivers/w1/masters/mxc_w1.c @@ -195,6 +195,7 @@ MODULE_DEVICE_TABLE(of, mxc_w1_of_ids); static struct platform_driver mxc_w1_driver = { .driver = { .name = "mxc_w1", + .owner = THIS_MODULE, .of_match_table = mxc_w1_of_ids, }, .probe = mxc_w1_probe, -- 1.8.1.2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 1/2] Drivers: w1: mxc_w1, Add support for DT 2013-02-23 17:35 [PATCH 1/2] Drivers: w1: mxc_w1, Add support for DT Markus Pargmann 2013-02-23 17:35 ` [PATCH 2/2] Drivers: w1: mxc_w1, Add driver owner Markus Pargmann @ 2013-02-23 21:18 ` Sergei Shtylyov [not found] ` <CALBypN4+ioS=YDrw7YnvtS1AeS+UH=FidYd2zG1_NsBWDh9bgQ@mail.gmail.com> 2 siblings, 0 replies; 4+ messages in thread From: Sergei Shtylyov @ 2013-02-23 21:18 UTC (permalink / raw) To: linux-arm-kernel Hello. On 23-02-2013 21:35, Markus Pargmann wrote: > Add devicetree support for mxc_w1 driver. > Signed-off-by: Markus Pargmann <mpa@pengutronix.de> > --- > Documentation/devicetree/bindings/w1/fsl,mxc-w1.txt | 13 +++++++++++++ > drivers/w1/masters/mxc_w1.c | 7 +++++++ > 2 files changed, 20 insertions(+) > create mode 100644 Documentation/devicetree/bindings/w1/fsl,mxc-w1.txt > diff --git a/Documentation/devicetree/bindings/w1/fsl,mxc-w1.txt b/Documentation/devicetree/bindings/w1/fsl,mxc-w1.txt > new file mode 100644 > index 0000000..686ced4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/w1/fsl,mxc-w1.txt > @@ -0,0 +1,13 @@ > +Freescale driver for Dalla's 1-wire bus master on imx chips You meant "Dallas'". WBR, Sergei ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <CALBypN4+ioS=YDrw7YnvtS1AeS+UH=FidYd2zG1_NsBWDh9bgQ@mail.gmail.com>]
* [PATCH 1/2] Drivers: w1: mxc_w1, Add support for DT [not found] ` <CALBypN4+ioS=YDrw7YnvtS1AeS+UH=FidYd2zG1_NsBWDh9bgQ@mail.gmail.com> @ 2013-02-24 12:36 ` Markus Pargmann 0 siblings, 0 replies; 4+ messages in thread From: Markus Pargmann @ 2013-02-24 12:36 UTC (permalink / raw) To: linux-arm-kernel Hi Martin, On Sun, Feb 24, 2013 at 12:37:17PM +0100, Martin Fuzzey wrote: > Hi Markus, > > I've already submitted basically this and it's in linux-next: > http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h= > 28c55dc1acc863cb29832b5be2464ebcdafdc3d5 Ok, but 2/2 is still needed. > > Also: > +Example: > + w1: w1 at 10009000 { > + compatible = "fsl,imx27-w1"; > + reg = <0x10009000 0x1000>; > + }; > ... > +struct of_device_id mxc_w1_of_ids[] = { > + { .compatible = "fsl,imx21-w1", }, > + { /* sentinel */ } > +}; > > Isn't there a mismatch imx27 vs imx21 here? Yes that's a mismatch from a previous version. Thanks Markus > > Regards, > > Martin > > > > On Sat, Feb 23, 2013 at 6:35 PM, Markus Pargmann <mpa@pengutronix.de> wrote: > > Add devicetree support for mxc_w1 driver. > > Signed-off-by: Markus Pargmann <mpa@pengutronix.de> > --- > Documentation/devicetree/bindings/w1/fsl,mxc-w1.txt | 13 +++++++++++++ > drivers/w1/masters/mxc_w1.c | 7 +++++++ > 2 files changed, 20 insertions(+) > create mode 100644 Documentation/devicetree/bindings/w1/fsl,mxc-w1.txt > > diff --git a/Documentation/devicetree/bindings/w1/fsl,mxc-w1.txt b/ > Documentation/devicetree/bindings/w1/fsl,mxc-w1.txt > new file mode 100644 > index 0000000..686ced4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/w1/fsl,mxc-w1.txt > @@ -0,0 +1,13 @@ > +Freescale driver for Dalla's 1-wire bus master on imx chips > + > +This driver supports imx21,27,31,35. > + > +Required properties: > +- compatible : "fsl,<chip>-w1" > +- reg : Should be the memory range. > + > +Example: > + w1: w1 at 10009000 { > + compatible = "fsl,imx27-w1"; > + reg = <0x10009000 0x1000>; > + }; > diff --git a/drivers/w1/masters/mxc_w1.c b/drivers/w1/masters/mxc_w1.c > index 708a25f..827ff7f 100644 > --- a/drivers/w1/masters/mxc_w1.c > +++ b/drivers/w1/masters/mxc_w1.c > @@ -186,9 +186,16 @@ static int mxc_w1_remove(struct platform_device *pdev) > return 0; > } > > +struct of_device_id mxc_w1_of_ids[] = { > + { .compatible = "fsl,imx21-w1", }, > + { /* sentinel */ } > +}; > +MODULE_DEVICE_TABLE(of, mxc_w1_of_ids); > + > static struct platform_driver mxc_w1_driver = { > .driver = { > .name = "mxc_w1", > + .of_match_table = mxc_w1_of_ids, > }, > .probe = mxc_w1_probe, > .remove = mxc_w1_remove, > -- > 1.8.1.2 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-02-24 12:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-23 17:35 [PATCH 1/2] Drivers: w1: mxc_w1, Add support for DT Markus Pargmann
2013-02-23 17:35 ` [PATCH 2/2] Drivers: w1: mxc_w1, Add driver owner Markus Pargmann
2013-02-23 21:18 ` [PATCH 1/2] Drivers: w1: mxc_w1, Add support for DT Sergei Shtylyov
[not found] ` <CALBypN4+ioS=YDrw7YnvtS1AeS+UH=FidYd2zG1_NsBWDh9bgQ@mail.gmail.com>
2013-02-24 12:36 ` Markus Pargmann
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).