From: mkl@pengutronix.de (Marc Kleine-Budde)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/9] USB chipidea: introduce dual role mode pdata flags
Date: Wed, 27 Feb 2013 13:27:12 +0100 [thread overview]
Message-ID: <1361968035-18644-7-git-send-email-mkl@pengutronix.de> (raw)
In-Reply-To: <1361968035-18644-1-git-send-email-mkl@pengutronix.de>
From: Sascha Hauer <s.hauer@pengutronix.de>
Even if a chipidea core is otg capable the board may not. This allows
to explicitly set the core to host/peripheral mode. Without these
flags the driver falls back to the old behaviour.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/usb/chipidea/core.c | 22 ++++++++++++++++------
include/linux/usb/chipidea.h | 2 +-
2 files changed, 17 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index 04d68cb..ec27060 100644
--- a/drivers/usb/chipidea/core.c
+++ b/drivers/usb/chipidea/core.c
@@ -435,6 +435,7 @@ static int ci_hdrc_probe(struct platform_device *pdev)
struct resource *res;
void __iomem *base;
int ret;
+ enum usb_dr_mode dr_mode;
if (!dev->platform_data) {
dev_err(dev, "platform data missing\n");
@@ -487,14 +488,23 @@ static int ci_hdrc_probe(struct platform_device *pdev)
return -ENODEV;
}
+ /* For now we treat dual-role as otg */
+ dr_mode = ci->platdata->dr_mode;
+ if (dr_mode == USB_DR_MODE_UNKNOWN || dr_mode == USB_DR_MODE_DUAL_ROLE)
+ dr_mode = USB_DR_MODE_OTG;
+
/* initialize role(s) before the interrupt is requested */
- ret = ci_hdrc_host_init(ci);
- if (ret)
- dev_info(dev, "doesn't support host\n");
+ if (dr_mode == USB_DR_MODE_OTG || dr_mode == USB_DR_MODE_HOST) {
+ ret = ci_hdrc_host_init(ci);
+ if (ret)
+ dev_info(dev, "doesn't support host\n");
+ }
- ret = ci_hdrc_gadget_init(ci);
- if (ret)
- dev_info(dev, "doesn't support gadget\n");
+ if (dr_mode == USB_DR_MODE_OTG || dr_mode == USB_DR_MODE_PERIPHERAL) {
+ ret = ci_hdrc_gadget_init(ci);
+ if (ret)
+ dev_info(dev, "doesn't support gadget\n");
+ }
if (!ci->roles[CI_ROLE_HOST] && !ci->roles[CI_ROLE_GADGET]) {
dev_err(dev, "no supported roles\n");
diff --git a/include/linux/usb/chipidea.h b/include/linux/usb/chipidea.h
index 1a2aa18..b314647 100644
--- a/include/linux/usb/chipidea.h
+++ b/include/linux/usb/chipidea.h
@@ -20,7 +20,7 @@ struct ci13xxx_platform_data {
#define CI13XXX_REQUIRE_TRANSCEIVER BIT(1)
#define CI13XXX_PULLUP_ON_VBUS BIT(2)
#define CI13XXX_DISABLE_STREAMING BIT(3)
-
+ enum usb_dr_mode dr_mode;
#define CI13XXX_CONTROLLER_RESET_EVENT 0
#define CI13XXX_CONTROLLER_STOPPED_EVENT 1
void (*notify_event) (struct ci13xxx *ci, unsigned event);
--
1.7.10.4
next prev parent reply other threads:[~2013-02-27 12:27 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 12:27 [PATCH v5 0/9] USB: add devicetree helpers for determining dr_mode and phy_type Marc Kleine-Budde
2013-02-27 12:27 ` [PATCH 1/9] USB otg: use try_module_get in all usb_get_phy functions and add missing module_put Marc Kleine-Budde
2013-02-27 12:31 ` Felipe Balbi
2013-02-27 12:40 ` Marc Kleine-Budde
2013-02-27 12:43 ` Felipe Balbi
2013-02-27 12:46 ` Marc Kleine-Budde
2013-02-27 12:47 ` Felipe Balbi
2013-02-27 12:55 ` Marc Kleine-Budde
2013-02-27 13:42 ` Felipe Balbi
2013-02-27 13:55 ` Marc Kleine-Budde
2013-02-27 14:21 ` Marc Kleine-Budde
2013-02-27 12:27 ` [PATCH 2/9] USB: move bulk of otg/otg.c to phy/phy.c Marc Kleine-Budde
2013-02-27 12:29 ` Marc Kleine-Budde
2013-02-27 12:31 ` Felipe Balbi
2013-02-27 12:27 ` [PATCH 3/9] USB: add devicetree helpers for determining dr_mode and phy_type Marc Kleine-Budde
2013-02-27 12:31 ` Marc Kleine-Budde
2013-02-27 12:32 ` Felipe Balbi
2013-02-27 12:32 ` Felipe Balbi
2013-02-27 12:38 ` Marc Kleine-Budde
2013-02-27 12:41 ` Felipe Balbi
2013-02-27 12:27 ` [PATCH 4/9] USB chipidea: ci13xxx-imx: create dynamic platformdata Marc Kleine-Budde
2013-02-27 12:27 ` [PATCH 5/9] USB chipidea: add PTW and PTS handling Marc Kleine-Budde
2013-02-27 12:27 ` Marc Kleine-Budde [this message]
2013-02-27 12:27 ` [PATCH 7/9] USB chipidea i.MX: introduce dr_mode property Marc Kleine-Budde
2013-02-27 12:27 ` [PATCH 8/9] USB mxs-phy: Register phy with framework Marc Kleine-Budde
2013-02-27 12:27 ` [PATCH 9/9] USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy Marc Kleine-Budde
-- strict thread matches above, loose matches on Subject: below --
2013-02-04 13:24 [PATCH v4] USB: add devicetree helpers for determining dr_mode and phy_type Sascha Hauer
2013-02-04 13:24 ` [PATCH 6/9] USB chipidea: introduce dual role mode pdata flags Sascha Hauer
2013-02-22 2:09 ` Peter Chen
2013-02-27 10:42 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361968035-18644-7-git-send-email-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).