* [PATCH] mfd: Fix AB8500 build failure if POWER_SUPPLY is not configured
@ 2013-02-28 19:37 Guenter Roeck
2013-03-04 7:36 ` Linus Walleij
2013-03-13 8:35 ` Samuel Ortiz
0 siblings, 2 replies; 3+ messages in thread
From: Guenter Roeck @ 2013-02-28 19:37 UTC (permalink / raw)
To: linux-arm-kernel
ab8500-sysctrl.c fails to build if POWER_SUPPLY is not configured.
drivers/built-in.o: In function `ab8500_power_off':
drivers/mfd/ab8500-sysctrl.c:37: undefined reference to `power_supply_get_by_name'
drivers/mfd/ab8500-sysctrl.c:53: undefined reference to `power_supply_get_by_name'
Select POWER_SUPPLY in Kconfig if AB8500_CORE is configured to fix the problem.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/mfd/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 671f5b1..d5511de 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -860,6 +860,7 @@ config AB8500_CORE
depends on GENERIC_HARDIRQS && ABX500_CORE && MFD_DB8500_PRCMU
select MFD_CORE
select IRQ_DOMAIN
+ select POWER_SUPPLY
help
Select this option to enable access to AB8500 power management
chip. This connects to U8500 either on the SSP/SPI bus (deprecated
--
1.7.9.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] mfd: Fix AB8500 build failure if POWER_SUPPLY is not configured
2013-02-28 19:37 [PATCH] mfd: Fix AB8500 build failure if POWER_SUPPLY is not configured Guenter Roeck
@ 2013-03-04 7:36 ` Linus Walleij
2013-03-13 8:35 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2013-03-04 7:36 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Feb 28, 2013 at 8:37 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> ab8500-sysctrl.c fails to build if POWER_SUPPLY is not configured.
>
> drivers/built-in.o: In function `ab8500_power_off':
> drivers/mfd/ab8500-sysctrl.c:37: undefined reference to `power_supply_get_by_name'
> drivers/mfd/ab8500-sysctrl.c:53: undefined reference to `power_supply_get_by_name'
>
> Select POWER_SUPPLY in Kconfig if AB8500_CORE is configured to fix the problem.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
It appears an identical patch was already submitted in feb 19:
https://patchwork.kernel.org/patch/2163301/
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] mfd: Fix AB8500 build failure if POWER_SUPPLY is not configured
2013-02-28 19:37 [PATCH] mfd: Fix AB8500 build failure if POWER_SUPPLY is not configured Guenter Roeck
2013-03-04 7:36 ` Linus Walleij
@ 2013-03-13 8:35 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Ortiz @ 2013-03-13 8:35 UTC (permalink / raw)
To: linux-arm-kernel
Hi Guenter,
On Thu, Feb 28, 2013 at 11:37:09AM -0800, Guenter Roeck wrote:
> ab8500-sysctrl.c fails to build if POWER_SUPPLY is not configured.
>
> drivers/built-in.o: In function `ab8500_power_off':
> drivers/mfd/ab8500-sysctrl.c:37: undefined reference to `power_supply_get_by_name'
> drivers/mfd/ab8500-sysctrl.c:53: undefined reference to `power_supply_get_by_name'
>
> Select POWER_SUPPLY in Kconfig if AB8500_CORE is configured to fix the problem.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/mfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
I applied Axel's patch to my mfd-fixes tree now.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-13 8:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-28 19:37 [PATCH] mfd: Fix AB8500 build failure if POWER_SUPPLY is not configured Guenter Roeck
2013-03-04 7:36 ` Linus Walleij
2013-03-13 8:35 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).