From: josephl@nvidia.com (Joseph Lo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/10] ARM: tegra: get power management configurations for PMC from DT
Date: Thu, 7 Mar 2013 18:46:21 +0800 [thread overview]
Message-ID: <1362653181.1890.3.camel@jlo-ubuntu-64.nvidia.com> (raw)
In-Reply-To: <51363A95.8090000@wwwdotorg.org>
On Wed, 2013-03-06 at 02:33 +0800, Stephen Warren wrote:
> On 03/04/2013 04:40 AM, Joseph Lo wrote:
> > If the system supports deep sleep mode (i.e. suspend), it should have
> > the power management configuration for PMC in the DT under the sub-node
> > of PMC. Different system may have different configurations, it should
> > be parsed from DT.
>
> > diff --git a/arch/arm/mach-tegra/pmc.c b/arch/arm/mach-tegra/pmc.c
>
> > @@ -143,6 +161,10 @@ static const struct of_device_id matches[] __initconst = {
> > static void tegra_pmc_parse_dt(void)
> > {
> > struct device_node *np;
> > + u32 prop;
> > + enum tegra_suspend_mode suspend_mode;
> > + u32 core_good_time[2] = {0, 0};
> > + u32 lp0_vec[2] = {0, 0};
> >
> > np = of_find_matching_node(NULL, matches);
> > BUG_ON(!np);
>
> This files doesn't look like that; the BUG_ON() isn't present upstream.
> yet. So, this series depends on some other patches not yet applied. You
> need to explicitly document your patch dependencies somewhere. Hopefully
> I can work it out...
>
Sorry for that.
> The DT binding documentation patch (5/10) should be squashed into this
> patch; both document and implement the bindings in the same patch.
IIRC, you asked me to separate the binding documentation and
implementation into two different patch in internal review. Should I
squash these two now? (I can do that, just want to confirm.)
Thanks,
Joseph
next prev parent reply other threads:[~2013-03-07 10:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 11:40 [PATCH 03/10] ARM: tegra: get power management configurations for PMC from DT Joseph Lo
2013-03-05 18:33 ` Stephen Warren
2013-03-07 10:46 ` Joseph Lo [this message]
2013-03-07 20:43 ` Stephen Warren
2013-03-05 18:41 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362653181.1890.3.camel@jlo-ubuntu-64.nvidia.com \
--to=josephl@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).