public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 06/18] arm: pci: add a align_resource hook
Date: Fri,  8 Mar 2013 16:19:08 +0100	[thread overview]
Message-ID: <1362755960-30791-7-git-send-email-thomas.petazzoni@free-electrons.com> (raw)
In-Reply-To: <1362755960-30791-1-git-send-email-thomas.petazzoni@free-electrons.com>

The PCI specifications says that an I/O region must be aligned on a 4
KB boundary, and a memory region aligned on a 1 MB boundary.

However, the Marvell PCIe interfaces rely on address decoding windows
(which allow to associate a range of physical addresses with a given
device). For PCIe memory windows, those windows are defined with a 1
MB granularity (which matches the PCI specs), but PCIe I/O windows can
only be defined with a 64 KB granularity, so they have to be 64 KB
aligned. We therefore need to tell the PCI core about this special
alignement requirement.

The PCI core already calls pcibios_align_resource() in the ARM PCI
core, specifically for such purposes. So this patch extends the ARM
PCI core so that it calls a ->align_resource() hook registered by the
PCI driver, exactly like the existing ->map_irq() and ->swizzle()
hooks.

A particular PCI driver can register a align_resource() hook, and do
its own specific alignement, depending on the specific constraints of
the underlying hardware.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Russell King <linux@arm.linux.org.uk>
---
 arch/arm/include/asm/mach/pci.h |   11 +++++++++++
 arch/arm/kernel/bios32.c        |    6 ++++++
 2 files changed, 17 insertions(+)

diff --git a/arch/arm/include/asm/mach/pci.h b/arch/arm/include/asm/mach/pci.h
index 5cf2e97..7d2c3c8 100644
--- a/arch/arm/include/asm/mach/pci.h
+++ b/arch/arm/include/asm/mach/pci.h
@@ -30,6 +30,11 @@ struct hw_pci {
 	void		(*postinit)(void);
 	u8		(*swizzle)(struct pci_dev *dev, u8 *pin);
 	int		(*map_irq)(const struct pci_dev *dev, u8 slot, u8 pin);
+	resource_size_t (*align_resource)(struct pci_dev *dev,
+					  const struct resource *res,
+					  resource_size_t start,
+					  resource_size_t size,
+					  resource_size_t align);
 };
 
 /*
@@ -51,6 +56,12 @@ struct pci_sys_data {
 	u8		(*swizzle)(struct pci_dev *, u8 *);
 					/* IRQ mapping				*/
 	int		(*map_irq)(const struct pci_dev *, u8, u8);
+					/* Resource alignement requirements	*/
+	resource_size_t (*align_resource)(struct pci_dev *dev,
+					  const struct resource *res,
+					  resource_size_t start,
+					  resource_size_t size,
+					  resource_size_t align);
 	void		*private_data;	/* platform controller private data	*/
 };
 
diff --git a/arch/arm/kernel/bios32.c b/arch/arm/kernel/bios32.c
index a1f73b5..b2ed73c 100644
--- a/arch/arm/kernel/bios32.c
+++ b/arch/arm/kernel/bios32.c
@@ -462,6 +462,7 @@ static void pcibios_init_hw(struct hw_pci *hw, struct list_head *head)
 		sys->busnr   = busnr;
 		sys->swizzle = hw->swizzle;
 		sys->map_irq = hw->map_irq;
+		sys->align_resource = hw->align_resource;
 		INIT_LIST_HEAD(&sys->resources);
 
 		if (hw->private_data)
@@ -574,6 +575,8 @@ char * __init pcibios_setup(char *str)
 resource_size_t pcibios_align_resource(void *data, const struct resource *res,
 				resource_size_t size, resource_size_t align)
 {
+	struct pci_dev *dev = data;
+	struct pci_sys_data *sys = dev->sysdata;
 	resource_size_t start = res->start;
 
 	if (res->flags & IORESOURCE_IO && start & 0x300)
@@ -581,6 +584,9 @@ resource_size_t pcibios_align_resource(void *data, const struct resource *res,
 
 	start = (start + align - 1) & ~(align - 1);
 
+	if (sys->align_resource)
+		return sys->align_resource(dev, res, start, size, align);
+
 	return start;
 }
 
-- 
1.7.9.5

  parent reply	other threads:[~2013-03-08 15:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-08 15:19 [PATCH v4 00/18] PCIe support for the Armada 370 and Armada XP SoCs Thomas Petazzoni
2013-03-08 15:19 ` [PATCH v4 01/18] of/pci: Provide support for parsing PCI DT ranges property Thomas Petazzoni
2013-03-08 15:19 ` [PATCH v4 02/18] of/pci: Add of_pci_get_devfn() function Thomas Petazzoni
2013-03-08 15:19 ` [PATCH v4 03/18] of/pci: Add of_pci_get_bus() function Thomas Petazzoni
2013-03-08 15:19 ` [PATCH v4 04/18] of/pci: Add of_pci_parse_bus_range() function Thomas Petazzoni
2013-03-08 15:19 ` [PATCH v4 05/18] pci: infrastructure to add drivers in drivers/pci/host Thomas Petazzoni
2013-03-08 15:19 ` Thomas Petazzoni [this message]
2013-03-20 20:02   ` [PATCH v4 06/18] arm: pci: add a align_resource hook Thomas Petazzoni
2013-03-08 15:19 ` [PATCH v4 07/18] clk: mvebu: create parent-child relation for PCIe clocks on Armada 370 Thomas Petazzoni
2013-03-08 15:19 ` [PATCH v4 08/18] clk: mvebu: add more PCIe clocks for Armada XP Thomas Petazzoni
2013-03-08 15:19 ` [PATCH v4 09/18] pci: PCIe driver for Marvell Armada 370/XP systems Thomas Petazzoni
2013-03-08 15:19 ` [PATCH v4 10/18] arm: mvebu: PCIe support is now available on mvebu Thomas Petazzoni
2013-03-08 15:19 ` [PATCH v4 11/18] arm: mvebu: add PCIe Device Tree informations for Armada 370 Thomas Petazzoni
2013-03-08 15:19 ` [PATCH v4 12/18] arm: mvebu: add PCIe Device Tree informations for Armada XP Thomas Petazzoni
2013-03-08 15:19 ` [PATCH v4 13/18] arm: mvebu: PCIe Device Tree informations for OpenBlocks AX3-4 Thomas Petazzoni
2013-03-08 15:19 ` [PATCH v4 14/18] arm: mvebu: PCIe Device Tree informations for Armada XP DB Thomas Petazzoni
2013-03-08 15:19 ` [PATCH v4 15/18] arm: mvebu: PCIe Device Tree informations for Armada 370 Mirabox Thomas Petazzoni
2013-03-08 15:19 ` [PATCH v4 16/18] arm: mvebu: PCIe Device Tree informations for Armada 370 DB Thomas Petazzoni
2013-03-08 15:19 ` [PATCH v4 17/18] arm: mvebu: PCIe Device Tree informations for Armada XP GP Thomas Petazzoni
2013-03-08 15:19 ` [PATCH v4 18/18] arm: mvebu: update defconfig with PCI and USB support Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1362755960-30791-7-git-send-email-thomas.petazzoni@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox