From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/2] ARM: uncompress debug support for multiplatform build
Date: Mon, 11 Mar 2013 19:35:37 +0800 [thread overview]
Message-ID: <1363001737-8745-3-git-send-email-shawn.guo@linaro.org> (raw)
In-Reply-To: <1363001737-8745-1-git-send-email-shawn.guo@linaro.org>
Instead of giving zero support of uncompress debug for multiplatform
build, the patch turns uncompress debug into one part of DEBUG_LL
support. When DEBUG_LL is turned on for a particular platform,
uncompress debug works too for that platform.
OMAP is an exception here. OMAP low-level debug code places data
in the .data section, and that is allowed in decompressor. That's
why Kconfig symbol DEBUG_UNCOMPRESS that controls multiplatform
uncompress debug support is defined with !DEBUG_OMAP2PLUS_UART.
It creates arch/arm/boot/compressed/debug.S with CONFIG_DEBUG_LL_INCLUDE
included there, implements a generic putc() using those macros, which
will be built when DEBUG_UNCOMPRESS is defined.
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Olof Johansson <olof@lixom.net>
---
arch/arm/Kconfig.debug | 4 ++++
arch/arm/boot/compressed/Makefile | 3 +++
arch/arm/boot/compressed/debug.S | 12 ++++++++++++
arch/arm/include/debug/uncompress.h | 4 ++++
4 files changed, 23 insertions(+)
create mode 100644 arch/arm/boot/compressed/debug.S
diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index fc54a5b..559228c 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -601,6 +601,10 @@ config DEBUG_LL_INCLUDE
default "debug/zynq.S" if DEBUG_ZYNQ_UART0 || DEBUG_ZYNQ_UART1
default "mach/debug-macro.S"
+config DEBUG_UNCOMPRESS
+ bool
+ default y if ARCH_MULTIPLATFORM && DEBUG_LL && !DEBUG_OMAP2PLUS_UART
+
config UNCOMPRESS_INCLUDE
string
default "debug/uncompress.h" if ARCH_MULTIPLATFORM
diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile
index 5cad8a6..e3238bc 100644
--- a/arch/arm/boot/compressed/Makefile
+++ b/arch/arm/boot/compressed/Makefile
@@ -24,6 +24,9 @@ endif
AFLAGS_head.o += -DTEXT_OFFSET=$(TEXT_OFFSET)
HEAD = head.o
OBJS += misc.o decompress.o
+ifeq ($(CONFIG_DEBUG_UNCOMPRESS),y)
+OBJS += debug.o
+endif
FONTC = $(srctree)/drivers/video/console/font_acorn_8x8.c
# string library code (-Os is enforced to keep it much smaller)
diff --git a/arch/arm/boot/compressed/debug.S b/arch/arm/boot/compressed/debug.S
new file mode 100644
index 0000000..6e8382d
--- /dev/null
+++ b/arch/arm/boot/compressed/debug.S
@@ -0,0 +1,12 @@
+#include <linux/linkage.h>
+#include <asm/assembler.h>
+
+#include CONFIG_DEBUG_LL_INCLUDE
+
+ENTRY(putc)
+ addruart r1, r2, r3
+ waituart r3, r1
+ senduart r0, r1
+ busyuart r3, r1
+ mov pc, lr
+ENDPROC(putc)
diff --git a/arch/arm/include/debug/uncompress.h b/arch/arm/include/debug/uncompress.h
index e19955d..0e2949b 100644
--- a/arch/arm/include/debug/uncompress.h
+++ b/arch/arm/include/debug/uncompress.h
@@ -1,3 +1,7 @@
+#ifdef CONFIG_DEBUG_UNCOMPRESS
+extern void putc(int c);
+#else
static inline void putc(int c) {}
+#endif
static inline void flush(void) {}
static inline void arch_decomp_setup(void) {}
--
1.7.9.5
next prev parent reply other threads:[~2013-03-11 11:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 11:35 [PATCH v4 0/2] Uncompress debug for multiplatform Shawn Guo
2013-03-11 11:35 ` [PATCH v4 1/2] ARM: use Kconfig to select uncompress.h Shawn Guo
2013-03-11 11:35 ` Shawn Guo [this message]
2013-03-11 17:36 ` [PATCH v4 2/2] ARM: uncompress debug support for multiplatform build Tony Lindgren
2013-03-13 3:18 ` [PATCH v5 " Shawn Guo
2013-03-13 11:19 ` Arnd Bergmann
2013-03-11 17:03 ` [PATCH v4 0/2] Uncompress debug for multiplatform Russell King - ARM Linux
2013-03-11 17:30 ` Stephen Warren
2013-03-12 4:02 ` Shawn Guo
2013-03-12 18:23 ` Stephen Warren
2013-03-13 2:21 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363001737-8745-3-git-send-email-shawn.guo@linaro.org \
--to=shawn.guo@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).