From: pawel.moll@arm.com (Pawel Moll)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM:vexpress: beautify code, using 'static const' instead of 'const static'
Date: Mon, 11 Mar 2013 13:40:55 +0000 [thread overview]
Message-ID: <1363009255.3165.19.camel@hornet> (raw)
In-Reply-To: <513BF001.30204@asianux.com>
On Sun, 2013-03-10 at 02:29 +0000, Chen Gang wrote:
> better using 'static const' instead of 'const static'
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/arm/mach-vexpress/platsmp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-vexpress/platsmp.c b/arch/arm/mach-vexpress/platsmp.c
> index dc1ace5..9152bf7 100644
> --- a/arch/arm/mach-vexpress/platsmp.c
> +++ b/arch/arm/mach-vexpress/platsmp.c
> @@ -40,7 +40,7 @@ static struct map_desc vexpress_dt_cortex_a9_scu_map __initdata = {
>
> static void *vexpress_dt_cortex_a9_scu_base __initdata;
>
> -const static char *vexpress_dt_cortex_a9_match[] __initconst = {
> +static const char *vexpress_dt_cortex_a9_match[] __initconst = {
> "arm,cortex-a5-scu",
> "arm,cortex-a9-scu",
> NULL
Thanks for spotting this. I will keep this in mind, but I can't promise
to take this patch as it goes, because the platsmp.c is likely to change
(shrink) in near future. Either way I'll make sure you get due
credit :-)
Cheers!
Pawel
prev parent reply other threads:[~2013-03-11 13:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-10 2:29 [PATCH] ARM:vexpress: beautify code, using 'static const' instead of 'const static' Chen Gang
2013-03-10 2:57 ` Viresh Kumar
2013-03-10 3:13 ` Chen Gang
2013-03-11 13:40 ` Pawel Moll [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363009255.3165.19.camel@hornet \
--to=pawel.moll@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).