* [PATCH] ARM:vexpress: beautify code, using 'static const' instead of 'const static'
@ 2013-03-10 2:29 Chen Gang
2013-03-10 2:57 ` Viresh Kumar
2013-03-11 13:40 ` Pawel Moll
0 siblings, 2 replies; 4+ messages in thread
From: Chen Gang @ 2013-03-10 2:29 UTC (permalink / raw)
To: linux-arm-kernel
better using 'static const' instead of 'const static'
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/arm/mach-vexpress/platsmp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-vexpress/platsmp.c b/arch/arm/mach-vexpress/platsmp.c
index dc1ace5..9152bf7 100644
--- a/arch/arm/mach-vexpress/platsmp.c
+++ b/arch/arm/mach-vexpress/platsmp.c
@@ -40,7 +40,7 @@ static struct map_desc vexpress_dt_cortex_a9_scu_map __initdata = {
static void *vexpress_dt_cortex_a9_scu_base __initdata;
-const static char *vexpress_dt_cortex_a9_match[] __initconst = {
+static const char *vexpress_dt_cortex_a9_match[] __initconst = {
"arm,cortex-a5-scu",
"arm,cortex-a9-scu",
NULL
--
1.7.7.6
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM:vexpress: beautify code, using 'static const' instead of 'const static'
2013-03-10 2:29 [PATCH] ARM:vexpress: beautify code, using 'static const' instead of 'const static' Chen Gang
@ 2013-03-10 2:57 ` Viresh Kumar
2013-03-10 3:13 ` Chen Gang
2013-03-11 13:40 ` Pawel Moll
1 sibling, 1 reply; 4+ messages in thread
From: Viresh Kumar @ 2013-03-10 2:57 UTC (permalink / raw)
To: linux-arm-kernel
On 10 March 2013 07:59, Chen Gang <gang.chen@asianux.com> wrote:
>
> better using 'static const' instead of 'const static'
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/arm/mach-vexpress/platsmp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-vexpress/platsmp.c b/arch/arm/mach-vexpress/platsmp.c
> index dc1ace5..9152bf7 100644
> --- a/arch/arm/mach-vexpress/platsmp.c
> +++ b/arch/arm/mach-vexpress/platsmp.c
> @@ -40,7 +40,7 @@ static struct map_desc vexpress_dt_cortex_a9_scu_map __initdata = {
>
> static void *vexpress_dt_cortex_a9_scu_base __initdata;
>
> -const static char *vexpress_dt_cortex_a9_match[] __initconst = {
> +static const char *vexpress_dt_cortex_a9_match[] __initconst = {
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM:vexpress: beautify code, using 'static const' instead of 'const static'
2013-03-10 2:57 ` Viresh Kumar
@ 2013-03-10 3:13 ` Chen Gang
0 siblings, 0 replies; 4+ messages in thread
From: Chen Gang @ 2013-03-10 3:13 UTC (permalink / raw)
To: linux-arm-kernel
? 2013?03?10? 10:57, Viresh Kumar ??:
> On 10 March 2013 07:59, Chen Gang <gang.chen@asianux.com> wrote:
>> >
>> > better using 'static const' instead of 'const static'
>> >
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
>> > ---
>> > arch/arm/mach-vexpress/platsmp.c | 2 +-
>> > 1 files changed, 1 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/arch/arm/mach-vexpress/platsmp.c b/arch/arm/mach-vexpress/platsmp.c
>> > index dc1ace5..9152bf7 100644
>> > --- a/arch/arm/mach-vexpress/platsmp.c
>> > +++ b/arch/arm/mach-vexpress/platsmp.c
>> > @@ -40,7 +40,7 @@ static struct map_desc vexpress_dt_cortex_a9_scu_map __initdata = {
>> >
>> > static void *vexpress_dt_cortex_a9_scu_base __initdata;
>> >
>> > -const static char *vexpress_dt_cortex_a9_match[] __initconst = {
>> > +static const char *vexpress_dt_cortex_a9_match[] __initconst = {
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
>
thank you.
:-)
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM:vexpress: beautify code, using 'static const' instead of 'const static'
2013-03-10 2:29 [PATCH] ARM:vexpress: beautify code, using 'static const' instead of 'const static' Chen Gang
2013-03-10 2:57 ` Viresh Kumar
@ 2013-03-11 13:40 ` Pawel Moll
1 sibling, 0 replies; 4+ messages in thread
From: Pawel Moll @ 2013-03-11 13:40 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, 2013-03-10 at 02:29 +0000, Chen Gang wrote:
> better using 'static const' instead of 'const static'
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/arm/mach-vexpress/platsmp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-vexpress/platsmp.c b/arch/arm/mach-vexpress/platsmp.c
> index dc1ace5..9152bf7 100644
> --- a/arch/arm/mach-vexpress/platsmp.c
> +++ b/arch/arm/mach-vexpress/platsmp.c
> @@ -40,7 +40,7 @@ static struct map_desc vexpress_dt_cortex_a9_scu_map __initdata = {
>
> static void *vexpress_dt_cortex_a9_scu_base __initdata;
>
> -const static char *vexpress_dt_cortex_a9_match[] __initconst = {
> +static const char *vexpress_dt_cortex_a9_match[] __initconst = {
> "arm,cortex-a5-scu",
> "arm,cortex-a9-scu",
> NULL
Thanks for spotting this. I will keep this in mind, but I can't promise
to take this patch as it goes, because the platsmp.c is likely to change
(shrink) in near future. Either way I'll make sure you get due
credit :-)
Cheers!
Pawel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-11 13:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-10 2:29 [PATCH] ARM:vexpress: beautify code, using 'static const' instead of 'const static' Chen Gang
2013-03-10 2:57 ` Viresh Kumar
2013-03-10 3:13 ` Chen Gang
2013-03-11 13:40 ` Pawel Moll
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).