[PATCH 1/2] driver: serial-omap: move max uart count into generic header file.

[PATCH 1/2] driver: serial-omap: move max uart count into generic header file.

[Sourav Poddar]

OMAP_MAX_HSUART_PORTS is moved to omap_serial header file.

Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Felipe Balbi <balbi@ti.com>
Cc: Rajendra nayak <rnayak@ti.com>
Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
---
 drivers/tty/serial/omap-serial.c          |    2 --
 include/linux/platform_data/serial-omap.h |    1 +
 2 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index 5722eaf..4c2ba9f 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -43,8 +43,6 @@
 #include <linux/pinctrl/consumer.h>
 #include <linux/platform_data/serial-omap.h>
 
-#define OMAP_MAX_HSUART_PORTS	6
-
 #define UART_BUILD_REVISION(x, y)	(((x) << 8) | (y))
 
 #define OMAP_UART_REV_42 0x0402
diff --git a/include/linux/platform_data/serial-omap.h b/include/linux/platform_data/serial-omap.h
index ff9b0aa..92c48c2 100644
--- a/include/linux/platform_data/serial-omap.h
+++ b/include/linux/platform_data/serial-omap.h
@@ -29,6 +29,7 @@
  * is used as console uart.
  */
 #define OMAP_SERIAL_NAME	"ttyO"
+#define OMAP_MAX_HSUART_PORTS   6
 
 struct omap_uart_port_info {
 	bool			dma_enabled;	/* To specify DMA Mode */
-- 
1.7.1

[PATCH 1/2] driver: serial-omap: move max uart count into generic header file.

[Kevin Hilman]

Sourav Poddar <sourav.poddar@ti.com> writes:

> OMAP_MAX_HSUART_PORTS is moved to omap_serial header file.

Why?  

You started to explain it in the cover letter, but a full description
belongs here for the permanent git history.

Kevin

> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Cc: Felipe Balbi <balbi@ti.com>
> Cc: Rajendra nayak <rnayak@ti.com>
> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
> ---
>  drivers/tty/serial/omap-serial.c          |    2 --
>  include/linux/platform_data/serial-omap.h |    1 +
>  2 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
> index 5722eaf..4c2ba9f 100644
> --- a/drivers/tty/serial/omap-serial.c
> +++ b/drivers/tty/serial/omap-serial.c
> @@ -43,8 +43,6 @@
>  #include <linux/pinctrl/consumer.h>
>  #include <linux/platform_data/serial-omap.h>
>  
> -#define OMAP_MAX_HSUART_PORTS	6
> -
>  #define UART_BUILD_REVISION(x, y)	(((x) << 8) | (y))
>  
>  #define OMAP_UART_REV_42 0x0402
> diff --git a/include/linux/platform_data/serial-omap.h b/include/linux/platform_data/serial-omap.h
> index ff9b0aa..92c48c2 100644
> --- a/include/linux/platform_data/serial-omap.h
> +++ b/include/linux/platform_data/serial-omap.h
> @@ -29,6 +29,7 @@
>   * is used as console uart.
>   */
>  #define OMAP_SERIAL_NAME	"ttyO"
> +#define OMAP_MAX_HSUART_PORTS   6
>  
>  struct omap_uart_port_info {
>  	bool			dma_enabled;	/* To specify DMA Mode */

[PATCH 1/2] driver: serial-omap: move max uart count into generic header file.

[Sourav Poddar]

Hi Kevin,
On Tuesday 19 March 2013 12:15 AM, Kevin Hilman wrote:
> Sourav Poddar<sourav.poddar@ti.com>  writes:
>
>> OMAP_MAX_HSUART_PORTS is moved to omap_serial header file.
> Why?
>
The patch is a prerequisitive for the next patch in the series, where I am
making use of the max number of uarts, omap device supports. Hence, I
am rearranging the macro from a driver file to a header file. So, it can 
be used at
multiple places.
> You started to explain it in the cover letter, but a full description
> belongs here for the permanent git history.
>
Sure, I will add the complete description for this here itself in my next
version.
> Kevin
>
>> Cc: Santosh Shilimkar<santosh.shilimkar@ti.com>
>> Cc: Felipe Balbi<balbi@ti.com>
>> Cc: Rajendra nayak<rnayak@ti.com>
>> Signed-off-by: Sourav Poddar<sourav.poddar@ti.com>
>> ---
>>   drivers/tty/serial/omap-serial.c          |    2 --
>>   include/linux/platform_data/serial-omap.h |    1 +
>>   2 files changed, 1 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
>> index 5722eaf..4c2ba9f 100644
>> --- a/drivers/tty/serial/omap-serial.c
>> +++ b/drivers/tty/serial/omap-serial.c
>> @@ -43,8 +43,6 @@
>>   #include<linux/pinctrl/consumer.h>
>>   #include<linux/platform_data/serial-omap.h>
>>
>> -#define OMAP_MAX_HSUART_PORTS	6
>> -
>>   #define UART_BUILD_REVISION(x, y)	(((x)<<  8) | (y))
>>
>>   #define OMAP_UART_REV_42 0x0402
>> diff --git a/include/linux/platform_data/serial-omap.h b/include/linux/platform_data/serial-omap.h
>> index ff9b0aa..92c48c2 100644
>> --- a/include/linux/platform_data/serial-omap.h
>> +++ b/include/linux/platform_data/serial-omap.h
>> @@ -29,6 +29,7 @@
>>    * is used as console uart.
>>    */
>>   #define OMAP_SERIAL_NAME	"ttyO"
>> +#define OMAP_MAX_HSUART_PORTS   6
>>
>>   struct omap_uart_port_info {
>>   	bool			dma_enabled;	/* To specify DMA Mode */