* [PATCH] pinctrl: mvebu: fix checking for SoC specific controls
@ 2013-03-19 19:07 Simon Guinot
2013-03-19 19:41 ` Sebastian Hesselbarth
2013-03-21 17:51 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Simon Guinot @ 2013-03-19 19:07 UTC (permalink / raw)
To: linux-arm-kernel
This patch fixes a minor bug (probably due to a typo) while checking
the SoC specific controls in mvebu_pinctrl_probe().
Signed-off-by: Simon Guinot <simon.guinot@sequanux.org>
---
drivers/pinctrl/mvebu/pinctrl-mvebu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/mvebu/pinctrl-mvebu.c b/drivers/pinctrl/mvebu/pinctrl-mvebu.c
index c689c04..2d2f0a4 100644
--- a/drivers/pinctrl/mvebu/pinctrl-mvebu.c
+++ b/drivers/pinctrl/mvebu/pinctrl-mvebu.c
@@ -620,7 +620,7 @@ int mvebu_pinctrl_probe(struct platform_device *pdev)
/* special soc specific control */
if (ctrl->mpp_get || ctrl->mpp_set) {
- if (!ctrl->name || !ctrl->mpp_set || !ctrl->mpp_set) {
+ if (!ctrl->name || !ctrl->mpp_get || !ctrl->mpp_set) {
dev_err(&pdev->dev, "wrong soc control info\n");
return -EINVAL;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] pinctrl: mvebu: fix checking for SoC specific controls
2013-03-19 19:07 [PATCH] pinctrl: mvebu: fix checking for SoC specific controls Simon Guinot
@ 2013-03-19 19:41 ` Sebastian Hesselbarth
2013-03-21 17:51 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Hesselbarth @ 2013-03-19 19:41 UTC (permalink / raw)
To: linux-arm-kernel
On 03/19/2013 08:07 PM, Simon Guinot wrote:
> This patch fixes a minor bug (probably due to a typo) while checking
> the SoC specific controls in mvebu_pinctrl_probe().
>
> Signed-off-by: Simon Guinot<simon.guinot@sequanux.org>
Simon,
good catch! The patch looks sane to me, so
Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> ---
> drivers/pinctrl/mvebu/pinctrl-mvebu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/mvebu/pinctrl-mvebu.c b/drivers/pinctrl/mvebu/pinctrl-mvebu.c
> index c689c04..2d2f0a4 100644
> --- a/drivers/pinctrl/mvebu/pinctrl-mvebu.c
> +++ b/drivers/pinctrl/mvebu/pinctrl-mvebu.c
> @@ -620,7 +620,7 @@ int mvebu_pinctrl_probe(struct platform_device *pdev)
>
> /* special soc specific control */
> if (ctrl->mpp_get || ctrl->mpp_set) {
> - if (!ctrl->name || !ctrl->mpp_set || !ctrl->mpp_set) {
> + if (!ctrl->name || !ctrl->mpp_get || !ctrl->mpp_set) {
> dev_err(&pdev->dev, "wrong soc control info\n");
> return -EINVAL;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] pinctrl: mvebu: fix checking for SoC specific controls
2013-03-19 19:07 [PATCH] pinctrl: mvebu: fix checking for SoC specific controls Simon Guinot
2013-03-19 19:41 ` Sebastian Hesselbarth
@ 2013-03-21 17:51 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2013-03-21 17:51 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Mar 19, 2013 at 8:07 PM, Simon Guinot <simon.guinot@sequanux.org> wrote:
> This patch fixes a minor bug (probably due to a typo) while checking
> the SoC specific controls in mvebu_pinctrl_probe().
>
> Signed-off-by: Simon Guinot <simon.guinot@sequanux.org>
Patch applied with Sebastian's ACK, thanks!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-21 17:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-19 19:07 [PATCH] pinctrl: mvebu: fix checking for SoC specific controls Simon Guinot
2013-03-19 19:41 ` Sebastian Hesselbarth
2013-03-21 17:51 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).