* [PATCH] irqchip: gic: fix irq_trigger return
@ 2013-03-19 23:05 Stephen Boyd
2013-03-26 17:33 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Boyd @ 2013-03-19 23:05 UTC (permalink / raw)
To: linux-arm-kernel
From: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
The genirq layer expects a 0 in case of failure but the code is
returning -ENXIO. Fix it.
Signed-off-by: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
drivers/irqchip/irq-gic.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
index 644d724..2ebf28a 100644
--- a/drivers/irqchip/irq-gic.c
+++ b/drivers/irqchip/irq-gic.c
@@ -236,7 +236,8 @@ static int gic_retrigger(struct irq_data *d)
if (gic_arch_extn.irq_retrigger)
return gic_arch_extn.irq_retrigger(d);
- return -ENXIO;
+ /* the genirq layer expects 0 for a failure */
+ return 0;
}
#ifdef CONFIG_SMP
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] irqchip: gic: fix irq_trigger return
2013-03-19 23:05 [PATCH] irqchip: gic: fix irq_trigger return Stephen Boyd
@ 2013-03-26 17:33 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2013-03-26 17:33 UTC (permalink / raw)
To: linux-arm-kernel
On 03/19/13 16:05, Stephen Boyd wrote:
> From: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
>
> The genirq layer expects a 0 in case of failure but the code is
> returning -ENXIO. Fix it.
>
> Signed-off-by: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> drivers/irqchip/irq-gic.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
> index 644d724..2ebf28a 100644
> --- a/drivers/irqchip/irq-gic.c
> +++ b/drivers/irqchip/irq-gic.c
> @@ -236,7 +236,8 @@ static int gic_retrigger(struct irq_data *d)
> if (gic_arch_extn.irq_retrigger)
> return gic_arch_extn.irq_retrigger(d);
>
> - return -ENXIO;
> + /* the genirq layer expects 0 for a failure */
> + return 0;
> }
>
> #ifdef CONFIG_SMP
Ping.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-26 17:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-19 23:05 [PATCH] irqchip: gic: fix irq_trigger return Stephen Boyd
2013-03-26 17:33 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).