linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@prisktech.co.nz (Tony Prisk)
To: linux-arm-kernel@lists.infradead.org
Subject: [Bulk] [PATCH V4 7/9] ARM: vt8500: Provide regulator to pwm-backlight
Date: Thu, 21 Mar 2013 07:18:35 +1300	[thread overview]
Message-ID: <1363803515.4635.7.camel@gitbox> (raw)
In-Reply-To: <1363719573-20926-8-git-send-email-achew@nvidia.com>

On Tue, 2013-03-19 at 11:59 -0700, Andrew Chew wrote:
> The pwm-backlight driver now takes a mandatory regulator that is gotten
> during driver probe.  Initialize a dummy regulator to satisfy this
> requirement.
> 
> Signed-off-by: Andrew Chew <achew@nvidia.com>
> ---
>  arch/arm/boot/dts/wm8850-w70v2.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/wm8850-w70v2.dts b/arch/arm/boot/dts/wm8850-w70v2.dts
> index fcc660c..47a0b1a 100644
> --- a/arch/arm/boot/dts/wm8850-w70v2.dts
> +++ b/arch/arm/boot/dts/wm8850-w70v2.dts
> @@ -37,11 +37,17 @@
>  		};
>  	};
>  
> +	bl_en: fixed-regulator {
> +		compatible = "regulator-fixed";
> +		regulator-name = "bl-en-supply";
> +	};
> +
>  	backlight {
>  		compatible = "pwm-backlight";
>  		pwms = <&pwm 0 50000 1>;	/* duty inverted */
>  
>  		brightness-levels = <0 40 60 80 100 130 190 255>;
>  		default-brightness-level = <5>;
> +		enable-supply = <&bl_en>;
>  	};
>  };

This board will use either <&gpio 0 7 0> or <&pinctrl 7 0>, dependant on
the pinctrl driver patchset going through.

If you want it to 'work', feel free to add a regulator for the <&gpio 0
7 0> case - otherwise just leave the dummy and I'll patch it later once
the pinctrl driver is finished.

I only know of one user who is disabling the backlight gpio at present,
and he is doing it with a gpio-led node.

The backlight is enabled by uboot on all boards with an LCD present, so
this is just a power-saving feature for us - nothing breaks by having a
dummy.

Acked-by: Tony Prisk <linux@prisktech.co.nz>

Regards
Tony P

  reply	other threads:[~2013-03-20 18:18 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-19 18:59 [PATCH V4 0/9] Add mandatory regulator for all users of pwm-backlight Andrew Chew
2013-03-19 18:59 ` [PATCH V4 1/9] ARM: OMAP: board-4430sdp: Provide regulator to pwm-backlight Andrew Chew
2013-03-19 18:59 ` [PATCH V4 2/9] ARM: S3C24XX: " Andrew Chew
2013-03-19 18:59 ` [PATCH V4 3/9] ARM: pxa: " Andrew Chew
2013-03-19 18:59 ` [PATCH V4 4/9] ARM: EXYNOS: " Andrew Chew
2013-03-19 18:59 ` [PATCH V4 5/9] unicore32: " Andrew Chew
2013-03-19 18:59 ` [PATCH V4 6/9] ARM: mxs: " Andrew Chew
2013-03-19 21:27   ` Marek Vasut
2013-03-19 21:31     ` Andrew Chew
2013-03-19 21:35       ` Marek Vasut
2013-03-19 22:10     ` Stephen Warren
2013-03-20  8:23       ` Mark Brown
2013-03-20 14:03         ` Marek Vasut
2013-03-20  3:13   ` Shawn Guo
2013-03-19 18:59 ` [PATCH V4 7/9] ARM: vt8500: " Andrew Chew
2013-03-20 18:18   ` Tony Prisk [this message]
2013-03-19 18:59 ` [PATCH V4 8/9] ARM: tegra: " Andrew Chew
2013-03-21 20:01   ` Stephen Warren
2013-03-22 10:29   ` Thierry Reding
2013-03-19 18:59 ` [PATCH V4 9/9] pwm_bl: Add mandatory backlight enable regulator Andrew Chew
2013-03-20 18:00   ` Stephen Warren
2013-03-20 22:19     ` Thierry Reding
2013-03-20  2:14 ` [PATCH V4 0/9] Add mandatory regulator for all users of pwm-backlight Shawn Guo
2013-03-20  2:24   ` Alex Courbot
2013-03-20  3:08     ` Shawn Guo
2013-03-20  7:13     ` Tony Prisk
2013-03-22  1:57 ` Alex Courbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363803515.4635.7.camel@gitbox \
    --to=linux@prisktech.co.nz \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).