From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] mfd: db8500-prcmu: Fetch the PRCMU TCDM base address from Device Tree
Date: Mon, 25 Mar 2013 15:02:37 +0000 [thread overview]
Message-ID: <1364223758-17621-2-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1364223758-17621-1-git-send-email-lee.jones@linaro.org>
A recent move to send the base addresses though the PRCMU platform
device resource instead of defines found in <mach/*>, means that dbx500
devices can no longer boot successfully when booting with Device Tree
enabled. This patch ensures the addresses are obtained correctly from
DT.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/mfd/db8500-prcmu.c | 28 ++++++++++++++++++++--------
1 file changed, 20 insertions(+), 8 deletions(-)
diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c
index 21f261b..8602bf8 100644
--- a/drivers/mfd/db8500-prcmu.c
+++ b/drivers/mfd/db8500-prcmu.c
@@ -17,6 +17,8 @@
#include <linux/err.h>
#include <linux/spinlock.h>
#include <linux/io.h>
+#include <linux/of.h>
+#include <linux/of_address.h>
#include <linux/slab.h>
#include <linux/mutex.h>
#include <linux/completion.h>
@@ -2790,19 +2792,29 @@ static int db8500_irq_init(struct device_node *np)
}
static void dbx500_fw_version_init(struct platform_device *pdev,
- u32 version_offset)
+ u32 version_offset,
+ struct device_node *np)
{
+ struct device_node *tcpm_np;
struct resource *res;
- void __iomem *tcpm_base;
+ void __iomem *tcpm_base = NULL;
res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
"prcmu-tcpm");
if (!res) {
- dev_err(&pdev->dev,
- "Error: no prcmu tcpm memory region provided\n");
- return;
- }
- tcpm_base = ioremap(res->start, resource_size(res));
+ if (np) {
+ tcpm_np = of_find_node_by_name(np->parent,
+ "prcmu-tcpm-per4");
+ if (!tcpm_np) {
+ dev_err(&pdev->dev,
+ "no prcmu tcpm mem region provided\n");
+ return;
+ }
+ tcpm_base = of_iomap(tcpm_np, 0);
+ }
+ } else
+ tcpm_base = ioremap(res->start, resource_size(res));
+
if (tcpm_base != NULL) {
u32 version;
@@ -3154,7 +3166,7 @@ static int db8500_prcmu_probe(struct platform_device *pdev)
init_prcm_registers();
- dbx500_fw_version_init(pdev, pdata->version_offset);
+ dbx500_fw_version_init(pdev, pdata->version_offset, np);
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "prcmu-tcdm");
if (!res) {
dev_err(&pdev->dev, "no prcmu tcdm region provided\n");
--
1.7.10.4
next prev parent reply other threads:[~2013-03-25 15:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 15:02 [PATCH 1/3] ARM: ux500: Add device nodes for TCDM and TCPM memory locations Lee Jones
2013-03-25 15:02 ` Lee Jones [this message]
2013-03-25 15:32 ` [PATCH 2/3] mfd: db8500-prcmu: Fetch the PRCMU TCDM base address from Device Tree Lee Jones
2013-03-25 15:40 ` Arnd Bergmann
2013-03-25 16:46 ` Lee Jones
2013-03-25 21:32 ` Linus Walleij
2013-03-26 8:17 ` Lee Jones
2013-03-26 9:11 ` Linus Walleij
2013-03-26 9:48 ` Lee Jones
2013-03-26 10:00 ` Arnd Bergmann
2013-03-26 10:19 ` Lee Jones
2013-03-25 15:02 ` [PATCH 3/3] mfd: db8500-prcmu: Fetch the PRCMU TCPM " Lee Jones
2013-03-25 15:31 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364223758-17621-2-git-send-email-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).