* [PATCHv2] usb: ehci: unlink_empty_async_suspended() only used with CONFIG_PM
@ 2013-03-26 18:14 Tony Prisk
2013-03-26 18:45 ` Alan Stern
0 siblings, 1 reply; 3+ messages in thread
From: Tony Prisk @ 2013-03-26 18:14 UTC (permalink / raw)
To: linux-arm-kernel
Compiling with !CONFIG_PM generates an unused function warning on
unlink_empty_async_suspended().
Enclose the function in a #ifdef CONFIG_PM
Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
---
Fixed up the commit message.
drivers/usb/host/ehci-q.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-q.c b/drivers/usb/host/ehci-q.c
index 23d1369..3638b28 100644
--- a/drivers/usb/host/ehci-q.c
+++ b/drivers/usb/host/ehci-q.c
@@ -1316,6 +1316,7 @@ static void unlink_empty_async(struct ehci_hcd *ehci)
}
}
+#ifdef CONFIG_PM
/* The root hub is suspended; unlink all the async QHs */
static void unlink_empty_async_suspended(struct ehci_hcd *ehci)
{
@@ -1328,7 +1329,7 @@ static void unlink_empty_async_suspended(struct ehci_hcd *ehci)
}
start_iaa_cycle(ehci, false);
}
-
+#endif
/* makes sure the async qh will become idle */
/* caller must own ehci->lock */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCHv2] usb: ehci: unlink_empty_async_suspended() only used with CONFIG_PM
2013-03-26 18:14 [PATCHv2] usb: ehci: unlink_empty_async_suspended() only used with CONFIG_PM Tony Prisk
@ 2013-03-26 18:45 ` Alan Stern
0 siblings, 0 replies; 3+ messages in thread
From: Alan Stern @ 2013-03-26 18:45 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, 27 Mar 2013, Tony Prisk wrote:
> Compiling with !CONFIG_PM generates an unused function warning on
> unlink_empty_async_suspended().
>
> Enclose the function in a #ifdef CONFIG_PM
>
> Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
> ---
> Fixed up the commit message.
> drivers/usb/host/ehci-q.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ehci-q.c b/drivers/usb/host/ehci-q.c
> index 23d1369..3638b28 100644
> --- a/drivers/usb/host/ehci-q.c
> +++ b/drivers/usb/host/ehci-q.c
> @@ -1316,6 +1316,7 @@ static void unlink_empty_async(struct ehci_hcd *ehci)
> }
> }
>
> +#ifdef CONFIG_PM
> /* The root hub is suspended; unlink all the async QHs */
> static void unlink_empty_async_suspended(struct ehci_hcd *ehci)
> {
> @@ -1328,7 +1329,7 @@ static void unlink_empty_async_suspended(struct ehci_hcd *ehci)
> }
> start_iaa_cycle(ehci, false);
> }
> -
> +#endif
> /* makes sure the async qh will become idle */
> /* caller must own ehci->lock */
Acked-by: Alan Stern <stern@rowland.harvard.edu>
... except that the blank line before the comment in the hunk above
should be retained, not removed.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCHv2] usb: ehci: unlink_empty_async_suspended() only used with CONFIG_PM
@ 2013-03-27 5:28 Tony Prisk
0 siblings, 0 replies; 3+ messages in thread
From: Tony Prisk @ 2013-03-27 5:28 UTC (permalink / raw)
To: linux-arm-kernel
Compiling with !CONFIG_PM generates an unused function warning on
unlink_empty_async_suspended().
Enclose the function in a #ifdef CONFIG_PM
Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
---
v2:
Tidy up blank line as requested by Alan Stern
drivers/usb/host/ehci-q.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/ehci-q.c b/drivers/usb/host/ehci-q.c
index 23d1369..1ea4de1 100644
--- a/drivers/usb/host/ehci-q.c
+++ b/drivers/usb/host/ehci-q.c
@@ -1316,6 +1316,7 @@ static void unlink_empty_async(struct ehci_hcd *ehci)
}
}
+#ifdef CONFIG_PM
/* The root hub is suspended; unlink all the async QHs */
static void unlink_empty_async_suspended(struct ehci_hcd *ehci)
{
@@ -1328,6 +1329,7 @@ static void unlink_empty_async_suspended(struct ehci_hcd *ehci)
}
start_iaa_cycle(ehci, false);
}
+#endif
/* makes sure the async qh will become idle */
/* caller must own ehci->lock */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-27 5:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-26 18:14 [PATCHv2] usb: ehci: unlink_empty_async_suspended() only used with CONFIG_PM Tony Prisk
2013-03-26 18:45 ` Alan Stern
-- strict thread matches above, loose matches on Subject: below --
2013-03-27 5:28 Tony Prisk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).