* [PATCH] arm: mvebu: Fix pinctrl for Armada 370 Mirabox SDIO port.
@ 2013-03-26 23:32 Ryan Press
2013-03-28 17:33 ` Jason Cooper
0 siblings, 1 reply; 2+ messages in thread
From: Ryan Press @ 2013-03-26 23:32 UTC (permalink / raw)
To: linux-arm-kernel
The previous configuration used the wrong "clk" pin. Without this change mv_sdio worked because the bootloader would set the pin up, but with a bootloader that does not set the pin, mv_sdio fails to detect any card.
I have tested this change using a mwifiex_sdio wireless network adapter over the SDIO interface.
Signed-off-by: Ryan Press <ryan@presslab.us>
---
arch/arm/boot/dts/armada-370-mirabox.dts | 2 +-
arch/arm/boot/dts/armada-370.dtsi | 6 ++++++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/armada-370-mirabox.dts b/arch/arm/boot/dts/armada-370-mirabox.dts
index dd0c57d..3234875 100644
--- a/arch/arm/boot/dts/armada-370-mirabox.dts
+++ b/arch/arm/boot/dts/armada-370-mirabox.dts
@@ -54,7 +54,7 @@
};
mvsdio at d00d4000 {
- pinctrl-0 = <&sdio_pins2>;
+ pinctrl-0 = <&sdio_pins3>;
pinctrl-names = "default";
status = "okay";
/*
diff --git a/arch/arm/boot/dts/armada-370.dtsi b/arch/arm/boot/dts/armada-370.dtsi
index 8188d13..a195deb 100644
--- a/arch/arm/boot/dts/armada-370.dtsi
+++ b/arch/arm/boot/dts/armada-370.dtsi
@@ -59,6 +59,12 @@
"mpp50", "mpp51", "mpp52";
marvell,function = "sd0";
};
+
+ sdio_pins3: sdio-pins3 {
+ marvell,pins = "mpp48", "mpp49", "mpp50",
+ "mpp51", "mpp52", "mpp53";
+ marvell,function = "sd0";
+ };
};
gpio0: gpio at d0018100 {
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] arm: mvebu: Fix pinctrl for Armada 370 Mirabox SDIO port.
2013-03-26 23:32 [PATCH] arm: mvebu: Fix pinctrl for Armada 370 Mirabox SDIO port Ryan Press
@ 2013-03-28 17:33 ` Jason Cooper
0 siblings, 0 replies; 2+ messages in thread
From: Jason Cooper @ 2013-03-28 17:33 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Mar 26, 2013 at 04:32:31PM -0700, Ryan Press wrote:
> The previous configuration used the wrong "clk" pin. Without this
> change mv_sdio worked because the bootloader would set the pin up, but
> with a bootloader that does not set the pin, mv_sdio fails to detect
> any card.
>
> I have tested this change using a mwifiex_sdio wireless network
> adapter over the SDIO interface.
>
> Signed-off-by: Ryan Press <ryan@presslab.us>
> ---
> arch/arm/boot/dts/armada-370-mirabox.dts | 2 +-
> arch/arm/boot/dts/armada-370.dtsi | 6 ++++++
> 2 files changed, 7 insertions(+), 1 deletion(-)
Applied to mvebu/fixes
I changed the commit message to wrap at the appropriate width.
thx,
Jason.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-28 17:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-26 23:32 [PATCH] arm: mvebu: Fix pinctrl for Armada 370 Mirabox SDIO port Ryan Press
2013-03-28 17:33 ` Jason Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).