From: p.zabel@pengutronix.de (Philipp Zabel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/11] staging: drm/imx: Add LDB support
Date: Wed, 27 Mar 2013 12:58:42 +0100 [thread overview]
Message-ID: <1364385522.5442.14.camel@pizza.hi.pengutronix.de> (raw)
In-Reply-To: <5152DDEB.9020907@parkeon.com>
Hi Martin,
Am Mittwoch, den 27.03.2013, 12:54 +0100 schrieb Martin Fuzzey:
> Hi Philipp,
>
> On 26/03/13 15:13, Philipp Zabel wrote:
>
> > +static void imx_ldb_encoder_disable(struct drm_encoder *encoder)
> > +{
> > + struct imx_ldb_channel *imx_ldb_ch = enc_to_imx_ldb_ch(encoder);
> > + struct imx_ldb *ldb = imx_ldb_ch->ldb;
> > +
> > + if (gpio_is_valid(imx_ldb_ch->enable_gpio))
> > + gpio_set_value(imx_ldb_ch->enable_gpio, 0);
> >
> I get a compile error here:
> drivers/staging/imx-drm/imx-ldb.c: In function ?imx_ldb_encoder_disable?:
> drivers/staging/imx-drm/imx-ldb.c:283:2: error: implicit declaration of
> function ?gpio_is_valid? [-Werror=implicit-function-declaration]
> drivers/staging/imx-drm/imx-ldb.c:283:30: error: ?struct
> imx_ldb_channel? has no member named ?enable_gpio?
> drivers/staging/imx-drm/imx-ldb.c:284:3: error: implicit declaration of
> function ?gpio_set_value? [-Werror=implicit-function-declaration]
> drivers/staging/imx-drm/imx-ldb.c:284:28: error: ?struct
> imx_ldb_channel? has no member named ?enable_gpio?
>
> Adding #include <linux/gpio.h> fixes that but gives another error:
> drivers/staging/imx-drm/imx-ldb.c: In function ?imx_ldb_encoder_disable?:
> drivers/staging/imx-drm/imx-ldb.c:284:30: error: ?struct
> imx_ldb_channel? has no member named ?enable_gpio?
> drivers/staging/imx-drm/imx-ldb.c:285:28: error: ?struct
> imx_ldb_channel? has no member named ?enable_gpio?
>
> Commenting out the block gives a working driver.
thank you for pointing this out, the GPIO handling shouldn't have leaked
into this patch series.
regards
Philipp
next prev parent reply other threads:[~2013-03-27 11:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 14:13 [PATCH 0/11] LVDS Display Bridge support for i.MX Philipp Zabel
2013-03-26 14:13 ` [PATCH 01/11] staging: drm/imx: Add LDB support Philipp Zabel
2013-03-26 14:34 ` Thomas Petazzoni
2013-03-26 15:38 ` Philipp Zabel
2013-03-27 11:54 ` Martin Fuzzey
2013-03-27 11:58 ` Philipp Zabel [this message]
2013-03-26 14:13 ` [PATCH 02/11] ARM i.MX5: Move IPU clock lookups into device tree Philipp Zabel
2013-03-26 14:13 ` [PATCH 03/11] ARM i.MX6q: export imx6q_revision Philipp Zabel
2013-03-26 14:13 ` [PATCH 04/11] ARM i.MX6q: Add audio/video PLL post dividers for i.MX6q rev 1.1 Philipp Zabel
2013-03-26 14:14 ` [PATCH 05/11] ARM i.MX6q: set the LDB serial clock parent to the video PLL Philipp Zabel
2013-03-26 14:14 ` [PATCH 06/11] ARM i.MX: Add imx_clk_divider_flags and imx_clk_mux_flags Philipp Zabel
2013-03-26 14:14 ` [PATCH 07/11] ARM i.MX53: fix ldb di divider and selector clocks Philipp Zabel
2013-03-26 14:14 ` [PATCH 08/11] ARM i.MX6q: " Philipp Zabel
2013-03-26 14:14 ` [PATCH 09/11] ARM i.MX53: Add IOMUXC GPR to device tree Philipp Zabel
2013-03-26 14:14 ` [PATCH 10/11] ARM i.MX53: Add LDB device " Philipp Zabel
2013-03-26 14:14 ` [PATCH 11/11] ARM i.MX6q: " Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364385522.5442.14.camel@pizza.hi.pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).