From: tpiepho@gmail.com (Trent Piepho)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] spi/mxs: Remove bogus setting of ssp clk rate field
Date: Fri, 29 Mar 2013 08:19:40 -0700 [thread overview]
Message-ID: <1364570381-17605-4-git-send-email-tpiepho@gmail.com> (raw)
In-Reply-To: <1364570381-17605-1-git-send-email-tpiepho@gmail.com>
The ssp struct has a clock rate field, to provide the actual value, in Hz,
of the SSP output clock (the rate of SSP_SCK) after mxs_ssp_set_clk_rate()
is called. It should be read-only, except for mxs_ssp_set_clk_rate().
For some reason the spi-mxs driver decides to write to this field on init,
and sets it to the value of the SSP input clock (clk_sspN, from the MXS
clocking block) in kHz. It shouldn't be setting the value, and certainly
shouldn't be setting it with the wrong clock in the wrong units.
Signed-off-by: Trent Piepho <tpiepho@gmail.com>
Cc: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <fabio.estevam@freescale.com>
Cc: Shawn Guo <shawn.guo@linaro.org>
---
drivers/spi/spi-mxs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c
index 7218006..fc52f78 100644
--- a/drivers/spi/spi-mxs.c
+++ b/drivers/spi/spi-mxs.c
@@ -587,7 +587,6 @@ static int mxs_spi_probe(struct platform_device *pdev)
clk_prepare_enable(ssp->clk);
clk_set_rate(ssp->clk, clk_freq);
- ssp->clk_rate = clk_get_rate(ssp->clk) / 1000;
stmp_reset_block(ssp->base);
--
1.7.10.4
next prev parent reply other threads:[~2013-03-29 15:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 15:19 [PATCH 1/5] spi/mxs: Fix extra CS pulses and read mode in multi-transfer messages Trent Piepho
2013-03-29 15:19 ` [PATCH 2/5] spi/mxs: Fix chip select control bits in DMA mode Trent Piepho
2013-04-01 23:13 ` Marek Vasut
2013-04-01 23:27 ` Trent Piepho
2013-04-01 23:30 ` Marek Vasut
2013-04-01 23:40 ` Trent Piepho
2013-04-02 0:02 ` Marek Vasut
2013-04-02 1:58 ` Trent Piepho
2013-03-29 15:19 ` [PATCH 3/5] spi/mxs: Remove full duplex check, spi core already does it Trent Piepho
2013-03-29 15:19 ` Trent Piepho [this message]
2013-04-01 23:16 ` [PATCH 4/5] spi/mxs: Remove bogus setting of ssp clk rate field Marek Vasut
2013-04-01 23:32 ` Trent Piepho
2013-04-01 23:37 ` Marek Vasut
2013-04-02 0:07 ` Trent Piepho
2013-04-02 0:29 ` Marek Vasut
2013-03-29 15:19 ` [PATCH 5/5] spi/mxs: Fix multiple slave bug and don't set clock for each xfer Trent Piepho
2013-04-01 23:18 ` Marek Vasut
2013-04-01 23:11 ` [PATCH 1/5] spi/mxs: Fix extra CS pulses and read mode in multi-transfer messages Marek Vasut
2013-04-02 1:24 ` Trent Piepho
2013-04-02 4:22 ` Marek Vasut
2013-04-02 7:11 ` Trent Piepho
2013-04-02 10:32 ` Marek Vasut
2013-04-02 12:40 ` Trent Piepho
2013-04-02 23:39 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364570381-17605-4-git-send-email-tpiepho@gmail.com \
--to=tpiepho@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).