From: tpiepho@gmail.com (Trent Piepho)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 09/12] spi/mxs: Remove check of spi mode bits
Date: Tue, 2 Apr 2013 05:19:52 -0700 [thread overview]
Message-ID: <1364905195-24286-9-git-send-email-tpiepho@gmail.com> (raw)
In-Reply-To: <1364905195-24286-1-git-send-email-tpiepho@gmail.com>
The spi core already checks for a slave setting mode bits that we
didn't list as supported when the master was registered. There is no
need to do it again in the master driver.
Signed-off-by: Trent Piepho <tpiepho@gmail.com>
Cc: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <fabio.estevam@freescale.com>
Cc: Shawn Guo <shawn.guo@linaro.org>
---
drivers/spi/spi-mxs.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c
index 2a2147a..d71029e 100644
--- a/drivers/spi/spi-mxs.c
+++ b/drivers/spi/spi-mxs.c
@@ -118,9 +118,6 @@ static int mxs_spi_setup(struct spi_device *dev)
if (!dev->bits_per_word)
dev->bits_per_word = 8;
- if (dev->mode & ~(SPI_CPOL | SPI_CPHA))
- return -EINVAL;
-
if (dev->bits_per_word != 8)
return -EINVAL;
--
1.7.10.4
next prev parent reply other threads:[~2013-04-02 12:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 12:19 [PATCH V2 01/12] spi/mxs: Always set LOCK_CS Trent Piepho
2013-04-02 12:19 ` [PATCH V2 02/12] spi/mxs: Remove mxs_spi_enable and mxs_spi_disable Trent Piepho
2013-04-02 12:19 ` [PATCH V2 03/12] spi/mxs: Change flag arguments in txrx functions to bit flags Trent Piepho
2013-04-02 23:24 ` Marek Vasut
2013-04-02 12:19 ` [PATCH V2 04/12] spi/mxs: Fix extra CS pulses and read mode in multi-transfer messages Trent Piepho
2013-04-02 12:19 ` [PATCH V2 05/12] spi/mxs: Fix chip select control bits in DMA mode Trent Piepho
2013-04-02 23:29 ` Marek Vasut
2013-04-02 12:19 ` [PATCH V2 06/12] spi/mxs: Remove full duplex check, spi core already does it Trent Piepho
2013-04-02 12:19 ` [PATCH V2 07/12] spi/mxs: Remove bogus setting of ssp clk rate field Trent Piepho
2013-04-02 12:19 ` [PATCH V2 08/12] spi/mxs: Fix race in setup method Trent Piepho
2013-04-02 23:31 ` Marek Vasut
2013-04-03 2:12 ` Trent Piepho
2013-04-03 2:27 ` Marek Vasut
2013-04-03 6:08 ` Trent Piepho
2013-04-03 6:50 ` Marek Vasut
2013-04-03 9:32 ` Trent Piepho
2013-04-02 12:19 ` Trent Piepho [this message]
2013-04-02 12:19 ` [PATCH V2 10/12] spi/mxs: Clean up setup_transfer function Trent Piepho
2013-04-02 23:35 ` Marek Vasut
2013-04-02 12:19 ` [PATCH V2 11/12] spi/mxs: Don't set clock for each xfer Trent Piepho
2013-04-02 23:38 ` Marek Vasut
2013-04-02 12:19 ` [PATCH V2 12/12] spi/mxs: Use u32 instead of uint32_t Trent Piepho
2013-04-02 23:18 ` [PATCH V2 01/12] spi/mxs: Always set LOCK_CS Marek Vasut
2013-07-10 13:49 ` Fabio Estevam
2013-07-10 15:29 ` Lothar Waßmann
2013-04-03 1:41 ` Shawn Guo
2013-04-14 18:01 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364905195-24286-9-git-send-email-tpiepho@gmail.com \
--to=tpiepho@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).