From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/9] ARM: davinci: cpuidle: fix wrong enter function
Date: Wed, 3 Apr 2013 14:15:19 +0200 [thread overview]
Message-ID: <1364991322-20585-6-git-send-email-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <1364991322-20585-1-git-send-email-daniel.lezcano@linaro.org>
The davinci_enter_idle is called from the cpuidle with the
cpuidle_wrap_enter function. This one does the time compution
for entering and exiting the idle function and then we call
again cpuidle_wrap_enter for cpu_do_idle. This is wrong, we
are calling recursively cpuidle_wrap_enter for nothing and
furthermore reenabling the local irq.
Remove this and replace it by the cpu_do_idle function.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
---
arch/arm/mach-davinci/cpuidle.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/arch/arm/mach-davinci/cpuidle.c b/arch/arm/mach-davinci/cpuidle.c
index 5ac9e93..22d6d4a 100644
--- a/arch/arm/mach-davinci/cpuidle.c
+++ b/arch/arm/mach-davinci/cpuidle.c
@@ -50,14 +50,10 @@ static void davinci_save_ddr_power(int enter, bool pdown)
/* Actual code that puts the SoC in different idle states */
static int davinci_enter_idle(struct cpuidle_device *dev,
- struct cpuidle_driver *drv,
- int index)
+ struct cpuidle_driver *drv, int index)
{
davinci_save_ddr_power(1, ddr2_pdown);
-
- index = cpuidle_wrap_enter(dev, drv, index,
- arm_cpuidle_simple_enter);
-
+ cpu_do_idle();
davinci_save_ddr_power(0, ddr2_pdown);
return index;
--
1.7.9.5
next prev parent reply other threads:[~2013-04-03 12:15 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 12:15 [PATCH 1/9] ARM: cpuidle: remove useless declaration Daniel Lezcano
2013-04-03 12:15 ` [PATCH 2/9] ARM: shmobile: pm: fix init sections Daniel Lezcano
2013-04-03 12:15 ` [PATCH 3/9] ARM: shmobile: cpuidle: remove useless WFI function Daniel Lezcano
2013-04-03 12:15 ` [PATCH 4/9] ARM: tegra2: cpuidle: change driver initialization Daniel Lezcano
2013-04-03 12:15 ` [PATCH 5/9] ARM: tegra: cpuidle: remove useless initialization Daniel Lezcano
2013-04-03 12:15 ` Daniel Lezcano [this message]
2013-04-04 7:16 ` [PATCH 6/9] ARM: davinci: cpuidle: fix wrong enter function Sekhar Nori
2013-04-03 12:15 ` [PATCH 7/9] intel: cpuidle: remove stop/start critical timings Daniel Lezcano
2013-04-04 22:31 ` Rafael J. Wysocki
2013-04-07 20:52 ` Daniel Lezcano
2013-04-08 17:40 ` Daniel Lezcano
2013-04-08 19:27 ` Rafael J. Wysocki
2013-04-08 19:27 ` Daniel Lezcano
2013-04-19 22:02 ` Len Brown
2013-04-03 12:15 ` [PATCH 8/9] ARM: omap3: cpuidle: enable time keeping Daniel Lezcano
2013-04-03 17:47 ` Kevin Hilman
2013-04-03 20:49 ` Daniel Lezcano
2013-04-03 21:43 ` Kevin Hilman
2013-04-03 12:15 ` [PATCH 9/9] POWERPC: pseries: cpuidle: use time keeping flag Daniel Lezcano
2013-04-03 14:25 ` Daniel Lezcano
2013-04-04 11:01 ` Deepthi Dharwar
2013-04-03 12:23 ` [PATCH 1/9] ARM: cpuidle: remove useless declaration Daniel Lezcano
2013-04-08 20:50 ` Rafael J. Wysocki
2013-04-08 20:53 ` Daniel Lezcano
2013-04-18 14:13 ` Russell King - ARM Linux
2013-04-18 14:31 ` Daniel Lezcano
2013-04-18 15:42 ` Russell King - ARM Linux
2013-04-18 15:47 ` Daniel Lezcano
2013-04-04 22:30 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364991322-20585-6-git-send-email-daniel.lezcano@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).