linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: kevin@bracey.fi (Kevin Bracey)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: smp: call platform's cpu_die in ipi_cpu_stop
Date: Sat,  6 Apr 2013 15:37:04 +0300	[thread overview]
Message-ID: <1365251824-4852-2-git-send-email-kevin@bracey.fi> (raw)
In-Reply-To: <1365251824-4852-1-git-send-email-kevin@bracey.fi>

When hotplugging out, both cpu_kill and cpu_die have always been called.
But when smp_send_stop was used in machine_shutdown or panic, only
cpu_kill was called.

This causes problems for co-ordination between cpu_kill and cpu_die, as
attempted by shmobile. So add cpu_die call to ipi_cpu_stop, to ensure
that cpu_kill and cpu_die calls always occur together.

Signed-off-by: Kevin Bracey <kevin@bracey.fi>
---
 arch/arm/kernel/smp.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
index 84f4cbf..6692bba 100644
--- a/arch/arm/kernel/smp.c
+++ b/arch/arm/kernel/smp.c
@@ -572,6 +572,9 @@ static void ipi_cpu_stop(unsigned int cpu)
 	local_fiq_disable();
 	local_irq_disable();
 
+	if (smp_ops.cpu_die)
+		smp_ops.cpu_die(cpu);
+
 	while (1)
 		cpu_relax();
 }
-- 
1.8.2.445.gfcda34b

  reply	other threads:[~2013-04-06 12:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-06 12:37 [PATCH] cpu_kill/cpu_die coordination Kevin Bracey
2013-04-06 12:37 ` Kevin Bracey [this message]
2013-04-18 17:18   ` [PATCH] ARM: smp: call platform's cpu_die in ipi_cpu_stop Russell King - ARM Linux
2013-04-18 18:25     ` Russell King - ARM Linux
2013-04-18 19:09       ` Russell King - ARM Linux
2013-05-01 13:06         ` Rob Herring
2013-05-02 17:55           ` Russell King - ARM Linux
2013-04-18 19:44       ` Kevin Bracey
2013-04-18 19:57         ` Russell King - ARM Linux
2013-04-22 17:03           ` Kevin Bracey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365251824-4852-2-git-send-email-kevin@bracey.fi \
    --to=kevin@bracey.fi \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).