linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: p.zabel@pengutronix.de (Philipp Zabel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/7] staging: drm/imx: ipu-di: add comments explaining signal generator configuration
Date: Mon,  8 Apr 2013 18:04:34 +0200	[thread overview]
Message-ID: <1365437078-22579-4-git-send-email-p.zabel@pengutronix.de> (raw)
In-Reply-To: <1365437078-22579-1-git-send-email-p.zabel@pengutronix.de>

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/staging/imx-drm/ipu-v3/ipu-di.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-di.c b/drivers/staging/imx-drm/ipu-v3/ipu-di.c
index ec340da..26534b7 100644
--- a/drivers/staging/imx-drm/ipu-v3/ipu-di.c
+++ b/drivers/staging/imx-drm/ipu-v3/ipu-di.c
@@ -413,9 +413,11 @@ static void ipu_di_sync_config_noninterlaced(struct ipu_di *di,
 		sig->v_end_width;
 	struct di_sync_config cfg[] = {
 		{
+			/* 1: INT_HSYNC */
 			.run_count = h_total - 1,
 			.run_src = DI_SYNC_CLK,
 		} , {
+			/* PIN2: HSYNC */
 			.run_count = h_total - 1,
 			.run_src = DI_SYNC_CLK,
 			.offset_count = div * sig->v_to_h_sync,
@@ -424,23 +426,28 @@ static void ipu_di_sync_config_noninterlaced(struct ipu_di *di,
 			.cnt_polarity_trigger_src = DI_SYNC_CLK,
 			.cnt_down = sig->h_sync_width * 2,
 		} , {
+			/* PIN3: VSYNC */
 			.run_count = v_total - 1,
 			.run_src = DI_SYNC_INT_HSYNC,
 			.cnt_polarity_gen_en = 1,
 			.cnt_polarity_trigger_src = DI_SYNC_INT_HSYNC,
 			.cnt_down = sig->v_sync_width * 2,
 		} , {
+			/* 4: Line Active */
 			.run_src = DI_SYNC_HSYNC,
 			.offset_count = sig->v_sync_width + sig->v_start_width,
 			.offset_src = DI_SYNC_HSYNC,
 			.repeat_count = sig->height,
 			.cnt_clr_src = DI_SYNC_VSYNC,
 		} , {
+			/* 5: DE, referenced by DC */
 			.run_src = DI_SYNC_CLK,
 			.offset_count = sig->h_sync_width + sig->h_start_width,
 			.offset_src = DI_SYNC_CLK,
 			.repeat_count = sig->width,
-			.cnt_clr_src = 5,
+			.cnt_clr_src = 5, /* Line Active */
+		} , {
+			/* unused */
 		} , {
 			/* unused */
 		} , {
-- 
1.8.2.rc2

  parent reply	other threads:[~2013-04-08 16:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-08 16:04 [PATCH 0/7] i.MX53 IPU + TVE patches Philipp Zabel
2013-04-08 16:04 ` [PATCH 1/7] staging: drm/imx: ipu-dc: add 24-bit GBR support to DC Philipp Zabel
2013-04-08 16:04 ` [PATCH 2/7] staging: drm/imx: ipuv3-crtc: use external clock for TV Encoder Philipp Zabel
2013-04-08 16:04 ` Philipp Zabel [this message]
2013-04-08 16:04 ` [PATCH 4/7] staging: drm/imx: Add support for VGA via TVE on i.MX53 Philipp Zabel
2013-04-08 16:04 ` [PATCH 5/7] staging: drm/imx: ipu-dc: add WCLK/WRG opcodes Philipp Zabel
2013-04-08 16:04 ` [PATCH 6/7] staging: drm/imx: ipu-dc: force black output during blanking Philipp Zabel
2013-04-08 16:04 ` [PATCH 7/7] staging: drm/imx: Add support for Television Encoder (TVEv2) Philipp Zabel
2013-04-09 12:55   ` Shawn Guo
2013-04-08 17:40 ` [PATCH 0/7] i.MX53 IPU + TVE patches Greg Kroah-Hartman
2013-04-09  7:44   ` Philipp Zabel
2013-04-09 23:15     ` Greg Kroah-Hartman
2013-04-11  9:04       ` [PATCH] staging: drm/imx: update TODO file Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365437078-22579-4-git-send-email-p.zabel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).