[PATCH v2 2/4] imx-drm: parallel-display: Make IPU KMS parse display-timings

[p.zabel@pengutronix.de (Philipp Zabel)]

Am Dienstag, den 09.04.2013, 11:07 -0300 schrieb Rogerio Pimentel:
> This patch adds support for parsing of the DT display-timings prop
> to IPU KMS driver.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Signed-off-by: Rogerio Pimentel <rogerio.pimentel@freescale.com>
> ---
> Changes since v1:
> Moved the function of_get_drm_display_mode from 
> imx_pd_connector_get_modes function to probe function
>  drivers/staging/imx-drm/parallel-display.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/imx-drm/parallel-display.c b/drivers/staging/imx-drm/parallel-display.c
> index 49c90c3..adc011d 100644
> --- a/drivers/staging/imx-drm/parallel-display.c
> +++ b/drivers/staging/imx-drm/parallel-display.c
> @@ -232,6 +232,8 @@ static int imx_pd_probe(struct platform_device *pdev)
>  
>  	platform_set_drvdata(pdev, imxpd);
>  
> +	of_get_drm_display_mode(np, &imxpd->mode, 0);
> +

I'd prefer something like

	ret = of_get_drm_display_mode(np, &imxpd->mode, 0);
	if (!ret)
		imxpd->mode_valid = 1;

here.

regards
Philipp