linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [V2 patch 13/19] ARM: OMAP4: cpuidle: use init/exit common routine
Date: Thu, 11 Apr 2013 22:42:43 +0200	[thread overview]
Message-ID: <1365712969-7541-14-git-send-email-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <1365712969-7541-1-git-send-email-daniel.lezcano@linaro.org>

Remove the duplicated code and use the cpuidle common code for initialization.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 arch/arm/mach-omap2/cpuidle44xx.c |   22 ++--------------------
 1 file changed, 2 insertions(+), 20 deletions(-)

diff --git a/arch/arm/mach-omap2/cpuidle44xx.c b/arch/arm/mach-omap2/cpuidle44xx.c
index cd188de..861dd90 100644
--- a/arch/arm/mach-omap2/cpuidle44xx.c
+++ b/arch/arm/mach-omap2/cpuidle44xx.c
@@ -15,6 +15,7 @@
 #include <linux/cpu_pm.h>
 #include <linux/export.h>
 
+#include <asm/cpuidle.h>
 #include <asm/proc-fns.h>
 
 #include "common.h"
@@ -157,8 +158,6 @@ fail:
 	return index;
 }
 
-static DEFINE_PER_CPU(struct cpuidle_device, omap4_idle_dev);
-
 static struct cpuidle_driver omap4_idle_driver = {
 	.name				= "omap4_idle",
 	.owner				= THIS_MODULE,
@@ -207,9 +206,6 @@ static struct cpuidle_driver omap4_idle_driver = {
  */
 int __init omap4_idle_init(void)
 {
-	struct cpuidle_device *dev;
-	unsigned int cpu_id = 0;
-
 	mpu_pd = pwrdm_lookup("mpu_pwrdm");
 	cpu_pd[0] = pwrdm_lookup("cpu0_pwrdm");
 	cpu_pd[1] = pwrdm_lookup("cpu1_pwrdm");
@@ -221,19 +217,5 @@ int __init omap4_idle_init(void)
 	if (!cpu_clkdm[0] || !cpu_clkdm[1])
 		return -ENODEV;
 
-	for_each_cpu(cpu_id, cpu_online_mask) {
-		dev = &per_cpu(omap4_idle_dev, cpu_id);
-		dev->cpu = cpu_id;
-#ifdef CONFIG_ARCH_NEEDS_CPU_IDLE_COUPLED
-		dev->coupled_cpus = *cpu_online_mask;
-#endif
-		cpuidle_register_driver(&omap4_idle_driver);
-
-		if (cpuidle_register_device(dev)) {
-			pr_err("%s: CPUidle register failed\n", __func__);
-			return -EIO;
-		}
-	}
-
-	return 0;
+	return cpuidle_register(&omap4_idle_driver, cpu_online_mask);
 }
-- 
1.7.9.5

  parent reply	other threads:[~2013-04-11 20:42 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-11 20:42 [V2 patch 00/19] cpuidle: code consolidation Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 01/19] ARM: shmobile: cpuidle: remove shmobile_enter_wfi function Daniel Lezcano
2013-04-12  0:44   ` Simon Horman
2013-04-12  6:47     ` Daniel Lezcano
2013-04-12  7:06       ` Simon Horman
2013-04-12  7:11         ` Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 02/19] ARM: OMAP3: remove cpuidle_wrap_enter Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 03/19] cpuidle: remove en_core_tk_irqen flag Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 04/19] ARM: ux500: cpuidle: replace for_each_online_cpu by for_each_possible_cpu Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 05/19] ARM: imx: cpuidle: create separate drivers for imx5/imx6 Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 06/19] cpuidle: make a single register function for all Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 07/19] ARM: ux500: cpuidle: use init/exit common routine Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 08/19] ARM: at91: " Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 09/19] ARM: OMAP3: " Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 10/19] ARM: s3c64xx: " Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 11/19] ARM: tegra: " Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 12/19] ARM: shmobile: " Daniel Lezcano
2013-04-11 20:42 ` Daniel Lezcano [this message]
2013-04-11 20:42 ` [V2 patch 14/19] ARM: tegra: cpuidle: use init/exit common routine for tegra2 Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 15/19] ARM: tegra: cpuidle: use init/exit common routine for tegra3 Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 16/19] ARM: calxeda: cpuidle: use init/exit common routine Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 17/19] ARM: kirkwood: " Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 18/19] ARM: davinci: " Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 19/19] ARM: imx: " Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365712969-7541-14-git-send-email-daniel.lezcano@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).