From: mpa@pengutronix.de (Markus Pargmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 10/15] ASoC: fsl-ssi: Use generic DMA bindings if possible
Date: Sun, 14 Apr 2013 13:42:54 +0200 [thread overview]
Message-ID: <1365939779-4507-11-git-send-email-mpa@pengutronix.de> (raw)
In-Reply-To: <1365939779-4507-1-git-send-email-mpa@pengutronix.de>
From: Markus Pargmann <mpa@pengutrnoix.de>
There may be some platforms using fsl-ssi that do not have a DMA driver
with generic DMA bindings. So this patch adds support for the generic
DMA bindings, while still using the old "fsl,dma-events" property if
"dmas" is not found.
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
sound/soc/fsl/fsl_ssi.c | 26 ++++++++++++++++----------
1 file changed, 16 insertions(+), 10 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index 6a9be9c..1ab66f8 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -776,15 +776,19 @@ static int fsl_ssi_probe(struct platform_device *pdev)
&ssi_private->filter_data_tx;
ssi_private->dma_params_rx.filter_data =
&ssi_private->filter_data_rx;
- /*
- * TODO: This is a temporary solution and should be changed
- * to use generic DMA binding later when the helplers get in.
- */
- ret = of_property_read_u32_array(pdev->dev.of_node,
+ if (!of_property_read_bool(pdev->dev.of_node, "dmas") &&
+ ssi_private->use_dma) {
+ /*
+ * TODO: This is a temporary solution and should be
+ * changed to use generic DMA binding later when the
+ * helplers get in.
+ */
+ ret = of_property_read_u32_array(pdev->dev.of_node,
"fsl,ssi-dma-events", dma_events, 2);
- if (ret && !ssi_private->use_dma) {
- dev_err(&pdev->dev, "could not get dma events\n");
- goto error_clk;
+ if (ret && ssi_private->use_dma) {
+ dev_err(&pdev->dev, "could not get dma events but fsl-ssi is configured to use DMA\n");
+ goto error_clk;
+ }
}
shared = of_device_is_compatible(of_get_parent(np),
@@ -847,8 +851,10 @@ static int fsl_ssi_probe(struct platform_device *pdev)
}
} else {
ssi_private->imx_pcm_pdev =
- platform_device_register_simple("imx-pcm-audio",
- -1, NULL, 0);
+ platform_device_register_data(&pdev->dev,
+ "imx-pcm-audio", -1,
+ pdev->dev.of_node,
+ sizeof(*pdev->dev.of_node));
if (IS_ERR(ssi_private->imx_pcm_pdev)) {
ret = PTR_ERR(ssi_private->imx_pcm_pdev);
goto error_dev;
--
1.8.1.5
next prev parent reply other threads:[~2013-04-14 11:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-14 11:42 [PATCH v3 00/15] ASoC: fsl-ssi: ac97-slave support Markus Pargmann
2013-04-14 11:42 ` [PATCH v3 01/15] ASoC: imx-ssi: Fix includes Markus Pargmann
2013-04-14 11:42 ` [PATCH v3 02/15] ASoC: dmaengine-pcm: Replace of specific helper function Markus Pargmann
2013-04-14 11:42 ` [PATCH v3 03/15] ASoC: dmaengine-pcm: Fix function name Markus Pargmann
2013-04-14 11:42 ` [PATCH v3 04/15] ASoC: dmaengine-pcm: Fix pcm_request_chan " Markus Pargmann
2013-04-14 11:42 ` [PATCH v3 05/15] ASoC: phycore-ac97: Add DT support Markus Pargmann
2013-04-16 11:59 ` Mark Brown
2013-04-16 15:23 ` Markus Pargmann
2013-04-14 11:42 ` [PATCH v3 06/15] ASoC: imx-pcm-dma: " Markus Pargmann
2013-04-14 11:42 ` [PATCH v3 07/15] ASoC: imx-pcm-fiq: Introduce pcm-fiq-params Markus Pargmann
2013-04-14 11:42 ` [PATCH v3 08/15] ASoC: fsl-ssi: Add SACNT definitions Markus Pargmann
2013-04-16 12:03 ` Mark Brown
2013-04-14 11:42 ` [PATCH v3 09/15] ASoC: fsl-ssi: Add support for imx-pcm-fiq Markus Pargmann
2013-04-14 11:42 ` Markus Pargmann [this message]
2013-04-14 11:42 ` [PATCH v3 11/15] ARM: imx: Export ac97 reset functions Markus Pargmann
2013-04-14 11:42 ` [PATCH v3 12/15] ASoC: fsl-ssi: imx ac97 support Markus Pargmann
2013-04-14 11:42 ` [PATCH v3 13/15] ASoC: fsl: Kconfig: Use fsl-ssi for phycore-ac97 Markus Pargmann
2013-04-14 11:42 ` [PATCH v3 14/15] ASoC: fsl: Move fsl-ssi binding doc to sound/ Markus Pargmann
2013-04-14 11:42 ` [PATCH v3 15/15] ASoC: fsl: Update fsl-ssi binding doc Markus Pargmann
2013-04-14 12:13 ` [PATCH v3 00/15] ASoC: fsl-ssi: ac97-slave support Lars-Peter Clausen
2013-04-16 0:25 ` Timur Tabi
2013-04-16 8:06 ` Lars-Peter Clausen
2013-04-17 14:12 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365939779-4507-11-git-send-email-mpa@pengutronix.de \
--to=mpa@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).