linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: p.zabel@pengutronix.de (Philipp Zabel)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC][PATCH] video: imx: Select VIDEOMODE_HELPERS
Date: Tue, 23 Apr 2013 09:41:02 +0200	[thread overview]
Message-ID: <1366702862.4365.2.camel@pizza.hi.pengutronix.de> (raw)
In-Reply-To: <201304230157.47992.marex@denx.de>

Hi Marek,

Am Dienstag, den 23.04.2013, 01:57 +0200 schrieb Marek Vasut:
> Dear Fabio Estevam,
> 
> > Hi Marek,
> > 
> > On Mon, Apr 22, 2013 at 6:28 PM, Marek Vasut <marex@denx.de> wrote:
> > > Without this, I get the following problem when building kernel:
> > > 
> > > drivers/built-in.o: In function `imx_pd_connector_get_modes':
> > > /linux-2.6/drivers/staging/imx-drm/parallel-display.c:78: undefined
> > > reference to `of_get_drm_display_mode' make: *** [vmlinux] Error 1
> > > 
> > > NOTE: I think this patch is almost absolutely not correct.
> > > 
> > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> > 
> > Patch looks good, but you should have copied Greg Kroah-Hartman, as he
> > is the one who takes patches into staging.
> 
> I'm not sure if the select is at correct symbol, I dont think it is.

OF_VIDEOMODE is the correct one. The implementation of
of_get_drm_display_mode in drivers/gpu/drm/drm_modes.c depends on it.

regards
Philipp

  parent reply	other threads:[~2013-04-23  7:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-22 21:28 [RFC][PATCH] video: imx: Select VIDEOMODE_HELPERS Marek Vasut
2013-04-22 22:35 ` Fabio Estevam
2013-04-22 23:57   ` Marek Vasut
2013-04-23  5:07     ` Sascha Hauer
2013-04-23 10:29       ` Marek Vasut
2013-04-23 17:43         ` Sascha Hauer
2013-04-23  7:41     ` Philipp Zabel [this message]
2013-04-24  0:31       ` Marek Vasut
2013-04-24  8:22         ` Philipp Zabel
2013-04-24  2:48       ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366702862.4365.2.camel@pizza.hi.pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).